1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
//! Abstractions over files, cloud storage, etc used in persistence.
use std::fmt;
use std::pin::Pin;
use std::sync::Arc;
use std::time::Instant;
use anyhow::anyhow;
use async_trait::async_trait;
use bytes::Bytes;
use futures_util::Stream;
use mz_ore::bytes::SegmentedBytes;
use mz_ore::cast::u64_to_usize;
use mz_postgres_client::error::PostgresError;
use mz_proto::RustType;
use proptest_derive::Arbitrary;
use serde::{Deserialize, Serialize};
use tracing::{Instrument, Span};
use crate::error::Error;
/// The "sequence number" of a persist state change.
///
/// Persist is a state machine, with all mutating requests modeled as input
/// state changes sequenced into a log. This reflects that ordering.
///
/// This ordering also includes requests that were sequenced and applied to the
/// persist state machine, but that application was deterministically made into
/// a no-op because it was contextually invalid (a write or seal at a sealed
/// timestamp, an allow_compactions at an unsealed timestamp, etc).
///
/// Read-only requests are assigned the SeqNo of a write, indicating that all
/// mutating requests up to and including that one are reflected in the read
/// state.
#[derive(
Arbitrary, Clone, Copy, Debug, PartialOrd, Ord, PartialEq, Eq, Hash, Serialize, Deserialize,
)]
pub struct SeqNo(pub u64);
impl std::fmt::Display for SeqNo {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "v{}", self.0)
}
}
impl timely::PartialOrder for SeqNo {
fn less_equal(&self, other: &Self) -> bool {
self <= other
}
}
impl std::str::FromStr for SeqNo {
type Err = String;
fn from_str(encoded: &str) -> Result<Self, Self::Err> {
let encoded = match encoded.strip_prefix('v') {
Some(x) => x,
None => return Err(format!("invalid SeqNo {}: incorrect prefix", encoded)),
};
let seqno =
u64::from_str(encoded).map_err(|err| format!("invalid SeqNo {}: {}", encoded, err))?;
Ok(SeqNo(seqno))
}
}
impl SeqNo {
/// Returns the next SeqNo in the sequence.
pub fn next(self) -> SeqNo {
SeqNo(self.0 + 1)
}
/// A minimum value suitable as a default.
pub fn minimum() -> Self {
SeqNo(0)
}
}
impl RustType<u64> for SeqNo {
fn into_proto(&self) -> u64 {
self.0
}
fn from_proto(proto: u64) -> Result<Self, mz_proto::TryFromProtoError> {
Ok(SeqNo(proto))
}
}
/// An error coming from an underlying durability system (e.g. s3) indicating
/// that the operation _definitely did NOT succeed_ (e.g. permission denied).
#[derive(Debug)]
pub struct Determinate {
inner: anyhow::Error,
}
impl std::fmt::Display for Determinate {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "determinate: ")?;
self.inner.fmt(f)
}
}
impl std::error::Error for Determinate {}
impl Determinate {
/// Return a new Determinate wrapping the given error.
///
/// Exposed for testing via [crate::unreliable].
pub fn new(inner: anyhow::Error) -> Self {
Determinate { inner }
}
}
/// An error coming from an underlying durability system (e.g. s3) indicating
/// that the operation _might have succeeded_ (e.g. timeout).
#[derive(Debug)]
pub struct Indeterminate {
pub(crate) inner: anyhow::Error,
}
impl Indeterminate {
/// Return a new Indeterminate wrapping the given error.
///
/// Exposed for testing.
pub fn new(inner: anyhow::Error) -> Self {
Indeterminate { inner }
}
}
impl std::fmt::Display for Indeterminate {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "indeterminate: ")?;
self.inner.fmt(f)
}
}
impl std::error::Error for Indeterminate {}
/// An impl of PartialEq purely for convenience in tests and debug assertions.
#[cfg(any(test, debug_assertions))]
impl PartialEq for Indeterminate {
fn eq(&self, other: &Self) -> bool {
self.to_string() == other.to_string()
}
}
/// An error coming from an underlying durability system (e.g. s3) or from
/// invalid data received from one.
#[derive(Debug)]
pub enum ExternalError {
/// A determinate error from an external system.
Determinate(Determinate),
/// An indeterminate error from an external system.
Indeterminate(Indeterminate),
}
impl ExternalError {
/// Returns a new error representing a timeout.
///
/// TODO: When we overhaul errors, this presumably should instead be a type
/// that can be matched on.
#[track_caller]
pub fn new_timeout(deadline: Instant) -> Self {
ExternalError::Indeterminate(Indeterminate {
inner: anyhow!("timeout at {:?}", deadline),
})
}
/// Returns whether this error represents a timeout.
///
/// TODO: When we overhaul errors, this presumably should instead be a type
/// that can be matched on.
pub fn is_timeout(&self) -> bool {
// Gross...
self.to_string().contains("timeout")
}
}
impl std::fmt::Display for ExternalError {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
ExternalError::Determinate(x) => std::fmt::Display::fmt(x, f),
ExternalError::Indeterminate(x) => std::fmt::Display::fmt(x, f),
}
}
}
impl std::error::Error for ExternalError {}
/// An impl of PartialEq purely for convenience in tests and debug assertions.
#[cfg(any(test, debug_assertions))]
impl PartialEq for ExternalError {
fn eq(&self, other: &Self) -> bool {
self.to_string() == other.to_string()
}
}
impl From<PostgresError> for ExternalError {
fn from(x: PostgresError) -> Self {
match x {
PostgresError::Determinate(e) => ExternalError::Determinate(Determinate::new(e)),
PostgresError::Indeterminate(e) => ExternalError::Indeterminate(Indeterminate::new(e)),
}
}
}
impl From<Indeterminate> for ExternalError {
fn from(x: Indeterminate) -> Self {
ExternalError::Indeterminate(x)
}
}
impl From<Determinate> for ExternalError {
fn from(x: Determinate) -> Self {
ExternalError::Determinate(x)
}
}
impl From<anyhow::Error> for ExternalError {
fn from(inner: anyhow::Error) -> Self {
ExternalError::Indeterminate(Indeterminate { inner })
}
}
impl From<Error> for ExternalError {
fn from(x: Error) -> Self {
ExternalError::Indeterminate(Indeterminate {
inner: anyhow::Error::new(x),
})
}
}
impl From<std::io::Error> for ExternalError {
fn from(x: std::io::Error) -> Self {
ExternalError::Indeterminate(Indeterminate {
inner: anyhow::Error::new(x),
})
}
}
impl From<deadpool_postgres::tokio_postgres::Error> for ExternalError {
fn from(e: deadpool_postgres::tokio_postgres::Error) -> Self {
let code = match e.as_db_error().map(|x| x.code()) {
Some(x) => x,
None => {
return ExternalError::Indeterminate(Indeterminate {
inner: anyhow::Error::new(e),
})
}
};
match code {
// Feel free to add more things to this allowlist as we encounter
// them as long as you're certain they're determinate.
&deadpool_postgres::tokio_postgres::error::SqlState::T_R_SERIALIZATION_FAILURE => {
ExternalError::Determinate(Determinate {
inner: anyhow::Error::new(e),
})
}
_ => ExternalError::Indeterminate(Indeterminate {
inner: anyhow::Error::new(e),
}),
}
}
}
impl From<deadpool_postgres::PoolError> for ExternalError {
fn from(x: deadpool_postgres::PoolError) -> Self {
match x {
// We have logic for turning a postgres Error into an ExternalError,
// so use it.
deadpool_postgres::PoolError::Backend(x) => ExternalError::from(x),
x => ExternalError::Indeterminate(Indeterminate {
inner: anyhow::Error::new(x),
}),
}
}
}
impl From<tokio::task::JoinError> for ExternalError {
fn from(x: tokio::task::JoinError) -> Self {
ExternalError::Indeterminate(Indeterminate {
inner: anyhow::Error::new(x),
})
}
}
/// An abstraction for a single arbitrarily-sized binary blob and an associated
/// version number (sequence number).
#[derive(Debug, Clone, PartialEq)]
pub struct VersionedData {
/// The sequence number of the data.
pub seqno: SeqNo,
/// The data itself.
pub data: Bytes,
}
/// Helper constant to scan all states in [Consensus::scan].
/// The maximum possible SeqNo is i64::MAX.
// TODO(benesch): find a way to express this without `as`.
#[allow(clippy::as_conversions)]
pub const SCAN_ALL: usize = u64_to_usize(i64::MAX as u64);
/// A key usable for liveness checks via [Consensus::head].
pub const CONSENSUS_HEAD_LIVENESS_KEY: &str = "LIVENESS";
/// Return type to indicate whether [Consensus::compare_and_set] succeeded or failed.
#[derive(Debug, PartialEq)]
pub enum CaSResult {
/// The compare-and-set succeeded and committed new state.
Committed,
/// The compare-and-set failed due to expectation mismatch.
ExpectationMismatch,
}
/// Wraps all calls to a backing store in a new tokio task. This adds extra overhead,
/// but insulates the system from callers who fail to drive futures promptly to completion,
/// which can cause timeouts or resource exhaustion in a store.
#[derive(Debug)]
pub struct Tasked<A>(pub Arc<A>);
impl<A> Tasked<A> {
fn clone_backing(&self) -> Arc<A> {
Arc::clone(&self.0)
}
}
/// A boxed stream, similar to what `async_trait` desugars async functions to, but hardcoded
/// to our standard result type.
pub type ResultStream<'a, T> = Pin<Box<dyn Stream<Item = Result<T, ExternalError>> + Send + 'a>>;
/// An abstraction for [VersionedData] held in a location in persistent storage
/// where the data are conditionally updated by version.
///
/// Users are expected to use this API with consistently increasing sequence numbers
/// to allow multiple processes across multiple machines to agree to a total order
/// of the evolution of the data. To make roundtripping through various forms of durable
/// storage easier, sequence numbers used with [Consensus] need to be restricted to the
/// range [0, i64::MAX].
#[async_trait]
pub trait Consensus: std::fmt::Debug + Send + Sync {
/// Returns all the keys ever created in the consensus store.
fn list_keys(&self) -> ResultStream<String>;
/// Returns a recent version of `data`, and the corresponding sequence number, if
/// one exists at this location.
async fn head(&self, key: &str) -> Result<Option<VersionedData>, ExternalError>;
/// Update the [VersionedData] stored at this location to `new`, iff the
/// current sequence number is exactly `expected` and `new`'s sequence
/// number > the current sequence number.
///
/// It is invalid to call this function with a `new` and `expected` such
/// that `new`'s sequence number is <= `expected`. It is invalid to call
/// this function with a sequence number outside of the range `[0, i64::MAX]`.
///
/// This data is initialized to None, and the first call to compare_and_set
/// needs to happen with None as the expected value to set the state.
async fn compare_and_set(
&self,
key: &str,
expected: Option<SeqNo>,
new: VersionedData,
) -> Result<CaSResult, ExternalError>;
/// Return `limit` versions of data stored for this `key` at sequence numbers >= `from`,
/// in ascending order of sequence number.
///
/// Returns an empty vec if `from` is greater than the current sequence
/// number or if there is no data at this key.
async fn scan(
&self,
key: &str,
from: SeqNo,
limit: usize,
) -> Result<Vec<VersionedData>, ExternalError>;
/// Deletes all historical versions of the data stored at `key` that are <
/// `seqno`, iff `seqno` <= the current sequence number.
///
/// Returns the number of versions deleted on success. Returns an error if
/// `seqno` is greater than the current sequence number, or if there is no
/// data at this key.
async fn truncate(&self, key: &str, seqno: SeqNo) -> Result<usize, ExternalError>;
}
#[async_trait]
impl<A: Consensus + 'static> Consensus for Tasked<A> {
fn list_keys(&self) -> ResultStream<String> {
// Similarly to Blob::list_keys_and_metadata, this is difficult to make into a task.
// (If we use an unbounded channel between the task and the caller, we can buffer forever;
// if we use a bounded channel, we lose the isolation benefits of Tasked.)
// However, this should only be called in administrative contexts
// and not in the main state-machine impl.
self.0.list_keys()
}
async fn head(&self, key: &str) -> Result<Option<VersionedData>, ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::head",
async move { backing.head(&key).await }.instrument(Span::current()),
)
.await?
}
async fn compare_and_set(
&self,
key: &str,
expected: Option<SeqNo>,
new: VersionedData,
) -> Result<CaSResult, ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::cas",
async move { backing.compare_and_set(&key, expected, new).await }
.instrument(Span::current()),
)
.await?
}
async fn scan(
&self,
key: &str,
from: SeqNo,
limit: usize,
) -> Result<Vec<VersionedData>, ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::scan",
async move { backing.scan(&key, from, limit).await }.instrument(Span::current()),
)
.await?
}
async fn truncate(&self, key: &str, seqno: SeqNo) -> Result<usize, ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::truncate",
async move { backing.truncate(&key, seqno).await }.instrument(Span::current()),
)
.await?
}
}
/// Metadata about a particular blob stored by persist
#[derive(Debug)]
pub struct BlobMetadata<'a> {
/// The key for the blob
pub key: &'a str,
/// Size of the blob
pub size_in_bytes: u64,
}
/// A key usable for liveness checks via [Blob::get].
pub const BLOB_GET_LIVENESS_KEY: &str = "LIVENESS";
/// An abstraction over read-write access to a `bytes key`->`bytes value` store.
///
/// Implementations are required to be _linearizable_.
///
/// TODO: Consider whether this can be relaxed. Since our usage is write-once
/// modify-never, it certainly seems like we could by adding retries around
/// `get` to wait for a non-linearizable `set` to show up. However, the tricky
/// bit comes once we stop handing out seqno capabilities to readers and have to
/// start reasoning about "this set hasn't show up yet" vs "the blob has already
/// been deleted". Another tricky problem is the same but for a deletion when
/// the first attempt timed out.
#[async_trait]
pub trait Blob: std::fmt::Debug + Send + Sync {
/// Returns a reference to the value corresponding to the key.
async fn get(&self, key: &str) -> Result<Option<SegmentedBytes>, ExternalError>;
/// List all of the keys in the map with metadata about the entry.
///
/// Can be optionally restricted to only list keys starting with a
/// given prefix.
async fn list_keys_and_metadata(
&self,
key_prefix: &str,
f: &mut (dyn FnMut(BlobMetadata) + Send + Sync),
) -> Result<(), ExternalError>;
/// Inserts a key-value pair into the map.
///
/// Writes must be atomic and either succeed or leave the previous value
/// intact.
async fn set(&self, key: &str, value: Bytes) -> Result<(), ExternalError>;
/// Remove a key from the map.
///
/// Returns Some and the size of the deleted blob if if exists. Succeeds and
/// returns None if it does not exist.
async fn delete(&self, key: &str) -> Result<Option<usize>, ExternalError>;
/// Restores a previously-deleted key to the map, if possible.
///
/// Returns successfully if the key exists after this call: perhaps because it already existed
/// or was restored. (In particular, this makes restore idempotent.)
/// Fails if we were unable to restore any value for that key:
/// perhaps the key was never written, or was permanently deleted.
///
/// It is acceptable for [Blob::restore] to be unable
/// to restore keys, in which case this method should succeed iff the key exists.
async fn restore(&self, key: &str) -> Result<(), ExternalError>;
}
#[async_trait]
impl<A: Blob + 'static> Blob for Tasked<A> {
async fn get(&self, key: &str) -> Result<Option<SegmentedBytes>, ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::get",
async move { backing.get(&key).await }.instrument(Span::current()),
)
.await?
}
/// List all of the keys in the map with metadata about the entry.
///
/// Can be optionally restricted to only list keys starting with a
/// given prefix.
async fn list_keys_and_metadata(
&self,
key_prefix: &str,
f: &mut (dyn FnMut(BlobMetadata) + Send + Sync),
) -> Result<(), ExternalError> {
// TODO: No good way that I can see to make this one a task because of
// the closure and Blob needing to be object-safe.
self.0.list_keys_and_metadata(key_prefix, f).await
}
/// Inserts a key-value pair into the map.
async fn set(&self, key: &str, value: Bytes) -> Result<(), ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::set",
async move { backing.set(&key, value).await }.instrument(Span::current()),
)
.await?
}
/// Remove a key from the map.
///
/// Returns Some and the size of the deleted blob if if exists. Succeeds and
/// returns None if it does not exist.
async fn delete(&self, key: &str) -> Result<Option<usize>, ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::delete",
async move { backing.delete(&key).await }.instrument(Span::current()),
)
.await?
}
async fn restore(&self, key: &str) -> Result<(), ExternalError> {
let backing = self.clone_backing();
let key = key.to_owned();
mz_ore::task::spawn(
|| "persist::task::restore",
async move { backing.restore(&key).await }.instrument(Span::current()),
)
.await?
}
}
#[cfg(test)]
pub mod tests {
use std::future::Future;
use anyhow::anyhow;
use futures_util::TryStreamExt;
use mz_ore::assert_err;
use uuid::Uuid;
use crate::location::Blob;
use super::*;
fn keys(baseline: &[String], new: &[&str]) -> Vec<String> {
let mut ret = baseline.to_vec();
ret.extend(new.iter().map(|x| x.to_string()));
ret.sort();
ret
}
async fn get_keys(b: &impl Blob) -> Result<Vec<String>, ExternalError> {
let mut keys = vec![];
b.list_keys_and_metadata("", &mut |entry| keys.push(entry.key.to_string()))
.await?;
Ok(keys)
}
async fn get_keys_with_prefix(
b: &impl Blob,
prefix: &str,
) -> Result<Vec<String>, ExternalError> {
let mut keys = vec![];
b.list_keys_and_metadata(prefix, &mut |entry| keys.push(entry.key.to_string()))
.await?;
Ok(keys)
}
pub async fn blob_impl_test<
B: Blob,
F: Future<Output = Result<B, ExternalError>>,
NewFn: Fn(&'static str) -> F,
>(
new_fn: NewFn,
) -> Result<(), ExternalError> {
let values = ["v0".as_bytes().to_vec(), "v1".as_bytes().to_vec()];
let blob0 = new_fn("path0").await?;
// We can create a second blob writing to a different place.
let _ = new_fn("path1").await?;
// We can open two blobs to the same place, even.
let blob1 = new_fn("path0").await?;
let k0 = "foo/bar/k0";
// Empty key is empty.
assert_eq!(blob0.get(k0).await?, None);
assert_eq!(blob1.get(k0).await?, None);
// Empty list keys is empty.
let empty_keys = get_keys(&blob0).await?;
assert_eq!(empty_keys, Vec::<String>::new());
let empty_keys = get_keys(&blob1).await?;
assert_eq!(empty_keys, Vec::<String>::new());
// Set a key and get it back.
blob0.set(k0, values[0].clone().into()).await?;
assert_eq!(
blob0.get(k0).await?.map(|s| s.into_contiguous()),
Some(values[0].clone())
);
assert_eq!(
blob1.get(k0).await?.map(|s| s.into_contiguous()),
Some(values[0].clone())
);
// Set another key and get it back.
blob0.set("k0a", values[0].clone().into()).await?;
assert_eq!(
blob0.get("k0a").await?.map(|s| s.into_contiguous()),
Some(values[0].clone())
);
assert_eq!(
blob1.get("k0a").await?.map(|s| s.into_contiguous()),
Some(values[0].clone())
);
// Blob contains the key we just inserted.
let mut blob_keys = get_keys(&blob0).await?;
blob_keys.sort();
assert_eq!(blob_keys, keys(&empty_keys, &[k0, "k0a"]));
let mut blob_keys = get_keys(&blob1).await?;
blob_keys.sort();
assert_eq!(blob_keys, keys(&empty_keys, &[k0, "k0a"]));
// Can overwrite a key.
blob0.set(k0, values[1].clone().into()).await?;
assert_eq!(
blob0.get(k0).await?.map(|s| s.into_contiguous()),
Some(values[1].clone())
);
assert_eq!(
blob1.get(k0).await?.map(|s| s.into_contiguous()),
Some(values[1].clone())
);
// Can overwrite another key.
blob0.set("k0a", values[1].clone().into()).await?;
assert_eq!(
blob0.get("k0a").await?.map(|s| s.into_contiguous()),
Some(values[1].clone())
);
assert_eq!(
blob1.get("k0a").await?.map(|s| s.into_contiguous()),
Some(values[1].clone())
);
// Can delete a key.
assert_eq!(blob0.delete(k0).await, Ok(Some(2)));
// Can no longer get a deleted key.
assert_eq!(blob0.get(k0).await?, None);
assert_eq!(blob1.get(k0).await?, None);
// Double deleting a key succeeds but indicates that it did no work.
assert_eq!(blob0.delete(k0).await, Ok(None));
// Deleting a key that does not exist succeeds.
assert_eq!(blob0.delete("nope").await, Ok(None));
// Deleting a key with an empty value indicates it did work but deleted
// no bytes.
blob0.set("empty", Bytes::new()).await?;
assert_eq!(blob0.delete("empty").await, Ok(Some(0)));
// Attempt to restore a key. Not all backends will be able to restore, but
// we can confirm that our data is visible iff restore reported success.
blob0.set("undelete", Bytes::from("data")).await?;
// Restoring should always succeed when the key exists.
blob0.restore("undelete").await?;
assert_eq!(blob0.delete("undelete").await?, Some("data".len()));
let expected = match blob0.restore("undelete").await {
Ok(()) => Some(Bytes::from("data").into()),
Err(ExternalError::Determinate(_)) => None,
Err(other) => return Err(other),
};
assert_eq!(blob0.get("undelete").await?, expected);
blob0.delete("undelete").await?;
// Empty blob contains no keys.
blob0.delete("k0a").await?;
let mut blob_keys = get_keys(&blob0).await?;
blob_keys.sort();
assert_eq!(blob_keys, empty_keys);
let mut blob_keys = get_keys(&blob1).await?;
blob_keys.sort();
assert_eq!(blob_keys, empty_keys);
// Can reset a deleted key to some other value.
blob0.set(k0, values[1].clone().into()).await?;
assert_eq!(
blob1.get(k0).await?.map(|s| s.into_contiguous()),
Some(values[1].clone())
);
assert_eq!(
blob0.get(k0).await?.map(|s| s.into_contiguous()),
Some(values[1].clone())
);
// Insert multiple keys back to back and validate that we can list
// them all out.
let mut expected_keys = empty_keys;
for i in 1..=5 {
let key = format!("k{}", i);
blob0.set(&key, values[0].clone().into()).await?;
expected_keys.push(key);
}
// Blob contains the key we just inserted.
let mut blob_keys = get_keys(&blob0).await?;
blob_keys.sort();
assert_eq!(blob_keys, keys(&expected_keys, &[k0]));
let mut blob_keys = get_keys(&blob1).await?;
blob_keys.sort();
assert_eq!(blob_keys, keys(&expected_keys, &[k0]));
// Insert multiple keys with a different prefix and validate that we can
// list out keys by their prefix
let mut expected_prefix_keys = vec![];
for i in 1..=3 {
let key = format!("k-prefix-{}", i);
blob0.set(&key, values[0].clone().into()).await?;
expected_prefix_keys.push(key);
}
let mut blob_keys = get_keys_with_prefix(&blob0, "k-prefix").await?;
blob_keys.sort();
assert_eq!(blob_keys, expected_prefix_keys);
let mut blob_keys = get_keys_with_prefix(&blob0, "k").await?;
blob_keys.sort();
expected_keys.extend(expected_prefix_keys);
expected_keys.sort();
assert_eq!(blob_keys, expected_keys);
// We can open a new blob to the same path and use it.
let blob3 = new_fn("path0").await?;
assert_eq!(
blob3.get(k0).await?.map(|s| s.into_contiguous()),
Some(values[1].clone())
);
Ok(())
}
pub async fn consensus_impl_test<
C: Consensus,
F: Future<Output = Result<C, ExternalError>>,
NewFn: FnMut() -> F,
>(
mut new_fn: NewFn,
) -> Result<(), ExternalError> {
let consensus = new_fn().await?;
// Use a random key so independent runs of this test don't interfere
// with each other.
let key = Uuid::new_v4().to_string();
// Starting value of consensus data is None.
assert_eq!(consensus.head(&key).await, Ok(None));
// Can scan a key that has no data.
assert_eq!(consensus.scan(&key, SeqNo(0), SCAN_ALL).await, Ok(vec![]));
// Cannot truncate data from a key that doesn't have any data
assert_err!(consensus.truncate(&key, SeqNo(0)).await);
let state = VersionedData {
seqno: SeqNo(5),
data: Bytes::from("abc"),
};
// Incorrectly setting the data with a non-None expected should fail.
assert_eq!(
consensus
.compare_and_set(&key, Some(SeqNo(0)), state.clone())
.await,
Ok(CaSResult::ExpectationMismatch),
);
// Correctly updating the state with the correct expected value should succeed.
assert_eq!(
consensus.compare_and_set(&key, None, state.clone()).await,
Ok(CaSResult::Committed),
);
// The new key is visible in state.
let keys: Vec<_> = consensus.list_keys().try_collect().await?;
assert_eq!(keys, vec![key.to_owned()]);
// We can observe the a recent value on successful update.
assert_eq!(consensus.head(&key).await, Ok(Some(state.clone())));
// Can scan a key that has data with a lower bound sequence number < head.
assert_eq!(
consensus.scan(&key, SeqNo(0), SCAN_ALL).await,
Ok(vec![state.clone()])
);
// Can scan a key that has data with a lower bound sequence number == head.
assert_eq!(
consensus.scan(&key, SeqNo(5), SCAN_ALL).await,
Ok(vec![state.clone()])
);
// Can scan a key that has data with a lower bound sequence number >
// head.
assert_eq!(consensus.scan(&key, SeqNo(6), SCAN_ALL).await, Ok(vec![]));
// Can truncate data with an upper bound <= head, even if there is no data in the
// range [0, upper).
assert_eq!(consensus.truncate(&key, SeqNo(0)).await, Ok(0));
assert_eq!(consensus.truncate(&key, SeqNo(5)).await, Ok(0));
// Cannot truncate data with an upper bound > head.
assert_err!(consensus.truncate(&key, SeqNo(6)).await);
let new_state = VersionedData {
seqno: SeqNo(10),
data: Bytes::from("def"),
};
// Trying to update without the correct expected seqno fails, (even if expected > current)
assert_eq!(
consensus
.compare_and_set(&key, Some(SeqNo(7)), new_state.clone())
.await,
Ok(CaSResult::ExpectationMismatch),
);
// Trying to update without the correct expected seqno fails, (even if expected < current)
assert_eq!(
consensus
.compare_and_set(&key, Some(SeqNo(3)), new_state.clone())
.await,
Ok(CaSResult::ExpectationMismatch),
);
let invalid_constant_seqno = VersionedData {
seqno: SeqNo(5),
data: Bytes::from("invalid"),
};
// Trying to set the data to a sequence number == current fails even if
// expected is correct.
assert_eq!(
consensus
.compare_and_set(&key, Some(state.seqno), invalid_constant_seqno)
.await,
Err(ExternalError::from(anyhow!("new seqno must be strictly greater than expected. Got new: SeqNo(5) expected: SeqNo(5)")))
);
let invalid_regressing_seqno = VersionedData {
seqno: SeqNo(3),
data: Bytes::from("invalid"),
};
// Trying to set the data to a sequence number < current fails even if
// expected is correct.
assert_eq!(
consensus
.compare_and_set(&key, Some(state.seqno), invalid_regressing_seqno)
.await,
Err(ExternalError::from(anyhow!("new seqno must be strictly greater than expected. Got new: SeqNo(3) expected: SeqNo(5)")))
);
// Can correctly update to a new state if we provide the right expected seqno
assert_eq!(
consensus
.compare_and_set(&key, Some(state.seqno), new_state.clone())
.await,
Ok(CaSResult::Committed),
);
// We can observe the a recent value on successful update.
assert_eq!(consensus.head(&key).await, Ok(Some(new_state.clone())));
// We can observe both states in the correct order with scan if pass
// in a suitable lower bound.
assert_eq!(
consensus.scan(&key, SeqNo(5), SCAN_ALL).await,
Ok(vec![state.clone(), new_state.clone()])
);
// We can observe only the most recent state if the lower bound is higher
// than the previous insertion's sequence number.
assert_eq!(
consensus.scan(&key, SeqNo(6), SCAN_ALL).await,
Ok(vec![new_state.clone()])
);
// We can still observe the most recent insert as long as the provided
// lower bound == most recent 's sequence number.
assert_eq!(
consensus.scan(&key, SeqNo(10), SCAN_ALL).await,
Ok(vec![new_state.clone()])
);
// We can scan if the provided lower bound > head's sequence number.
assert_eq!(consensus.scan(&key, SeqNo(11), SCAN_ALL).await, Ok(vec![]));
// We can scan with limits that don't cover all states
assert_eq!(
consensus.scan(&key, SeqNo::minimum(), 1).await,
Ok(vec![state.clone()])
);
assert_eq!(
consensus.scan(&key, SeqNo(5), 1).await,
Ok(vec![state.clone()])
);
// We can scan with limits to cover exactly the number of states
assert_eq!(
consensus.scan(&key, SeqNo::minimum(), 2).await,
Ok(vec![state.clone(), new_state.clone()])
);
// We can scan with a limit larger than the number of states
assert_eq!(
consensus.scan(&key, SeqNo(4), 100).await,
Ok(vec![state.clone(), new_state.clone()])
);
// Can remove the previous write with the appropriate truncation.
assert_eq!(consensus.truncate(&key, SeqNo(6)).await, Ok(1));
// Verify that the old write is indeed deleted.
assert_eq!(
consensus.scan(&key, SeqNo(0), SCAN_ALL).await,
Ok(vec![new_state.clone()])
);
// Truncate is idempotent and can be repeated. The return value
// indicates we didn't do any work though.
assert_eq!(consensus.truncate(&key, SeqNo(6)).await, Ok(0));
// Make sure entries under different keys don't clash.
let other_key = Uuid::new_v4().to_string();
assert_eq!(consensus.head(&other_key).await, Ok(None));
let state = VersionedData {
seqno: SeqNo(1),
data: Bytes::from("einszweidrei"),
};
assert_eq!(
consensus
.compare_and_set(&other_key, None, state.clone())
.await,
Ok(CaSResult::Committed),
);
assert_eq!(consensus.head(&other_key).await, Ok(Some(state.clone())));
// State for the first key is still as expected.
assert_eq!(consensus.head(&key).await, Ok(Some(new_state.clone())));
// Trying to update from a stale version of current doesn't work.
let invalid_jump_forward = VersionedData {
seqno: SeqNo(11),
data: Bytes::from("invalid"),
};
assert_eq!(
consensus
.compare_and_set(&key, Some(state.seqno), invalid_jump_forward)
.await,
Ok(CaSResult::ExpectationMismatch),
);
// Writing a large (~10 KiB) amount of data works fine.
let large_state = VersionedData {
seqno: SeqNo(11),
data: std::iter::repeat(b'a').take(10240).collect(),
};
assert_eq!(
consensus
.compare_and_set(&key, Some(new_state.seqno), large_state)
.await,
Ok(CaSResult::Committed),
);
// Truncate can delete more than one version at a time.
let v12 = VersionedData {
seqno: SeqNo(12),
data: Bytes::new(),
};
assert_eq!(
consensus.compare_and_set(&key, Some(SeqNo(11)), v12).await,
Ok(CaSResult::Committed),
);
assert_eq!(consensus.truncate(&key, SeqNo(12)).await, Ok(2));
// Sequence numbers used within Consensus have to be within [0, i64::MAX].
assert_eq!(
consensus
.compare_and_set(
&Uuid::new_v4().to_string(),
None,
VersionedData {
seqno: SeqNo(0),
data: Bytes::new(),
}
)
.await,
Ok(CaSResult::Committed),
);
assert_eq!(
consensus
.compare_and_set(
&Uuid::new_v4().to_string(),
None,
VersionedData {
seqno: SeqNo(i64::MAX.try_into().expect("i64::MAX fits in u64")),
data: Bytes::new(),
}
)
.await,
Ok(CaSResult::Committed),
);
assert_err!(
consensus
.compare_and_set(
&Uuid::new_v4().to_string(),
None,
VersionedData {
seqno: SeqNo(1 << 63),
data: Bytes::new(),
}
)
.await
);
assert_err!(
consensus
.compare_and_set(
&Uuid::new_v4().to_string(),
None,
VersionedData {
seqno: SeqNo(u64::MAX),
data: Bytes::new(),
}
)
.await
);
Ok(())
}
#[mz_ore::test]
fn timeout_error() {
assert!(ExternalError::new_timeout(Instant::now()).is_timeout());
assert!(!ExternalError::from(anyhow!("foo")).is_timeout());
}
}