1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
//! Support for checking whether clusters/collections are caught up during a 0dt
//! deployment.
use std::collections::{BTreeMap, BTreeSet};
use differential_dataflow::lattice::Lattice as _;
use itertools::Itertools;
use mz_adapter_types::dyncfgs::{
ENABLE_0DT_CAUGHT_UP_CHECK, WITH_0DT_CAUGHT_UP_CHECK_ALLOWED_LAG,
WITH_0DT_CAUGHT_UP_CHECK_CUTOFF,
};
use mz_catalog::builtin::MZ_CLUSTER_REPLICA_FRONTIERS;
use mz_catalog::memory::objects::Cluster;
use mz_ore::channel::trigger::Trigger;
use mz_repr::{GlobalId, Timestamp};
use timely::progress::{Antichain, Timestamp as _};
use timely::PartialOrder;
use crate::coord::Coordinator;
/// Context needed to check whether clusters/collections are caught up.
#[derive(Debug)]
pub struct CaughtUpCheckContext {
/// A trigger that signals that all clusters/collections have been caught
/// up.
pub trigger: Trigger,
/// Collections to exclude from the caught up check.
///
/// When a caught up check is performed as part of a 0dt upgrade, it makes sense to exclude
/// collections of newly added builtin objects, as these might not hydrate in read-only mode.
pub exclude_collections: BTreeSet<GlobalId>,
}
impl Coordinator {
/// Checks that all clusters/collections are caught up. If so, this will
/// trigger `self.catchup_check.trigger`.
///
/// This method is a no-op when the trigger has already been fired.
pub async fn maybe_check_caught_up(&mut self) {
let enable_caught_up_check =
ENABLE_0DT_CAUGHT_UP_CHECK.get(self.catalog().system_config().dyncfgs());
if enable_caught_up_check {
self.maybe_check_caught_up_new().await
} else {
self.maybe_check_caught_up_legacy().await
}
}
async fn maybe_check_caught_up_new(&mut self) {
let Some(ctx) = &self.caught_up_check else {
return;
};
let replica_frontier_item_id = self
.catalog()
.resolve_builtin_storage_collection(&MZ_CLUSTER_REPLICA_FRONTIERS);
let replica_frontier_gid = self
.catalog()
.get_entry(&replica_frontier_item_id)
.latest_global_id();
let live_frontiers = self
.controller
.storage
.snapshot_latest(replica_frontier_gid)
.await
.expect("can't read mz_cluster_replica_frontiers");
let live_frontiers = live_frontiers
.into_iter()
.map(|row| {
let mut iter = row.into_iter();
let id: GlobalId = iter
.next()
.expect("missing object id")
.unwrap_str()
.parse()
.expect("cannot parse id");
let replica_id = iter
.next()
.expect("missing replica id")
.unwrap_str()
.to_string();
let maybe_upper_ts = iter.next().expect("missing upper_ts");
// The timestamp has a total order, so there can be at
// most one entry in the upper frontier, which is this
// timestamp here. And NULL encodes the empty upper
// frontier.
let upper_frontier = if maybe_upper_ts.is_null() {
Antichain::new()
} else {
let upper_ts = maybe_upper_ts.unwrap_mz_timestamp();
Antichain::from_elem(upper_ts)
};
(id, replica_id, upper_frontier)
})
.collect_vec();
// We care about each collection being hydrated on _some_
// replica. We don't check that at least one replica has all
// collections of that cluster hydrated.
let live_collection_frontiers: BTreeMap<_, _> = live_frontiers
.into_iter()
.map(|(oid, _replica_id, upper_ts)| (oid, upper_ts))
.into_grouping_map()
.fold(
Antichain::from_elem(Timestamp::minimum()),
|mut acc, _key, upper| {
acc.join_assign(&upper);
acc
},
)
.into_iter()
.collect();
tracing::debug!(?live_collection_frontiers, "checking re-hydration status");
let allowed_lag =
WITH_0DT_CAUGHT_UP_CHECK_ALLOWED_LAG.get(self.catalog().system_config().dyncfgs());
let allowed_lag: u64 = allowed_lag
.as_millis()
.try_into()
.expect("must fit into u64");
let cutoff = WITH_0DT_CAUGHT_UP_CHECK_CUTOFF.get(self.catalog().system_config().dyncfgs());
let cutoff: u64 = cutoff.as_millis().try_into().expect("must fit into u64");
let now = self.now();
let compute_caught_up = self
.clusters_caught_up(
allowed_lag.into(),
cutoff.into(),
now.into(),
&live_collection_frontiers,
&ctx.exclude_collections,
)
.await;
tracing::info!(%compute_caught_up, "checked caught-up status of collections");
if compute_caught_up {
let ctx = self.caught_up_check.take().expect("known to exist");
ctx.trigger.fire();
}
}
/// Returns `true` if all non-transient, non-excluded collections have their write
/// frontier (aka. upper) within `allowed_lag` of the "live" frontier
/// reported in `live_frontiers`. The "live" frontiers are frontiers as
/// reported by a currently running `environmentd` deployment, during a 0dt
/// upgrade.
///
/// Collections whose write frontier is behind `now` by more than the cutoff
/// are ignored.
///
/// For this check, zero-replica clusters are always considered caught up.
/// Their collections would never normally be considered caught up but it's
/// clearly intentional that they have no replicas.
async fn clusters_caught_up(
&self,
allowed_lag: Timestamp,
cutoff: Timestamp,
now: Timestamp,
live_frontiers: &BTreeMap<GlobalId, Antichain<Timestamp>>,
exclude_collections: &BTreeSet<GlobalId>,
) -> bool {
let mut result = true;
for cluster in self.catalog().clusters() {
let caught_up = self
.collections_caught_up(
cluster,
allowed_lag.clone(),
cutoff.clone(),
now.clone(),
live_frontiers,
exclude_collections,
)
.await;
let caught_up = caught_up.unwrap_or_else(|e| {
tracing::error!(
"unexpected error while checking if cluster {} caught up: {e:#}",
cluster.id
);
false
});
if !caught_up {
result = false;
// We continue with our loop instead of breaking out early, so
// that we log all non-caught up clusters.
tracing::info!("cluster {} is not caught up", cluster.id);
}
}
result
}
/// Returns `true` if all non-transient, non-excluded collections have their write
/// frontier (aka. upper) within `allowed_lag` of the "live" frontier
/// reported in `live_frontiers`. The "live" frontiers are frontiers as
/// reported by a currently running `environmentd` deployment, during a 0dt
/// upgrade.
///
/// Collections whose write frontier is behind `now` by more than the cutoff
/// are ignored.
///
/// This also returns `true` in case this cluster does not have any
/// replicas.
async fn collections_caught_up(
&self,
cluster: &Cluster,
allowed_lag: Timestamp,
cutoff: Timestamp,
now: Timestamp,
live_frontiers: &BTreeMap<GlobalId, Antichain<Timestamp>>,
exclude_collections: &BTreeSet<GlobalId>,
) -> Result<bool, anyhow::Error> {
if cluster.replicas().next().is_none() {
return Ok(true);
}
enum CollectionType {
Storage,
Compute,
}
let mut all_caught_up = true;
let storage_frontiers = self
.controller
.storage
.active_ingestions(cluster.id)
.iter()
.copied()
.filter(|id| !id.is_transient() && !exclude_collections.contains(id))
.map(|id| {
let (_read_frontier, write_frontier) =
self.controller.storage.collection_frontiers(id)?;
Ok::<_, anyhow::Error>((id, write_frontier, CollectionType::Storage))
});
let compute_frontiers = self
.controller
.compute
.collection_ids(cluster.id)?
.filter(|id| !id.is_transient() && !exclude_collections.contains(id))
.map(|id| {
let write_frontier = self
.controller
.compute
.collection_frontiers(id, Some(cluster.id))?
.write_frontier
.to_owned();
Ok((id, write_frontier, CollectionType::Compute))
});
for res in itertools::chain(storage_frontiers, compute_frontiers) {
let (id, write_frontier, collection_type) = res?;
let live_write_frontier = match live_frontiers.get(&id) {
Some(frontier) => frontier,
None => {
// The collection didn't previously exist, so consider
// ourselves hydrated as long as our write_ts is > 0.
tracing::info!(?write_frontier, "collection {id} not in live frontiers");
if write_frontier.less_equal(&Timestamp::minimum()) {
all_caught_up = false;
}
continue;
}
};
// We can't do comparisons and subtractions, so we bump up the live
// write frontier by the cutoff, and then compare that against
// `now`.
let live_write_frontier_plus_cutoff = live_write_frontier
.iter()
.map(|t| t.step_forward_by(&cutoff));
let live_write_frontier_plus_cutoff =
Antichain::from_iter(live_write_frontier_plus_cutoff);
let beyond_all_hope = live_write_frontier_plus_cutoff.less_equal(&now);
if beyond_all_hope {
tracing::info!(?live_write_frontier, ?now, "live write frontier of collection {id} is too far behind 'now', ignoring for caught-up checks");
continue;
}
// We can't do easy comparisons and subtractions, so we bump up the
// write frontier by the allowed lag, and then compare that against
// the write frontier.
let write_frontier_plus_allowed_lag = write_frontier
.iter()
.map(|t| t.step_forward_by(&allowed_lag));
let bumped_write_plus_allowed_lag =
Antichain::from_iter(write_frontier_plus_allowed_lag);
let within_lag =
PartialOrder::less_equal(live_write_frontier, &bumped_write_plus_allowed_lag);
// This call is on the expensive side, because we have to do a call
// across a task/channel boundary, and our work competes with other
// things the compute/instance controller might be doing. But it's
// okay because we only do these hydration checks when in read-only
// mode, and only rarely.
let collection_hydrated = match collection_type {
CollectionType::Compute => {
self.controller
.compute
.collection_hydrated(cluster.id, id)
.await?
}
CollectionType::Storage => {
// TODO: Hydration check for storage collections!
true
}
};
if within_lag && collection_hydrated {
// This is a bit spammy, but log caught-up collections while we
// investigate why environments are cutting over but then a lot
// of compute collections are _not_ in fact hydrated on
// clusters.
tracing::info!(
%id,
%within_lag,
%collection_hydrated,
?write_frontier,
?live_write_frontier,
?allowed_lag,
%cluster.id,
"collection is caught up");
} else {
// We are not within the allowed lag, or not hydrated!
//
// We continue with our loop instead of breaking out early, so
// that we log all non-caught-up replicas.
tracing::info!(
%id,
%within_lag,
%collection_hydrated,
?write_frontier,
?live_write_frontier,
?allowed_lag,
%cluster.id,
"collection is not caught up"
);
all_caught_up = false;
}
}
Ok(all_caught_up)
}
async fn maybe_check_caught_up_legacy(&mut self) {
let Some(ctx) = &self.caught_up_check else {
return;
};
let compute_hydrated = self
.controller
.compute
.clusters_hydrated(&ctx.exclude_collections)
.await;
tracing::info!(%compute_hydrated, "checked hydration status of clusters");
if compute_hydrated {
let ctx = self.caught_up_check.take().expect("known to exist");
ctx.trigger.fire();
}
}
}