1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
//! File backed implementations for testing and benchmarking.
use std::io::ErrorKind;
use std::path::{Path, PathBuf};
use anyhow::anyhow;
use async_trait::async_trait;
use bytes::Bytes;
use fail::fail_point;
use mz_ore::bytes::SegmentedBytes;
use mz_ore::cast::CastFrom;
use tokio::fs::{self, File};
use tokio::io::{AsyncReadExt, AsyncWriteExt};
use crate::error::Error;
use crate::location::{Blob, BlobMetadata, Determinate, ExternalError};
/// Configuration for opening a [FileBlob].
#[derive(Debug, Clone)]
pub struct FileBlobConfig {
base_dir: PathBuf,
pub(crate) tombstone: bool,
}
impl<P: AsRef<Path>> From<P> for FileBlobConfig {
fn from(base_dir: P) -> Self {
FileBlobConfig {
base_dir: base_dir.as_ref().to_path_buf(),
tombstone: false,
}
}
}
/// Implementation of [Blob] backed by files.
#[derive(Debug)]
pub struct FileBlob {
base_dir: PathBuf,
tombstone: bool,
}
impl FileBlob {
/// Opens the given location for non-exclusive read-write access.
pub async fn open(config: FileBlobConfig) -> Result<Self, ExternalError> {
let FileBlobConfig {
base_dir,
tombstone,
} = config;
fs::create_dir_all(&base_dir).await.map_err(Error::from)?;
Ok(FileBlob {
base_dir,
tombstone,
})
}
fn blob_path(&self, key: &str) -> PathBuf {
self.base_dir.join(key)
}
/// For simplicity, FileBlob maintains a single flat directory of blobs. Because files
/// can never use forward slashes in their names on Linux, even if escaped, we replace
/// forward slashes with a Unicode character that looks substantially similar, so the
/// file name is not interpreted as part of a directory structure. This is helpful for
/// compatibility with clients who are expecting an S3-like interface that both use a
/// flat hierarchy and allow forward slashes in file names.
///
/// (And apologies to the callers who really did want to use U+2215 code points in their
/// filenames.)
fn replace_forward_slashes(key: &str) -> String {
key.replace('/', "∕")
}
fn restore_forward_slashes(key: &str) -> String {
key.replace('∕', "/")
}
}
#[async_trait]
impl Blob for FileBlob {
async fn get(&self, key: &str) -> Result<Option<SegmentedBytes>, ExternalError> {
let file_path = self.blob_path(&FileBlob::replace_forward_slashes(key));
let mut file = match File::open(file_path).await {
Ok(file) => file,
Err(err) if err.kind() == ErrorKind::NotFound => return Ok(None),
Err(err) => return Err(err.into()),
};
let mut buf = Vec::new();
file.read_to_end(&mut buf).await?;
Ok(Some(SegmentedBytes::from(buf)))
}
async fn list_keys_and_metadata(
&self,
key_prefix: &str,
f: &mut (dyn FnMut(BlobMetadata) + Send + Sync),
) -> Result<(), ExternalError> {
let base_dir = self.base_dir.canonicalize()?;
let mut entries = fs::read_dir(&base_dir).await?;
while let Some(entry) = entries.next_entry().await? {
let path = entry.path().canonicalize()?;
if !path.is_file() {
// Ignore '.' and '..' directory entries if they come up.
if path == base_dir {
continue;
} else if let Some(parent) = base_dir.parent() {
if path == parent {
continue;
}
} else {
return Err(ExternalError::from(anyhow!(
"unexpectedly found directory while iterating through FileBlob: {}",
path.display()
)));
}
}
// "Real" blobs don't have extensions. We want to exclude "expected" extensions
// like soft-deleted blobs or in-progress writes, and complain otherwise.
match path.extension().and_then(|os| os.to_str()) {
Some("bak" | "tmp") => continue,
Some(other) => Err(ExternalError::from(anyhow!(
"Found blob with unexpected suffix: {other}"
)))?,
None => {}
}
// The file name is guaranteed to be non-None iff the path is a
// normal file.
let file_name = path.file_name();
if let Some(name) = file_name {
let name = name.to_str();
if let Some(name) = name {
if !name.starts_with(key_prefix) {
continue;
}
f(BlobMetadata {
key: &FileBlob::restore_forward_slashes(name),
size_in_bytes: entry.metadata().await?.len(),
});
}
}
}
Ok(())
}
async fn set(&self, key: &str, value: Bytes) -> Result<(), ExternalError> {
let file_path = self.blob_path(&FileBlob::replace_forward_slashes(key));
// To implement atomic set, write to a temp file and rename it into
// place.
let mut tmp_name = file_path.clone();
debug_assert_eq!(tmp_name.extension(), None);
tmp_name.set_extension("tmp");
// NB: Don't use create_new(true) for this so that if we have a partial
// one from a previous crash, it will just get overwritten (which is
// safe).
let mut file = File::create(&tmp_name).await?;
file.write_all(&value[..]).await?;
fail_point!("fileblob_set_sync", |_| {
Err(ExternalError::from(anyhow!(
"FileBlob::set_sync fail point reached for file {:?}",
file_path
)))
});
// fsync the file, so its contents are visible
file.sync_all().await?;
let parent_dir = File::open(&self.base_dir).await?;
// fsync the directory so it can guaranteed see the tmp file
parent_dir.sync_all().await?;
// atomically rename our file
fs::rename(tmp_name, &file_path).await?;
// fsync the directory once again to guarantee it can see the renamed
// file
parent_dir.sync_all().await?;
Ok(())
}
async fn delete(&self, key: &str) -> Result<Option<usize>, ExternalError> {
let file_path = self.blob_path(&FileBlob::replace_forward_slashes(key));
// TODO: strict correctness requires that we fsync the parent directory
// as well after file removal.
fail_point!("fileblob_delete_before", |_| {
Err(ExternalError::from(anyhow!(
"FileBlob::delete_before fail point reached for file {:?}",
file_path
)))
});
// There is a race condition here between metadata and remove_file where
// we won't return the correct length of the deleted file if it changes
// between the two calls. Luckily 1. we only every write to a given key
// once and it never changes and 2. this is only used for metrics
// anyway.
let size_bytes = match fs::metadata(&file_path).await {
Ok(x) => x.len(),
Err(err) => {
// delete is documented to succeed if the key doesn't exist.
if err.kind() == ErrorKind::NotFound {
return Ok(None);
}
return Err(err.into());
}
};
let result = if self.tombstone {
// Instead of removing the file, rename it!
let mut tombstone_name = file_path.clone();
assert_eq!(tombstone_name.extension(), None);
tombstone_name.set_extension("bak");
fs::rename(&file_path, &tombstone_name).await
} else {
fs::remove_file(&file_path).await
};
if let Err(err) = result {
// delete is documented to succeed if the key doesn't exist.
if err.kind() == ErrorKind::NotFound {
return Ok(None);
}
return Err(err.into());
};
fail_point!("fileblob_delete_after", |_| {
Err(ExternalError::from(anyhow!(
"FileBlob::delete_after fail point reached for file {:?}",
file_path
)))
});
Ok(Some(usize::cast_from(size_bytes)))
}
async fn restore(&self, key: &str) -> Result<(), ExternalError> {
let file_path = self.blob_path(&FileBlob::replace_forward_slashes(key));
if fs::try_exists(&file_path).await? {
return Ok(());
}
let mut tombstone_name = file_path.clone();
assert_eq!(tombstone_name.extension(), None);
tombstone_name.set_extension("bak");
match fs::rename(&tombstone_name, &file_path).await {
Err(e) if e.kind() == ErrorKind::NotFound => {
// TODO: should we treat not-found as determinate elsewhere also?
Err(Determinate::new(anyhow!("no tombstone or file for key: {key}")).into())
}
other => Ok(other?),
}
}
}
#[cfg(test)]
mod tests {
use crate::location::tests::blob_impl_test;
use super::*;
#[mz_ore::test(tokio::test)]
#[cfg_attr(miri, ignore)] // error: unsupported operation: integer-to-pointer casts and `ptr::from_exposed_addr` are not supported with `-Zmiri-strict-provenance`
async fn file_blob() -> Result<(), ExternalError> {
let temp_dir = tempfile::tempdir().map_err(Error::from)?;
blob_impl_test(move |path| {
let instance_dir = temp_dir.path().join(path);
FileBlob::open(instance_dir.into())
})
.await?;
let temp_dir = tempfile::tempdir().map_err(Error::from)?;
blob_impl_test(move |path| {
let instance_dir = temp_dir.path().join(path);
let mut cfg: FileBlobConfig = instance_dir.into();
cfg.tombstone = true;
FileBlob::open(cfg)
})
.await?;
Ok(())
}
}