1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
//! A durable, truncatable log of versions of [State].
#[cfg(debug_assertions)]
use std::collections::BTreeSet;
use std::fmt::Debug;
use std::ops::ControlFlow::{Break, Continue};
use std::sync::Arc;
use std::time::SystemTime;
use bytes::Bytes;
use differential_dataflow::difference::Semigroup;
use differential_dataflow::lattice::Lattice;
use differential_dataflow::trace::Description;
use mz_ore::cast::CastFrom;
use mz_persist::location::{
Blob, CaSResult, Consensus, Indeterminate, SeqNo, VersionedData, SCAN_ALL,
};
use mz_persist::retry::Retry;
use mz_persist_types::{Codec, Codec64};
use mz_proto::RustType;
use prost::Message;
use timely::progress::Timestamp;
use tracing::{debug, debug_span, trace, warn, Instrument};
use crate::error::{CodecMismatch, CodecMismatchT};
use crate::internal::encoding::{Rollup, UntypedState};
use crate::internal::machine::{retry_determinate, retry_external};
use crate::internal::metrics::ShardMetrics;
use crate::internal::paths::{BlobKey, PartialBlobKey, PartialRollupKey, RollupId};
#[cfg(debug_assertions)]
use crate::internal::state::HollowBatch;
use crate::internal::state::{
BatchPart, HollowBlobRef, HollowRollup, NoOpStateTransition, RunPart, State, TypedState,
};
use crate::internal::state_diff::{StateDiff, StateFieldValDiff};
use crate::{Metrics, PersistConfig, ShardId};
/// A durable, truncatable log of versions of [State].
///
/// As persist metadata changes over time, we make its versions (each identified
/// by a [SeqNo]) durable in two ways:
/// - `rollups`: Periodic copies of the entirety of [State], written to [Blob].
/// - `diffs`: Incremental [StateDiff]s, written to [Consensus].
///
/// The following invariants are maintained at all times:
/// - A shard is initialized iff there is at least one version of it in
/// Consensus.
/// - The first version of state is written to `SeqNo(1)`. Each successive state
/// version is assigned its predecessor's SeqNo +1.
/// - `current`: The latest version of state. By definition, the largest SeqNo
/// present in Consensus.
/// - As state changes over time, we keep a range of consecutive versions
/// available. These are periodically `truncated` to prune old versions that
/// are no longer necessary.
/// - `earliest`: The first version of state that it is possible to reconstruct.
/// - Invariant: `earliest <= current.seqno_since()` (we don't garbage collect
/// versions still being used by some reader).
/// - Invariant: `earliest` is always the smallest Seqno present in Consensus.
/// - This doesn't have to be true, but we select to enforce it.
/// - Because the data stored at that smallest Seqno is an incremental diff,
/// to make this invariant work, there needs to be a rollup at either
/// `earliest-1` or `earliest`. We choose `earliest` because it seems to
/// make the code easier to reason about in practice.
/// - A consequence of the above is when we garbage collect old versions of
/// state, we're only free to truncate ones that are `<` the latest rollup
/// that is `<= current.seqno_since`.
/// - `live diffs`: The set of SeqNos present in Consensus at any given time.
/// - `live states`: The range of state versions that it is possible to
/// reconstruct: `[earliest,current]`.
/// - Because of earliest and current invariants above, the range of `live
/// diffs` and `live states` are the same.
/// - The set of known rollups are tracked in the shard state itself.
/// - For efficiency of common operations, the most recent rollup's Blob key
/// is always denormalized in each StateDiff written to Consensus. (As
/// described above, there is always a rollup at earliest, so we're
/// guaranteed that there is always at least one live rollup.)
/// - Invariant: The rollups in `current` exist in Blob.
/// - A consequence is that, if a rollup in a state you believe is `current`
/// doesn't exist, it's a guarantee that `current` has changed (or it's a
/// bug).
/// - Any rollup at a version `< earliest-1` is useless (we've lost the
/// incremental diffs between it and the live states). GC is tasked with
/// deleting these rollups from Blob before truncating diffs from Consensus.
/// Thus, any rollup at a seqno < earliest can be considered "leaked" and
/// deleted by the leaked blob detector.
/// - Note that this means, while `current`'s rollups exist, it will be common
/// for other live states to reference rollups that no longer exist.
#[derive(Debug)]
pub struct StateVersions {
pub(crate) cfg: PersistConfig,
pub(crate) consensus: Arc<dyn Consensus>,
pub(crate) blob: Arc<dyn Blob>,
pub(crate) metrics: Arc<Metrics>,
}
#[derive(Debug, Clone)]
pub struct RecentLiveDiffs(pub Vec<VersionedData>);
#[derive(Debug, Clone)]
pub struct AllLiveDiffs(pub Vec<VersionedData>);
#[derive(Debug, Clone)]
pub struct EncodedRollup {
pub(crate) shard_id: ShardId,
pub(crate) seqno: SeqNo,
pub(crate) key: PartialRollupKey,
pub(crate) _desc: Description<SeqNo>,
buf: Bytes,
}
impl EncodedRollup {
pub fn to_hollow(&self) -> HollowRollup {
HollowRollup {
key: self.key.clone(),
encoded_size_bytes: Some(self.buf.len()),
}
}
}
impl StateVersions {
pub fn new(
cfg: PersistConfig,
consensus: Arc<dyn Consensus>,
blob: Arc<dyn Blob>,
metrics: Arc<Metrics>,
) -> Self {
StateVersions {
cfg,
consensus,
blob,
metrics,
}
}
/// Fetches the `current` state of the requested shard, or creates it if
/// uninitialized.
pub async fn maybe_init_shard<K, V, T, D>(
&self,
shard_metrics: &ShardMetrics,
) -> Result<TypedState<K, V, T, D>, Box<CodecMismatch>>
where
K: Debug + Codec,
V: Debug + Codec,
T: Timestamp + Lattice + Codec64,
D: Semigroup + Codec64,
{
let shard_id = shard_metrics.shard_id;
// The common case is that the shard is initialized, so try that first
let recent_live_diffs = self.fetch_recent_live_diffs::<T>(&shard_id).await;
if !recent_live_diffs.0.is_empty() {
return self
.fetch_current_state(&shard_id, recent_live_diffs.0)
.await
.check_codecs(&shard_id);
}
// Shard is not initialized, try initializing it.
let (initial_state, initial_diff) = self.write_initial_rollup(shard_metrics).await;
let (cas_res, _diff) =
retry_external(&self.metrics.retries.external.maybe_init_cas, || async {
self.try_compare_and_set_current(
"maybe_init_shard",
shard_metrics,
None,
&initial_state,
&initial_diff,
)
.await
.map_err(|err| err.into())
})
.await;
match cas_res {
CaSResult::Committed => Ok(initial_state),
CaSResult::ExpectationMismatch => {
let recent_live_diffs = self.fetch_recent_live_diffs::<T>(&shard_id).await;
let state = self
.fetch_current_state(&shard_id, recent_live_diffs.0)
.await
.check_codecs(&shard_id);
// Clean up the rollup blob that we were trying to reference.
//
// SUBTLE: If we got an Indeterminate error in the CaS above,
// but it actually went through, then we'll "contend" with
// ourselves and get an expectation mismatch. Use the actual
// fetched state to determine if our rollup actually made it in
// and decide whether to delete based on that.
let (_, rollup) = initial_state.latest_rollup();
let should_delete_rollup = match state.as_ref() {
Ok(state) => !state
.collections
.rollups
.values()
.any(|x| &x.key == &rollup.key),
// If the codecs don't match, then we definitely didn't
// write the state.
Err(_codec_mismatch) => true,
};
if should_delete_rollup {
self.delete_rollup(&shard_id, &rollup.key).await;
}
state
}
}
}
/// Updates the state of a shard to a new `current` iff `expected` matches
/// `current`.
///
/// May be called on uninitialized shards.
pub async fn try_compare_and_set_current<K, V, T, D>(
&self,
cmd_name: &str,
shard_metrics: &ShardMetrics,
expected: Option<SeqNo>,
new_state: &TypedState<K, V, T, D>,
diff: &StateDiff<T>,
) -> Result<(CaSResult, VersionedData), Indeterminate>
where
K: Debug + Codec,
V: Debug + Codec,
T: Timestamp + Lattice + Codec64,
D: Semigroup + Codec64,
{
assert_eq!(shard_metrics.shard_id, new_state.shard_id);
let path = new_state.shard_id.to_string();
trace!(
"apply_unbatched_cmd {} attempting {}\n new_state={:?}",
cmd_name,
new_state.seqno(),
new_state
);
let new = self.metrics.codecs.state_diff.encode(|| {
let mut buf = Vec::new();
diff.encode(&mut buf);
VersionedData {
seqno: new_state.seqno(),
data: Bytes::from(buf),
}
});
assert_eq!(new.seqno, diff.seqno_to);
let payload_len = new.data.len();
let cas_res = retry_determinate(
&self.metrics.retries.determinate.apply_unbatched_cmd_cas,
|| async {
self.consensus
.compare_and_set(&path, expected, new.clone())
.await
},
)
.instrument(debug_span!("apply_unbatched_cmd::cas", payload_len))
.await
.map_err(|err| {
debug!("apply_unbatched_cmd {} errored: {}", cmd_name, err);
err
})?;
match cas_res {
CaSResult::Committed => {
trace!(
"apply_unbatched_cmd {} succeeded {}\n new_state={:?}",
cmd_name,
new_state.seqno(),
new_state
);
shard_metrics.set_since(new_state.since());
shard_metrics.set_upper(new_state.upper());
shard_metrics.seqnos_since_last_rollup.set(
new_state
.seqno
.0
.saturating_sub(new_state.latest_rollup().0 .0),
);
shard_metrics
.spine_batch_count
.set(u64::cast_from(new_state.spine_batch_count()));
let size_metrics = new_state.size_metrics();
shard_metrics
.schema_registry_version_count
.set(u64::cast_from(new_state.collections.schemas.len()));
shard_metrics
.hollow_batch_count
.set(u64::cast_from(size_metrics.hollow_batch_count));
shard_metrics
.batch_part_count
.set(u64::cast_from(size_metrics.batch_part_count));
shard_metrics
.rewrite_part_count
.set(u64::cast_from(size_metrics.rewrite_part_count));
shard_metrics
.update_count
.set(u64::cast_from(size_metrics.num_updates));
shard_metrics
.rollup_count
.set(u64::cast_from(size_metrics.state_rollup_count));
shard_metrics
.largest_batch_size
.set(u64::cast_from(size_metrics.largest_batch_bytes));
shard_metrics
.usage_current_state_batches_bytes
.set(u64::cast_from(size_metrics.state_batches_bytes));
shard_metrics
.usage_current_state_rollups_bytes
.set(u64::cast_from(size_metrics.state_rollups_bytes));
shard_metrics
.seqnos_held
.set(u64::cast_from(new_state.seqnos_held()));
shard_metrics
.encoded_diff_size
.inc_by(u64::cast_from(payload_len));
shard_metrics
.live_writers
.set(u64::cast_from(new_state.collections.writers.len()));
shard_metrics
.rewrite_part_count
.set(u64::cast_from(size_metrics.rewrite_part_count));
shard_metrics
.inline_part_count
.set(u64::cast_from(size_metrics.inline_part_count));
shard_metrics
.inline_part_bytes
.set(u64::cast_from(size_metrics.inline_part_bytes));
let spine_metrics = new_state.collections.trace.spine_metrics();
shard_metrics
.compact_batches
.set(spine_metrics.compact_batches);
shard_metrics
.compacting_batches
.set(spine_metrics.compacting_batches);
shard_metrics
.noncompact_batches
.set(spine_metrics.noncompact_batches);
let batch_parts_by_version = new_state
.collections
.trace
.batches()
.flat_map(|x| x.parts.iter())
.flat_map(|part| {
let key = match part {
RunPart::Many(x) => Some(&x.key),
RunPart::Single(BatchPart::Hollow(x)) => Some(&x.key),
// TODO: Would be nice to include these too, but we lose the info atm.
RunPart::Single(BatchPart::Inline { .. }) => None,
}?;
// Carefully avoid any String allocs by splitting.
let (writer_key, _) = key.0.split_once('/')?;
match &writer_key[..1] {
"w" => Some(("old", part.encoded_size_bytes())),
"n" => Some((&writer_key[1..], part.encoded_size_bytes())),
_ => None,
}
});
shard_metrics.set_batch_part_versions(batch_parts_by_version);
Ok((CaSResult::Committed, new))
}
CaSResult::ExpectationMismatch => {
debug!(
"apply_unbatched_cmd {} {} lost the CaS race, retrying: {:?}",
new_state.shard_id(),
cmd_name,
expected,
);
Ok((CaSResult::ExpectationMismatch, new))
}
}
}
/// Fetches the `current` state of the requested shard.
///
/// Uses the provided hint (live_diffs), which is a possibly outdated
/// copy of all or recent live diffs, to avoid fetches where possible.
///
/// Panics if called on an uninitialized shard.
pub async fn fetch_current_state<T>(
&self,
shard_id: &ShardId,
mut live_diffs: Vec<VersionedData>,
) -> UntypedState<T>
where
T: Timestamp + Lattice + Codec64,
{
let retry = self
.metrics
.retries
.fetch_latest_state
.stream(Retry::persist_defaults(SystemTime::now()).into_retry_stream());
loop {
let latest_diff = live_diffs
.last()
.expect("initialized shard should have at least one diff");
let latest_diff = self
.metrics
.codecs
.state_diff
// Note: `latest_diff.data` is a `Bytes`, so cloning just increments a ref count
.decode(|| {
StateDiff::<T>::decode(&self.cfg.build_version, latest_diff.data.clone())
});
let mut state = match self
.fetch_rollup_at_key(shard_id, &latest_diff.latest_rollup_key)
.await
{
Some(x) => x,
None => {
// The rollup that this diff referenced is gone, so the diff
// must be out of date. Try again. Intentionally don't sleep on retry.
retry.retries.inc();
let earliest_before_refetch = live_diffs
.first()
.expect("initialized shard should have at least one diff")
.seqno;
live_diffs = self.fetch_recent_live_diffs::<T>(shard_id).await.0;
// We should only hit the race condition that leads to a
// refetch if the set of live diffs changed out from under
// us.
//
// TODO: Make this an assert once we're 100% sure the above
// is always true.
let earliest_after_refetch = live_diffs
.first()
.expect("initialized shard should have at least one diff")
.seqno;
if earliest_before_refetch >= earliest_after_refetch {
warn!(concat!(
"fetch_current_state refetch expects earliest live diff to advance: {} vs {}. ",
"In dev and testing, this happens when persist's Blob (files in mzdata) ",
"is deleted out from under it or when two processes are talking to ",
"different Blobs (e.g. docker containers without it shared)."),
earliest_before_refetch, earliest_after_refetch)
}
continue;
}
};
state.apply_encoded_diffs(&self.cfg, &self.metrics, &live_diffs);
return state;
}
}
/// Returns an iterator over all live states for the requested shard.
///
/// Returns None if called on an uninitialized shard.
pub async fn fetch_all_live_states<T>(
&self,
shard_id: ShardId,
) -> Option<UntypedStateVersionsIter<T>>
where
T: Timestamp + Lattice + Codec64,
{
let retry = self
.metrics
.retries
.fetch_live_states
.stream(Retry::persist_defaults(SystemTime::now()).into_retry_stream());
let mut all_live_diffs = self.fetch_all_live_diffs(&shard_id).await;
loop {
let earliest_live_diff = match all_live_diffs.0.first() {
Some(x) => x,
None => return None,
};
let state = match self
.fetch_rollup_at_seqno(
&shard_id,
all_live_diffs.0.clone(),
earliest_live_diff.seqno,
)
.await
{
Some(x) => x,
None => {
// We maintain an invariant that a rollup always exists for
// the earliest live diff. Since we didn't find out, that
// can only mean that the live_diffs we just fetched are
// obsolete (there's a race condition with gc). This should
// be rare in practice, so inc a counter and try again.
// Intentionally don't sleep on retry.
retry.retries.inc();
let earliest_before_refetch = earliest_live_diff.seqno;
all_live_diffs = self.fetch_all_live_diffs(&shard_id).await;
// We should only hit the race condition that leads to a
// refetch if the set of live diffs changed out from under
// us.
//
// TODO: Make this an assert once we're 100% sure the above
// is always true.
let earliest_after_refetch = all_live_diffs
.0
.first()
.expect("initialized shard should have at least one diff")
.seqno;
if earliest_before_refetch >= earliest_after_refetch {
warn!(concat!(
"fetch_all_live_states refetch expects earliest live diff to advance: {} vs {}. ",
"In dev and testing, this happens when persist's Blob (files in mzdata) ",
"is deleted out from under it or when two processes are talking to ",
"different Blobs (e.g. docker containers without it shared)."),
earliest_before_refetch, earliest_after_refetch)
}
continue;
}
};
assert_eq!(earliest_live_diff.seqno, state.seqno());
return Some(UntypedStateVersionsIter {
shard_id,
cfg: self.cfg.clone(),
metrics: Arc::clone(&self.metrics),
state,
diffs: all_live_diffs.0,
});
}
}
/// Fetches all live_diffs for a shard. Intended only for when a caller needs to reconstruct
/// _all_ states still referenced by Consensus. Prefer [Self::fetch_recent_live_diffs] when
/// the caller simply needs to fetch the latest state.
///
/// Returns an empty Vec iff called on an uninitialized shard.
pub async fn fetch_all_live_diffs(&self, shard_id: &ShardId) -> AllLiveDiffs {
let path = shard_id.to_string();
let diffs = retry_external(&self.metrics.retries.external.fetch_state_scan, || async {
self.consensus.scan(&path, SeqNo::minimum(), SCAN_ALL).await
})
.instrument(debug_span!("fetch_state::scan"))
.await;
AllLiveDiffs(diffs)
}
/// Fetches recent live_diffs for a shard. Intended for when a caller needs to fetch
/// the latest state in Consensus.
///
/// "Recent" is defined as either:
/// * All of the diffs known in Consensus
/// * All of the diffs in Consensus after the latest rollup
pub async fn fetch_recent_live_diffs<T>(&self, shard_id: &ShardId) -> RecentLiveDiffs
where
T: Timestamp + Lattice + Codec64,
{
let path = shard_id.to_string();
let scan_limit = self.cfg.dynamic.state_versions_recent_live_diffs_limit();
let oldest_diffs =
retry_external(&self.metrics.retries.external.fetch_state_scan, || async {
self.consensus
.scan(&path, SeqNo::minimum(), scan_limit)
.await
})
.instrument(debug_span!("fetch_state::scan"))
.await;
// fast-path: we found all known diffs in a single page of our scan. we expect almost all
// calls to go down this path, unless a reader has a very long seqno-hold on the shard.
if oldest_diffs.len() < scan_limit {
self.metrics.state.fetch_recent_live_diffs_fast_path.inc();
return RecentLiveDiffs(oldest_diffs);
}
// slow-path: we could be arbitrarily far behind the head of Consensus (either intentionally
// due to a long seqno-hold from a reader, or unintentionally from a bug that's preventing
// a seqno-hold from advancing). rather than scanning a potentially unbounded number of old
// states in Consensus, we jump to the latest state, determine the seqno of the most recent
// rollup, and then fetch all the diffs from that point onward.
//
// this approach requires more network calls, but it should smooth out our access pattern
// and use only bounded calls to Consensus. additionally, if `limit` is adequately tuned,
// this path will only be invoked when there's an excess number of states in Consensus and
// it might be slower to do a single long scan over unneeded rows.
let head = retry_external(&self.metrics.retries.external.fetch_state_scan, || async {
self.consensus.head(&path).await
})
.instrument(debug_span!("fetch_state::slow_path::head"))
.await
.expect("initialized shard should have at least 1 diff");
let latest_diff = self
.metrics
.codecs
.state_diff
.decode(|| StateDiff::<T>::decode(&self.cfg.build_version, head.data));
match BlobKey::parse_ids(&latest_diff.latest_rollup_key.complete(shard_id)) {
Ok((_shard_id, PartialBlobKey::Rollup(seqno, _rollup))) => {
self.metrics.state.fetch_recent_live_diffs_slow_path.inc();
let diffs =
retry_external(&self.metrics.retries.external.fetch_state_scan, || async {
// (pedantry) this call is technically unbounded, but something very strange
// would have had to happen to have accumulated so many states between our
// call to `head` and this invocation for it to become problematic
self.consensus.scan(&path, seqno, SCAN_ALL).await
})
.instrument(debug_span!("fetch_state::slow_path::scan"))
.await;
RecentLiveDiffs(diffs)
}
Ok(_) => panic!(
"invalid state diff rollup key: {}",
latest_diff.latest_rollup_key
),
Err(err) => panic!("unparseable state diff rollup key: {}", err),
}
}
/// Fetches all live diffs greater than the given SeqNo.
///
/// TODO: Apply a limit to this scan. This could additionally be used as an internal
/// call within `fetch_recent_live_diffs`.
pub async fn fetch_all_live_diffs_gt_seqno<K, V, T, D>(
&self,
shard_id: &ShardId,
seqno: SeqNo,
) -> Vec<VersionedData> {
let path = shard_id.to_string();
retry_external(&self.metrics.retries.external.fetch_state_scan, || async {
self.consensus.scan(&path, seqno.next(), SCAN_ALL).await
})
.instrument(debug_span!("fetch_state::scan"))
.await
}
/// Truncates any diffs in consensus less than the given seqno.
pub async fn truncate_diffs(&self, shard_id: &ShardId, seqno: SeqNo) {
let path = shard_id.to_string();
let _deleted_count = retry_external(&self.metrics.retries.external.gc_truncate, || async {
self.consensus.truncate(&path, seqno).await
})
.instrument(debug_span!("gc::truncate"))
.await;
}
// Writes a self-referential rollup to blob storage and returns the diff
// that should be compare_and_set into consensus to finish initializing the
// shard.
async fn write_initial_rollup<K, V, T, D>(
&self,
shard_metrics: &ShardMetrics,
) -> (TypedState<K, V, T, D>, StateDiff<T>)
where
K: Debug + Codec,
V: Debug + Codec,
T: Timestamp + Lattice + Codec64,
D: Semigroup + Codec64,
{
let empty_state = TypedState::new(
self.cfg.build_version.clone(),
shard_metrics.shard_id,
self.cfg.hostname.clone(),
(self.cfg.now)(),
);
let rollup_seqno = empty_state.seqno.next();
let rollup = HollowRollup {
key: PartialRollupKey::new(rollup_seqno, &RollupId::new()),
// Chicken-and-egg problem here. We don't know the size of the
// rollup until we encode it, but it includes a reference back to
// itself.
encoded_size_bytes: None,
};
let (applied, initial_state) = match empty_state
.clone_apply(&self.cfg, &mut |_, _, state| {
state.add_rollup((rollup_seqno, &rollup))
}) {
Continue(x) => x,
Break(NoOpStateTransition(_)) => {
panic!("initial state transition should not be a no-op")
}
};
assert!(
applied,
"add_and_remove_rollups should apply to the empty state"
);
let rollup = self.encode_rollup_blob(
shard_metrics,
initial_state.clone_for_rollup(),
vec![],
rollup.key,
);
let () = self.write_rollup_blob(&rollup).await;
assert_eq!(initial_state.seqno, rollup.seqno);
let diff = StateDiff::from_diff(&empty_state.state, &initial_state.state);
(initial_state, diff)
}
pub async fn write_rollup_for_state<K, V, T, D>(
&self,
shard_metrics: &ShardMetrics,
state: TypedState<K, V, T, D>,
rollup_id: &RollupId,
) -> Option<EncodedRollup>
where
K: Debug + Codec,
V: Debug + Codec,
T: Timestamp + Lattice + Codec64,
D: Semigroup + Codec64,
{
let (latest_rollup_seqno, _rollup) = state.latest_rollup();
let seqno = state.seqno();
// TODO: maintain the diffs since the latest rollup in-memory rather than
// needing an additional API call here. This would reduce Consensus load
// / avoid races with Consensus truncation, but is trickier to write.
let diffs: Vec<_> = self
.fetch_all_live_diffs_gt_seqno::<K, V, T, D>(&state.shard_id, *latest_rollup_seqno)
.await;
match diffs.first() {
None => {
// early-out because these are no diffs past our latest rollup.
//
// this should only occur in the initial state, but we can write a more
// general assertion: if no live diffs exist past this state's latest
// known rollup, then that rollup must be for the latest known state.
self.metrics.state.rollup_write_noop_latest.inc();
assert_eq!(seqno, *latest_rollup_seqno);
return None;
}
Some(first) => {
// early-out if it is no longer possible to inline all the diffs from
// the last known rollup to the current state. some or all of the diffs
// have already been truncated by another process.
//
// this can happen if one process gets told to write a rollup, the
// maintenance task falls arbitrarily behind, and another process writes
// a new rollup / GCs and truncates past the first process's rollup.
self.metrics.state.rollup_write_noop_truncated.inc();
if first.seqno != latest_rollup_seqno.next() {
assert!(
first.seqno > latest_rollup_seqno.next(),
"diff: {}, rollup: {}",
first.seqno,
latest_rollup_seqno,
);
return None;
}
}
}
// we may have fetched more diffs than we need: trim anything beyond the state's seqno
let diffs: Vec<_> = diffs.into_iter().filter(|x| x.seqno <= seqno).collect();
// verify that we've done all the filtering correctly and that our
// diffs have seqnos bounded by (last_rollup, current_state]
assert_eq!(
diffs.first().map(|x| x.seqno),
Some(latest_rollup_seqno.next())
);
assert_eq!(diffs.last().map(|x| x.seqno), Some(state.seqno));
let key = PartialRollupKey::new(state.seqno, rollup_id);
let rollup = self.encode_rollup_blob(shard_metrics, state, diffs, key);
let () = self.write_rollup_blob(&rollup).await;
self.metrics.state.rollup_write_success.inc();
Some(rollup)
}
/// Encodes the given state and diffs as a rollup to be written to the specified key.
///
/// The diffs must span the seqno range `(state.last_rollup().seqno, state.seqno]`.
pub fn encode_rollup_blob<K, V, T, D>(
&self,
shard_metrics: &ShardMetrics,
state: TypedState<K, V, T, D>,
diffs: Vec<VersionedData>,
key: PartialRollupKey,
) -> EncodedRollup
where
K: Debug + Codec,
V: Debug + Codec,
T: Timestamp + Lattice + Codec64,
D: Semigroup + Codec64,
{
let shard_id = state.shard_id;
let rollup_seqno = state.seqno;
let rollup = Rollup::from(state.into(), diffs);
let desc = rollup.diffs.as_ref().expect("inlined diffs").description();
let buf = self.metrics.codecs.state.encode(|| {
let mut buf = Vec::new();
rollup
.into_proto()
.encode(&mut buf)
.expect("no required fields means no initialization errors");
Bytes::from(buf)
});
shard_metrics
.latest_rollup_size
.set(u64::cast_from(buf.len()));
EncodedRollup {
shard_id,
seqno: rollup_seqno,
key,
buf,
_desc: desc,
}
}
/// Writes the given state rollup out to blob.
pub async fn write_rollup_blob(&self, rollup: &EncodedRollup) {
let payload_len = rollup.buf.len();
retry_external(&self.metrics.retries.external.rollup_set, || async {
self.blob
.set(
&rollup.key.complete(&rollup.shard_id),
Bytes::clone(&rollup.buf),
)
.await
})
.instrument(debug_span!("rollup::set", payload_len))
.await;
}
/// Fetches a rollup for the given SeqNo, if it exists.
///
/// Uses the provided hint, which is a possibly outdated copy of all
/// or recent live diffs, to avoid fetches where possible.
///
/// Panics if called on an uninitialized shard.
async fn fetch_rollup_at_seqno<T>(
&self,
shard_id: &ShardId,
live_diffs: Vec<VersionedData>,
seqno: SeqNo,
) -> Option<UntypedState<T>>
where
T: Timestamp + Lattice + Codec64,
{
let rollup_key_for_migration = live_diffs.iter().find_map(|x| {
let diff = self
.metrics
.codecs
.state_diff
// Note: `x.data` is a `Bytes`, so cloning just increments a ref count
.decode(|| StateDiff::<T>::decode(&self.cfg.build_version, x.data.clone()));
diff.rollups
.iter()
.find(|x| x.key == seqno)
.map(|x| match &x.val {
StateFieldValDiff::Insert(x) => x.clone(),
StateFieldValDiff::Update(_, x) => x.clone(),
StateFieldValDiff::Delete(x) => x.clone(),
})
});
let state = self.fetch_current_state::<T>(shard_id, live_diffs).await;
if let Some(rollup) = state.rollups().get(&seqno) {
return self.fetch_rollup_at_key(shard_id, &rollup.key).await;
}
// MIGRATION: We maintain an invariant that the _current state_ contains
// a rollup for the _earliest live diff_ in consensus (and that the
// referenced rollup exists). At one point, we fixed a bug that could
// lead to that invariant being violated.
//
// If the earliest live diff is X and we receive a gc req for X+Y to
// X+Y+Z (this can happen e.g. if some cmd ignores an earlier req for X
// to X+Y, or if they're processing concurrently and the X to X+Y req
// loses the race), then the buggy version of gc would delete any
// rollups strictly less than old_seqno_since (X+Y in this example). But
// our invariant is that the rollup exists for the earliest live diff,
// in this case X. So if the first call to gc was interrupted after this
// but before truncate (when all the blob deletes happen), later calls
// to gc would attempt to call `fetch_live_states` and end up infinitely
// in its loop.
//
// The fix was to base which rollups are deleteable on the earliest live
// diff, not old_seqno_since.
//
// Sadly, some envs in prod now violate this invariant. So, even with
// the fix, existing shards will never successfully run gc. We add a
// temporary migration to fix them in `fetch_rollup_at_seqno`. This
// method normally looks in the latest version of state for the
// specifically requested seqno. In the invariant violation case, some
// version of state in the range `[earliest, current]` has a rollup for
// earliest, but current doesn't. So, for the migration, if
// fetch_rollup_at_seqno doesn't find a rollup in current, then we fall
// back to sniffing one out of raw diffs. If this success, we increment
// a counter and log, so we can track how often this migration is
// bailing us out. After the next deploy, this should initially start at
// > 0 and then settle down to 0. After the next prod envs wipe, we can
// remove the migration.
let rollup = rollup_key_for_migration.expect("someone should have a key for this rollup");
tracing::info!("only found rollup for {} {} via migration", shard_id, seqno);
self.metrics.state.rollup_at_seqno_migration.inc();
self.fetch_rollup_at_key(shard_id, &rollup.key).await
}
/// Fetches the rollup at the given key, if it exists.
async fn fetch_rollup_at_key<T>(
&self,
shard_id: &ShardId,
rollup_key: &PartialRollupKey,
) -> Option<UntypedState<T>>
where
T: Timestamp + Lattice + Codec64,
{
retry_external(&self.metrics.retries.external.rollup_get, || async {
self.blob.get(&rollup_key.complete(shard_id)).await
})
.instrument(debug_span!("rollup::get"))
.await
.map(|buf| {
self.metrics
.codecs
.state
.decode(|| UntypedState::decode(&self.cfg.build_version, buf))
})
}
/// Deletes the rollup at the given key, if it exists.
pub async fn delete_rollup(&self, shard_id: &ShardId, key: &PartialRollupKey) {
let _ = retry_external(&self.metrics.retries.external.rollup_delete, || async {
self.blob.delete(&key.complete(shard_id)).await
})
.await
.instrument(debug_span!("rollup::delete"));
}
}
pub struct UntypedStateVersionsIter<T> {
shard_id: ShardId,
cfg: PersistConfig,
metrics: Arc<Metrics>,
state: UntypedState<T>,
diffs: Vec<VersionedData>,
}
impl<T: Timestamp + Lattice + Codec64> UntypedStateVersionsIter<T> {
pub(crate) fn check_ts_codec(self) -> Result<StateVersionsIter<T>, CodecMismatchT> {
let key_codec = self.state.key_codec.clone();
let val_codec = self.state.val_codec.clone();
let diff_codec = self.state.diff_codec.clone();
let state = self.state.check_ts_codec(&self.shard_id)?;
Ok(StateVersionsIter::new(
self.cfg,
self.metrics,
state,
self.diffs,
key_codec,
val_codec,
diff_codec,
))
}
}
/// An iterator over consecutive versions of [State].
pub struct StateVersionsIter<T> {
cfg: PersistConfig,
metrics: Arc<Metrics>,
state: State<T>,
diffs: Vec<VersionedData>,
key_codec: String,
val_codec: String,
diff_codec: String,
#[cfg(debug_assertions)]
validator: ReferencedBlobValidator<T>,
}
impl<T: Timestamp + Lattice + Codec64> StateVersionsIter<T> {
fn new(
cfg: PersistConfig,
metrics: Arc<Metrics>,
state: State<T>,
// diffs is stored reversed so we can efficiently pop off the Vec.
mut diffs: Vec<VersionedData>,
key_codec: String,
val_codec: String,
diff_codec: String,
) -> Self {
assert!(diffs.first().map_or(true, |x| x.seqno == state.seqno));
diffs.reverse();
StateVersionsIter {
cfg,
metrics,
state,
diffs,
key_codec,
val_codec,
diff_codec,
#[cfg(debug_assertions)]
validator: ReferencedBlobValidator::default(),
}
}
pub fn len(&self) -> usize {
self.diffs.len()
}
/// Advances first to some starting state (in practice, usually the first
/// live state), and then through each successive state, for as many diffs
/// as this iterator was initialized with.
///
/// The `inspect_diff_fn` callback can be used to inspect diffs directly as
/// they are applied. The first call to `next` returns a
/// [InspectDiff::FromInitial] representing a diff from the initial state.
pub fn next<F: for<'a> FnMut(InspectDiff<'a, T>)>(
&mut self,
mut inspect_diff_fn: F,
) -> Option<&State<T>> {
let diff = match self.diffs.pop() {
Some(x) => x,
None => return None,
};
let data = diff.data.clone();
let diff = self
.metrics
.codecs
.state_diff
.decode(|| StateDiff::decode(&self.cfg.build_version, diff.data));
// A bit hacky, but the first diff in StateVersionsIter is always a
// no-op.
if diff.seqno_to == self.state.seqno {
let inspect = InspectDiff::FromInitial(&self.state);
#[cfg(debug_assertions)]
{
inspect
.referenced_blobs()
.for_each(|x| self.validator.add_inc_blob(x));
}
inspect_diff_fn(inspect);
} else {
let inspect = InspectDiff::Diff(&diff);
#[cfg(debug_assertions)]
{
inspect
.referenced_blobs()
.for_each(|x| self.validator.add_inc_blob(x));
}
inspect_diff_fn(inspect);
}
let diff_seqno_to = diff.seqno_to;
self.state
.apply_diffs(&self.metrics, std::iter::once((diff, data)));
assert_eq!(self.state.seqno, diff_seqno_to);
#[cfg(debug_assertions)]
{
self.validator.validate_against_state(&self.state);
}
Some(&self.state)
}
pub fn state(&self) -> &State<T> {
&self.state
}
pub fn into_rollup_proto_without_diffs(&self) -> impl serde::Serialize {
Rollup::from_state_without_diffs(
State {
applier_version: self.state.applier_version.clone(),
shard_id: self.state.shard_id.clone(),
seqno: self.state.seqno.clone(),
walltime_ms: self.state.walltime_ms.clone(),
hostname: self.state.hostname.clone(),
collections: self.state.collections.clone(),
},
self.key_codec.clone(),
self.val_codec.clone(),
T::codec_name(),
self.diff_codec.clone(),
)
.into_proto()
}
}
/// This represents a diff, either directly or, in the case of the FromInitial
/// variant, a diff from the initial state. (We could instead compute the diff
/// from the initial state and replace this with only a `StateDiff<T>`, but don't
/// for efficiency.)
#[derive(Debug)]
pub enum InspectDiff<'a, T> {
FromInitial(&'a State<T>),
Diff(&'a StateDiff<T>),
}
impl<T: Timestamp + Lattice + Codec64> InspectDiff<'_, T> {
/// A callback invoked for each blob added this state transition.
///
/// Blob removals, along with all other diffs, are ignored.
pub fn referenced_blobs(&self) -> impl Iterator<Item = HollowBlobRef<T>> {
let (state, diff) = match self {
InspectDiff::FromInitial(x) => (Some(x), None),
InspectDiff::Diff(x) => (None, Some(x)),
};
let state_blobs = state.into_iter().flat_map(|s| s.blobs());
let diff_blobs = diff.into_iter().flat_map(|d| d.blob_inserts());
state_blobs.chain(diff_blobs)
}
}
#[cfg(debug_assertions)]
struct ReferencedBlobValidator<T> {
// A copy of every batch and rollup referenced by some state iterator,
// computed by scanning the full copy of state at each seqno.
full_batches: BTreeSet<HollowBatch<T>>,
full_rollups: BTreeSet<HollowRollup>,
// A copy of every batch and rollup referenced by some state iterator,
// computed incrementally.
inc_batches: BTreeSet<HollowBatch<T>>,
inc_rollups: BTreeSet<HollowRollup>,
}
#[cfg(debug_assertions)]
impl<T> Default for ReferencedBlobValidator<T> {
fn default() -> Self {
Self {
full_batches: Default::default(),
full_rollups: Default::default(),
inc_batches: Default::default(),
inc_rollups: Default::default(),
}
}
}
#[cfg(debug_assertions)]
impl<T: Timestamp + Lattice + Codec64> ReferencedBlobValidator<T> {
fn add_inc_blob(&mut self, x: HollowBlobRef<'_, T>) {
match x {
HollowBlobRef::Batch(x) => assert!(
self.inc_batches.insert(x.clone()) || x.desc.lower() == x.desc.upper(),
"non-empty batches should only be appended once; duplicate: {x:?}"
),
HollowBlobRef::Rollup(x) => assert!(self.inc_rollups.insert(x.clone())),
}
}
fn validate_against_state(&mut self, x: &State<T>) {
use std::hash::{DefaultHasher, Hash, Hasher};
use mz_ore::collections::HashSet;
use timely::progress::Antichain;
use crate::internal::state::BatchPart;
x.blobs().for_each(|x| match x {
HollowBlobRef::Batch(x) => {
self.full_batches.insert(x.clone());
}
HollowBlobRef::Rollup(x) => {
self.full_rollups.insert(x.clone());
}
});
// Check that the sets of batches overall cover the same pTVC.
// Partial ordering means we can't just take the first and last batches; instead compute
// bounds using the lattice operations.
fn overall_desc<'a, T: Timestamp + Lattice>(
iter: impl Iterator<Item = &'a Description<T>>,
) -> (Antichain<T>, Antichain<T>) {
let mut lower = Antichain::new();
let mut upper = Antichain::from_elem(T::minimum());
for desc in iter {
lower.meet_assign(desc.lower());
upper.join_assign(desc.upper());
}
(lower, upper)
}
let (inc_lower, inc_upper) = overall_desc(self.inc_batches.iter().map(|a| &a.desc));
let (full_lower, full_upper) = overall_desc(self.full_batches.iter().map(|a| &a.desc));
assert_eq!(inc_lower, full_lower);
assert_eq!(inc_upper, full_upper);
fn part_unique<T: Hash>(x: &RunPart<T>) -> String {
match x {
RunPart::Single(BatchPart::Inline {
updates,
ts_rewrite,
..
}) => {
let mut h = DefaultHasher::new();
updates.hash(&mut h);
ts_rewrite.as_ref().map(|x| x.elements()).hash(&mut h);
h.finish().to_string()
}
other => other.printable_name().to_string(),
}
}
// Check that the overall set of parts contained in both representations is the same.
let inc_parts: HashSet<_> = self
.inc_batches
.iter()
.flat_map(|x| x.parts.iter())
.map(part_unique)
.collect();
let full_parts = self
.full_batches
.iter()
.flat_map(|x| x.parts.iter())
.map(part_unique)
.collect();
assert_eq!(inc_parts, full_parts);
// Check that both representations have the same rollups.
assert_eq!(self.inc_rollups, self.full_rollups);
}
}
#[cfg(test)]
mod tests {
use mz_dyncfg::ConfigUpdates;
use crate::tests::new_test_client;
use super::*;
/// Regression test for (part of) database-issues#5170, where an interrupted
/// `bin/environmentd --reset` resulted in panic in persist usage code.
#[mz_persist_proc::test(tokio::test)]
#[cfg_attr(miri, ignore)] // unsupported operation: returning ready events from epoll_wait is not yet implemented
async fn fetch_all_live_states_regression_uninitialized(dyncfgs: ConfigUpdates) {
let client = new_test_client(&dyncfgs).await;
let state_versions = StateVersions::new(
client.cfg.clone(),
Arc::clone(&client.consensus),
Arc::clone(&client.blob),
Arc::clone(&client.metrics),
);
assert!(state_versions
.fetch_all_live_states::<u64>(ShardId::new())
.await
.is_none());
}
}