1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
//! A timestamp oracle that wraps a `TimestampOracle` and batches calls
//! to it.
use std::sync::Arc;
use async_trait::async_trait;
use mz_ore::cast::CastFrom;
use tokio::sync::mpsc::UnboundedSender;
use tokio::sync::oneshot;
use crate::metrics::Metrics;
use crate::{TimestampOracle, WriteTimestamp};
/// A batching [`TimestampOracle`] backed by a [`TimestampOracle`]
///
/// This will only batch calls to `read_ts` because the rest of the system
/// already naturally does batching of write-related calls via the group commit
/// mechanism. Write-related calls are passed straight through to the backing
/// oracle.
///
/// For `read_ts` calls, we have to be careful to never cache results from the
/// backing oracle: for the timestamp to be linearized we can never return a
/// result as of an earlier moment, but batching them up is correct because this
/// can only make it so that we return later timestamps. Those later timestamps
/// still fall within the duration of the `read_ts` call and so are linearized.
pub struct BatchingTimestampOracle<T> {
inner: Arc<dyn TimestampOracle<T> + Send + Sync>,
command_tx: UnboundedSender<Command<T>>,
}
/// A command on the internal batching command stream.
enum Command<T> {
ReadTs(oneshot::Sender<T>),
}
impl<T> std::fmt::Debug for BatchingTimestampOracle<T> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_struct("BatchingTimestampOracle").finish()
}
}
impl<T> BatchingTimestampOracle<T>
where
T: Clone + Send + Sync + 'static,
{
/// Crates a [`BatchingTimestampOracle`] that uses the given inner oracle.
pub fn new(metrics: Arc<Metrics>, oracle: Arc<dyn TimestampOracle<T> + Send + Sync>) -> Self {
let (command_tx, mut command_rx) = tokio::sync::mpsc::unbounded_channel();
let task_oracle = Arc::clone(&oracle);
mz_ore::task::spawn(|| "BatchingTimestampOracle Worker Task", async move {
let read_ts_metrics = &metrics.batching.read_ts;
// See comment on `BatchingTimestampOracle` for why this batching is
// correct.
while let Some(cmd) = command_rx.recv().await {
let mut pending_cmds = vec![cmd];
while let Ok(cmd) = command_rx.try_recv() {
pending_cmds.push(cmd);
}
read_ts_metrics
.ops_count
.inc_by(u64::cast_from(pending_cmds.len()));
read_ts_metrics.batches_count.inc();
let ts = task_oracle.read_ts().await;
for cmd in pending_cmds {
match cmd {
Command::ReadTs(response_tx) => {
// It's okay if the receiver drops, just means
// they're not interested anymore.
let _ = response_tx.send(ts.clone());
}
}
}
}
tracing::debug!("shutting down BatchingTimestampOracle task");
});
Self {
inner: oracle,
command_tx,
}
}
}
#[async_trait]
impl<T> TimestampOracle<T> for BatchingTimestampOracle<T>
where
T: Send + Sync,
{
async fn write_ts(&self) -> WriteTimestamp<T> {
self.inner.write_ts().await
}
async fn peek_write_ts(&self) -> T {
self.inner.peek_write_ts().await
}
async fn read_ts(&self) -> T {
let (tx, rx) = oneshot::channel();
self.command_tx.send(Command::ReadTs(tx)).expect(
"worker task cannot stop while we still have senders for the command/request channel",
);
rx.await
.expect("worker task cannot stop while there are outstanding commands/requests")
}
async fn apply_write(&self, write_ts: T) {
self.inner.apply_write(write_ts).await
}
}
#[cfg(test)]
mod tests {
use mz_ore::metrics::MetricsRegistry;
use mz_repr::Timestamp;
use tracing::info;
use crate::postgres_oracle::{PostgresTimestampOracle, PostgresTimestampOracleConfig};
use super::*;
#[mz_ore::test(tokio::test)]
#[cfg_attr(miri, ignore)] // error: unsupported operation: can't call foreign function `TLS_client_method` on OS `linux`
async fn test_batching_timestamp_oracle() -> Result<(), anyhow::Error> {
let config = match PostgresTimestampOracleConfig::new_for_test() {
Some(config) => config,
None => {
info!(
"{} env not set: skipping test that uses external service",
PostgresTimestampOracleConfig::EXTERNAL_TESTS_POSTGRES_URL
);
return Ok(());
}
};
let metrics = Arc::new(Metrics::new(&MetricsRegistry::new()));
crate::tests::timestamp_oracle_impl_test(|timeline, now_fn, initial_ts| {
// We use the postgres oracle as the backing oracle.
let pg_oracle = PostgresTimestampOracle::open(
config.clone(),
timeline,
initial_ts,
now_fn,
false, /* read-only */
);
async {
let arced_pg_oracle: Arc<dyn TimestampOracle<Timestamp> + Send + Sync> =
Arc::new(pg_oracle.await);
let batching_oracle =
BatchingTimestampOracle::new(Arc::clone(&metrics), arced_pg_oracle);
let arced_oracle: Arc<dyn TimestampOracle<Timestamp> + Send + Sync> =
Arc::new(batching_oracle);
arced_oracle
}
})
.await?;
Ok(())
}
}