1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License in the LICENSE file at the
// root of this repository, or online at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//! Tokio task utilities.
//!
//! ## Named task spawning
//!
//! The [`spawn`] and [`spawn_blocking`] methods are wrappers around
//! [`tokio::task::spawn`] and [`tokio::task::spawn_blocking`] that attach a
//! name the spawned task.
//!
//! If Clippy sent you here, replace:
//!
//! ```ignore
//! tokio::task::spawn(my_future)
//! tokio::task::spawn_blocking(my_blocking_closure)
//! ```
//!
//! with:
//!
//! ```ignore
//! mz_ore::task::spawn(|| format!("taskname:{}", info), my_future)
//! mz_ore::task::spawn_blocking(|| format!("name:{}", info), my_blocking_closure)
//! ```
//!
//! If you are using methods of the same names on a [`Runtime`] or [`Handle`],
//! import [`RuntimeExt`] and replace `spawn` with [`RuntimeExt::spawn_named`]
//! and `spawn_blocking` with [`RuntimeExt::spawn_blocking_named`], adding
//! naming closures like above.
use std::future::Future;
use std::pin::Pin;
use std::sync::Arc;
use std::task::{Context, Poll};
use futures::FutureExt;
use tokio::runtime::{Handle, Runtime};
use tokio::task::{self, JoinError, JoinHandle as TokioJoinHandle};
/// Wraps a [`JoinHandle`] to abort the underlying task when dropped.
#[derive(Debug)]
pub struct AbortOnDropHandle<T>(TokioJoinHandle<T>);
impl<T> AbortOnDropHandle<T> {
/// Checks if the task associated with this [`AbortOnDropHandle`] has finished.a
pub fn is_finished(&self) -> bool {
self.0.is_finished()
}
// Note: adding an `abort(&self)` method here is incorrect, please see `unpack_join_result`.
}
impl<T> Drop for AbortOnDropHandle<T> {
fn drop(&mut self) {
self.0.abort();
}
}
impl<T> Future for AbortOnDropHandle<T> {
type Output = Result<T, JoinError>;
fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
self.0.poll_unpin(cx)
}
}
/// Wraps a tokio `JoinHandle` and provides 4 exclusive (i.e. they take `self` ownership)
/// operations:
///
/// - `abort_on_drop`: create an `AbortOnDropHandle` that will automatically abort the task
/// when the handle is dropped.
/// - `JoinHandleExt::wait_and_assert_finished`: wait for the task to finish and return its return value.
/// - `JoinHandleExt::abort_and_wait`: abort the task and wait for it to be finished.
/// - `into_tokio_handle`: turn it into an ordinary tokio `JoinHandle`.
#[derive(Debug)]
pub struct JoinHandle<T>(TokioJoinHandle<T>);
impl<T> Future for JoinHandle<T> {
type Output = Result<T, JoinError>;
fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
self.0.poll_unpin(cx)
}
}
impl<T> JoinHandle<T> {
/// Create an [`AbortOnDropHandle`] from this [`JoinHandle`].
pub fn abort_on_drop(self) -> AbortOnDropHandle<T> {
AbortOnDropHandle(self.0)
}
/// Checks if the task associated with this [`JoinHandle`] has finished.a
pub fn is_finished(&self) -> bool {
self.0.is_finished()
}
/// Checks if the task associated with this [`JoinHandle`] has finished.a
pub fn into_tokio_handle(self) -> TokioJoinHandle<T> {
self.0
}
// Note: adding an `abort(&self)` method here is incorrect, please see `unpack_join_result`.
}
/// Extension methods for [`JoinHandle`] and [`AbortOnDropHandle`].
#[async_trait::async_trait]
pub trait JoinHandleExt<T>: Future<Output = Result<T, JoinError>> {
/// Waits for the task to finish, resuming the unwind if the task panicked.
///
/// Because this takes ownership of `self`, and [`JoinHandle`] and
/// [`AbortOnDropHandle`] don't offer `abort` methods, this can avoid
/// worrying about aborted tasks.
async fn wait_and_assert_finished(self) -> T;
/// Aborts the task, then waits for it to complete.
async fn abort_and_wait(self);
}
async fn unpack_join_result<T>(res: Result<T, JoinError>) -> T {
match res {
Ok(val) => val,
Err(err) => match err.try_into_panic() {
Ok(panic) => std::panic::resume_unwind(panic),
Err(_) => {
// Because `JoinHandle` and `AbortOnDropHandle` don't
// offer `abort` method, this can only happen if the runtime is
// shutting down, which means this `pending` won't cause a deadlock
// because Tokio drops all outstanding futures on shutdown.
// (In multi-threaded runtimes, not all threads drop futures simultaneously,
// so it is possible for a future on one thread to observe the drop of a future
// on another thread, before it itself is dropped.)
//
// Instead, we yield to tokio runtime. A single `yield_now` is not
// sufficient as a `select!` or `FuturesUnordered` may
// poll this multiple times during shutdown.
std::future::pending().await
}
},
}
}
#[async_trait::async_trait]
impl<T: Send> JoinHandleExt<T> for JoinHandle<T> {
async fn wait_and_assert_finished(self) -> T {
unpack_join_result(self.await).await
}
async fn abort_and_wait(self) {
self.0.abort();
let _ = self.await;
}
}
#[async_trait::async_trait]
impl<T: Send, J: JoinHandleExt<T> + Send> JoinHandleExt<T>
for tracing::instrument::Instrumented<J>
{
async fn wait_and_assert_finished(self) -> T {
unpack_join_result(self.await).await
}
async fn abort_and_wait(self) {
self.abort_and_wait().await
}
}
#[async_trait::async_trait]
impl<T: Send> JoinHandleExt<T> for AbortOnDropHandle<T> {
// Because we are sure the `AbortOnDropHandle` still exists when we call
// `unpack_join_result` is called, we know `abort` hasn't been called, so its
// safe to call.
async fn wait_and_assert_finished(self) -> T {
unpack_join_result(self.await).await
}
async fn abort_and_wait(self) {
self.0.abort();
let _ = self.await;
}
}
/// Spawns a new asynchronous task with a name.
///
/// See [`tokio::task::spawn`] and the [module][`self`] docs for more
/// information.
#[cfg(not(tokio_unstable))]
#[track_caller]
pub fn spawn<Fut, Name, NameClosure>(_nc: NameClosure, future: Fut) -> JoinHandle<Fut::Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future + Send + 'static,
Fut::Output: Send + 'static,
{
#[allow(clippy::disallowed_methods)]
JoinHandle(tokio::spawn(future))
}
/// Spawns a new asynchronous task with a name.
///
/// See [`tokio::task::spawn`] and the [module][`self`] docs for more
/// information.
#[cfg(tokio_unstable)]
#[track_caller]
pub fn spawn<Fut, Name, NameClosure>(nc: NameClosure, future: Fut) -> JoinHandle<Fut::Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future + Send + 'static,
Fut::Output: Send + 'static,
{
#[allow(clippy::disallowed_methods)]
JoinHandle(
task::Builder::new()
.name(&format!("{}:{}", Handle::current().id(), nc().as_ref()))
.spawn(future)
.expect("task spawning cannot fail"),
)
}
/// Runs the provided closure with a name on a thread where blocking is
/// acceptable.
///
/// See [`tokio::task::spawn_blocking`] and the [module][`self`] docs for more
/// information.
#[cfg(not(tokio_unstable))]
#[track_caller]
#[allow(clippy::disallowed_methods)]
pub fn spawn_blocking<Function, Output, Name, NameClosure>(
_nc: NameClosure,
function: Function,
) -> JoinHandle<Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Function: FnOnce() -> Output + Send + 'static,
Output: Send + 'static,
{
JoinHandle(task::spawn_blocking(function))
}
/// Runs the provided closure with a name on a thread where blocking is
/// acceptable.
///
/// See [`tokio::task::spawn_blocking`] and the [module][`self`] docs for more
/// information.
#[cfg(tokio_unstable)]
#[track_caller]
#[allow(clippy::disallowed_methods)]
pub fn spawn_blocking<Function, Output, Name, NameClosure>(
nc: NameClosure,
function: Function,
) -> JoinHandle<Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Function: FnOnce() -> Output + Send + 'static,
Output: Send + 'static,
{
JoinHandle(
task::Builder::new()
.name(&format!("{}:{}", Handle::current().id(), nc().as_ref()))
.spawn_blocking(function)
.expect("task spawning cannot fail"),
)
}
/// Extension methods for [`Runtime`] and [`Handle`].
///
/// See the [module][`self`] docs for more information.
pub trait RuntimeExt {
/// Runs the provided closure with a name on a thread where blocking is
/// acceptable.
///
/// See [`tokio::task::spawn_blocking`] and the [module][`self`] docs for more
/// information.
#[track_caller]
fn spawn_blocking_named<Function, Output, Name, NameClosure>(
&self,
nc: NameClosure,
function: Function,
) -> JoinHandle<Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Function: FnOnce() -> Output + Send + 'static,
Output: Send + 'static;
/// Spawns a new asynchronous task with a name.
///
/// See [`tokio::task::spawn`] and the [module][`self`] docs for more
/// information.
#[track_caller]
fn spawn_named<Fut, Name, NameClosure>(
&self,
_nc: NameClosure,
future: Fut,
) -> JoinHandle<Fut::Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future + Send + 'static,
Fut::Output: Send + 'static;
}
impl RuntimeExt for &Runtime {
fn spawn_blocking_named<Function, Output, Name, NameClosure>(
&self,
nc: NameClosure,
function: Function,
) -> JoinHandle<Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Function: FnOnce() -> Output + Send + 'static,
Output: Send + 'static,
{
let _g = self.enter();
spawn_blocking(nc, function)
}
fn spawn_named<Fut, Name, NameClosure>(
&self,
nc: NameClosure,
future: Fut,
) -> JoinHandle<Fut::Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future + Send + 'static,
Fut::Output: Send + 'static,
{
let _g = self.enter();
spawn(nc, future)
}
}
impl RuntimeExt for Arc<Runtime> {
fn spawn_blocking_named<Function, Output, Name, NameClosure>(
&self,
nc: NameClosure,
function: Function,
) -> JoinHandle<Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Function: FnOnce() -> Output + Send + 'static,
Output: Send + 'static,
{
(&**self).spawn_blocking_named(nc, function)
}
fn spawn_named<Fut, Name, NameClosure>(
&self,
nc: NameClosure,
future: Fut,
) -> JoinHandle<Fut::Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future + Send + 'static,
Fut::Output: Send + 'static,
{
(&**self).spawn_named(nc, future)
}
}
impl RuntimeExt for Handle {
fn spawn_blocking_named<Function, Output, Name, NameClosure>(
&self,
nc: NameClosure,
function: Function,
) -> JoinHandle<Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Function: FnOnce() -> Output + Send + 'static,
Output: Send + 'static,
{
let _g = self.enter();
spawn_blocking(nc, function)
}
fn spawn_named<Fut, Name, NameClosure>(
&self,
nc: NameClosure,
future: Fut,
) -> JoinHandle<Fut::Output>
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future + Send + 'static,
Fut::Output: Send + 'static,
{
let _g = self.enter();
spawn(nc, future)
}
}
/// Extension methods for [`tokio::task::JoinSet`].
///
/// See the [module][`self`] docs for more information.
pub trait JoinSetExt<T> {
/// Spawns a new asynchronous task with a name.
///
/// See [`tokio::task::spawn`] and the [module][`self`] docs for more
/// information.
#[track_caller]
fn spawn_named<Fut, Name, NameClosure>(
&mut self,
nc: NameClosure,
future: Fut,
) -> tokio::task::AbortHandle
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future<Output = T> + Send + 'static,
T: Send + 'static;
}
impl<T> JoinSetExt<T> for tokio::task::JoinSet<T> {
// Allow unused variables until everything in ci uses `tokio_unstable`.
#[allow(unused_variables)]
fn spawn_named<Fut, Name, NameClosure>(
&mut self,
nc: NameClosure,
future: Fut,
) -> tokio::task::AbortHandle
where
Name: AsRef<str>,
NameClosure: FnOnce() -> Name,
Fut: Future<Output = T> + Send + 'static,
T: Send + 'static,
{
#[cfg(tokio_unstable)]
#[allow(clippy::disallowed_methods)]
{
self.build_task()
.name(&format!("{}:{}", Handle::current().id(), nc().as_ref()))
.spawn(future)
.expect("task spawning cannot fail")
}
#[cfg(not(tokio_unstable))]
#[allow(clippy::disallowed_methods)]
{
self.spawn(future)
}
}
}