opentelemetry_sdk/metrics/pipeline.rs
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736
use core::fmt;
use std::{
borrow::Cow,
collections::{HashMap, HashSet},
sync::{Arc, Mutex},
};
use opentelemetry::{
global,
metrics::{CallbackRegistration, MetricsError, Result},
KeyValue,
};
use crate::{
instrumentation::Scope,
metrics::{
aggregation,
data::{Metric, ResourceMetrics, ScopeMetrics},
instrument::{Instrument, InstrumentId, InstrumentKind, Stream},
internal,
internal::AggregateBuilder,
internal::Number,
reader::{AggregationSelector, DefaultAggregationSelector, MetricReader, SdkProducer},
view::View,
},
Resource,
};
/// Connects all of the instruments created by a meter provider to a [MetricReader].
///
/// This is the object that will be registered when a meter provider is
/// created.
///
/// As instruments are created the instrument should be checked if it exists in
/// the views of a the reader, and if so each aggregate function should be added
/// to the pipeline.
#[doc(hidden)]
pub struct Pipeline {
pub(crate) resource: Resource,
reader: Box<dyn MetricReader>,
views: Vec<Arc<dyn View>>,
inner: Box<Mutex<PipelineInner>>,
}
impl fmt::Debug for Pipeline {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.write_str("Pipeline")
}
}
/// Single or multi-instrument callbacks
type GenericCallback = Arc<dyn Fn() + Send + Sync>;
#[derive(Default)]
struct PipelineInner {
aggregations: HashMap<Scope, Vec<InstrumentSync>>,
callbacks: Vec<GenericCallback>,
multi_callbacks: Vec<Option<GenericCallback>>,
}
impl fmt::Debug for PipelineInner {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.debug_struct("PipelineInner")
.field("aggregations", &self.aggregations)
.field("callbacks", &self.callbacks.len())
.finish()
}
}
impl Pipeline {
/// Adds the [InstrumentSync] to pipeline with scope.
///
/// This method is not idempotent. Duplicate calls will result in duplicate
/// additions, it is the callers responsibility to ensure this is called with
/// unique values.
fn add_sync(&self, scope: Scope, i_sync: InstrumentSync) {
let _ = self.inner.lock().map(|mut inner| {
inner.aggregations.entry(scope).or_default().push(i_sync);
});
}
/// Registers a single instrument callback to be run when `produce` is called.
fn add_callback(&self, callback: GenericCallback) {
let _ = self
.inner
.lock()
.map(|mut inner| inner.callbacks.push(callback));
}
/// Registers a multi-instrument callback to be run when `produce` is called.
fn add_multi_callback(
&self,
callback: GenericCallback,
) -> Result<impl FnOnce(&Pipeline) -> Result<()>> {
let mut inner = self.inner.lock()?;
inner.multi_callbacks.push(Some(callback));
let idx = inner.multi_callbacks.len() - 1;
Ok(move |this: &Pipeline| {
let mut inner = this.inner.lock()?;
// can't compare trait objects so use index + tombstones to drop
inner.multi_callbacks[idx] = None;
Ok(())
})
}
/// Send accumulated telemetry
fn force_flush(&self) -> Result<()> {
self.reader.force_flush()
}
/// Shut down pipeline
fn shutdown(&self) -> Result<()> {
self.reader.shutdown()
}
}
impl SdkProducer for Pipeline {
/// Returns aggregated metrics from a single collection.
fn produce(&self, rm: &mut ResourceMetrics) -> Result<()> {
let inner = self.inner.lock()?;
for cb in &inner.callbacks {
// TODO consider parallel callbacks.
cb();
}
for mcb in inner.multi_callbacks.iter().flatten() {
// TODO consider parallel multi callbacks.
mcb();
}
rm.resource = self.resource.clone();
if inner.aggregations.len() > rm.scope_metrics.len() {
rm.scope_metrics
.reserve(inner.aggregations.len() - rm.scope_metrics.len());
}
let mut i = 0;
for (scope, instruments) in inner.aggregations.iter() {
let sm = match rm.scope_metrics.get_mut(i) {
Some(sm) => sm,
None => {
rm.scope_metrics.push(ScopeMetrics::default());
rm.scope_metrics.last_mut().unwrap()
}
};
if instruments.len() > sm.metrics.len() {
sm.metrics.reserve(instruments.len() - sm.metrics.len());
}
let mut j = 0;
for inst in instruments {
let mut m = sm.metrics.get_mut(j);
match (inst.comp_agg.call(m.as_mut().map(|m| m.data.as_mut())), m) {
// No metric to re-use, expect agg to create new metric data
((len, Some(initial_agg)), None) if len > 0 => sm.metrics.push(Metric {
name: inst.name.clone(),
description: inst.description.clone(),
unit: inst.unit.clone(),
data: initial_agg,
}),
// Existing metric can be re-used, update its values
((len, data), Some(prev_agg)) if len > 0 => {
if let Some(data) = data {
// previous aggregation was of a different type
prev_agg.data = data;
}
prev_agg.name.clone_from(&inst.name);
prev_agg.description.clone_from(&inst.description);
prev_agg.unit.clone_from(&inst.unit);
}
_ => continue,
}
j += 1;
}
sm.metrics.truncate(j);
if !sm.metrics.is_empty() {
sm.scope = scope.clone();
i += 1;
}
}
rm.scope_metrics.truncate(i);
Ok(())
}
}
/// A synchronization point between a [Pipeline] and an instrument's aggregate function.
struct InstrumentSync {
name: Cow<'static, str>,
description: Cow<'static, str>,
unit: Cow<'static, str>,
comp_agg: Box<dyn internal::ComputeAggregation>,
}
impl fmt::Debug for InstrumentSync {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.debug_struct("InstrumentSync")
.field("name", &self.name)
.field("description", &self.description)
.field("unit", &self.unit)
.finish()
}
}
type Cache<T> = Mutex<HashMap<InstrumentId, Result<Option<Arc<dyn internal::Measure<T>>>>>>;
/// Facilitates inserting of new instruments from a single scope into a pipeline.
struct Inserter<T> {
/// A cache that holds aggregate function inputs whose
/// outputs have been inserted into the underlying reader pipeline.
///
/// This cache ensures no duplicate aggregate functions are inserted into
/// the reader pipeline and if a new request during an instrument creation
/// asks for the same aggregate function input the same instance is
/// returned.
aggregators: Cache<T>,
/// A cache that holds instrument identifiers for all the instruments a [Meter] has
/// created.
///
/// It is provided from the `Meter` that owns this inserter. This cache ensures
/// that during the creation of instruments with the same name but different
/// options (e.g. description, unit) a warning message is logged.
views: Arc<Mutex<HashMap<Cow<'static, str>, InstrumentId>>>,
pipeline: Arc<Pipeline>,
}
impl<T> Inserter<T>
where
T: Number<T>,
{
fn new(p: Arc<Pipeline>, vc: Arc<Mutex<HashMap<Cow<'static, str>, InstrumentId>>>) -> Self {
Inserter {
aggregators: Default::default(),
views: vc,
pipeline: Arc::clone(&p),
}
}
/// Inserts the provided instrument into a pipeline.
///
/// All views the pipeline contains are matched against, and any matching view
/// that creates a unique [Aggregator] will be inserted into the pipeline and
/// included in the returned list.
///
/// The returned aggregate functions are ensured to be deduplicated and unique.
/// If another view in another pipeline that is cached by this inserter's cache
/// has already inserted the same aggregate function for the same instrument,
/// that function's instance is returned.
///
/// If another instrument has already been inserted by this inserter, or any
/// other using the same cache, and it conflicts with the instrument being
/// inserted in this call, an aggregate function matching the arguments will
/// still be returned but a log message will also be logged to the OTel global
/// logger.
///
/// If the passed instrument would result in an incompatible aggregate function,
/// an error is returned and that aggregate function is not inserted or
/// returned.
///
/// If an instrument is determined to use a [aggregation::Aggregation::Drop],
/// that instrument is not inserted nor returned.
fn instrument(&self, inst: Instrument) -> Result<Vec<Arc<dyn internal::Measure<T>>>> {
let mut matched = false;
let mut measures = vec![];
let mut errs = vec![];
let kind = match inst.kind {
Some(kind) => kind,
None => return Err(MetricsError::Other("instrument must have a kind".into())),
};
// The cache will return the same Aggregator instance. Use stream ids to de duplicate.
let mut seen = HashSet::new();
for v in &self.pipeline.views {
let stream = match v.match_inst(&inst) {
Some(stream) => stream,
None => continue,
};
matched = true;
let id = self.inst_id(kind, &stream);
if seen.contains(&id) {
continue; // This aggregator has already been added
}
let agg = match self.cached_aggregator(&inst.scope, kind, stream) {
Ok(Some(agg)) => agg,
Ok(None) => continue, // Drop aggregator.
Err(err) => {
errs.push(err);
continue;
}
};
seen.insert(id);
measures.push(agg);
}
if matched {
if errs.is_empty() {
return Ok(measures);
} else {
return Err(MetricsError::Other(format!("{errs:?}")));
}
}
// Apply implicit default view if no explicit matched.
let stream = Stream {
name: inst.name,
description: inst.description,
unit: inst.unit,
aggregation: None,
allowed_attribute_keys: None,
};
match self.cached_aggregator(&inst.scope, kind, stream) {
Ok(agg) => {
if errs.is_empty() {
if let Some(agg) = agg {
measures.push(agg);
}
Ok(measures)
} else {
Err(MetricsError::Other(format!("{errs:?}")))
}
}
Err(err) => {
errs.push(err);
Err(MetricsError::Other(format!("{errs:?}")))
}
}
}
/// Returns the appropriate aggregate functions for an instrument configuration.
///
/// If the exact instrument has been created within the [Scope], that
/// aggregate function instance will be returned. Otherwise, a new computed
/// aggregate function will be cached and returned.
///
/// If the instrument configuration conflicts with an instrument that has
/// already been created (e.g. description, unit, data type) a warning will be
/// logged with the global OTel logger. A valid new aggregate function for the
/// instrument configuration will still be returned without an error.
///
/// If the instrument defines an unknown or incompatible aggregation, an error
/// is returned.
fn cached_aggregator(
&self,
scope: &Scope,
kind: InstrumentKind,
mut stream: Stream,
) -> Result<Option<Arc<dyn internal::Measure<T>>>> {
let mut agg = stream
.aggregation
.take()
.unwrap_or_else(|| self.pipeline.reader.aggregation(kind));
// Apply default if stream or reader aggregation returns default
if matches!(agg, aggregation::Aggregation::Default) {
agg = DefaultAggregationSelector::new().aggregation(kind);
}
if let Err(err) = is_aggregator_compatible(&kind, &agg) {
return Err(MetricsError::Other(format!(
"creating aggregator with instrumentKind: {:?}, aggregation {:?}: {:?}",
kind, stream.aggregation, err,
)));
}
let mut id = self.inst_id(kind, &stream);
// If there is a conflict, the specification says the view should
// still be applied and a warning should be logged.
self.log_conflict(&id);
// If there are requests for the same instrument with different name
// casing, the first-seen needs to be returned. Use a normalize ID for the
// cache lookup to ensure the correct comparison.
id.normalize();
let mut cache = self.aggregators.lock()?;
let cached = cache.entry(id).or_insert_with(|| {
let filter = stream
.allowed_attribute_keys
.clone()
.map(|allowed| Arc::new(move |kv: &KeyValue| allowed.contains(&kv.key)) as Arc<_>);
let b = AggregateBuilder::new(Some(self.pipeline.reader.temporality(kind)), filter);
let (m, ca) = match aggregate_fn(b, &agg, kind) {
Ok(Some((m, ca))) => (m, ca),
other => return other.map(|fs| fs.map(|(m, _)| m)), // Drop aggregator or error
};
self.pipeline.add_sync(
scope.clone(),
InstrumentSync {
name: stream.name,
description: stream.description,
unit: stream.unit,
comp_agg: ca,
},
);
Ok(Some(m))
});
match cached {
Ok(opt) => Ok(opt.clone()),
Err(err) => Err(MetricsError::Other(err.to_string())),
}
}
/// Validates if an instrument with the same name as id has already been created.
///
/// If that instrument conflicts with id, a warning is logged.
fn log_conflict(&self, id: &InstrumentId) {
if let Ok(views) = self.views.lock() {
if let Some(existing) = views.get(id.name.to_lowercase().as_str()) {
if existing == id {
return;
}
global::handle_error(MetricsError::Other(format!(
"duplicate metric stream definitions, names: ({} and {}), descriptions: ({} and {}), kinds: ({:?} and {:?}), units: ({:?} and {:?}), and numbers: ({} and {})",
existing.name, id.name,
existing.description, id.description,
existing.kind, id.kind,
existing.unit, id.unit,
existing.number, id.number,
)))
}
}
}
fn inst_id(&self, kind: InstrumentKind, stream: &Stream) -> InstrumentId {
InstrumentId {
name: stream.name.clone(),
description: stream.description.clone(),
kind,
unit: stream.unit.clone(),
number: Cow::Borrowed(std::any::type_name::<T>()),
}
}
}
type AggregateFns<T> = (
Arc<dyn internal::Measure<T>>,
Box<dyn internal::ComputeAggregation>,
);
/// Returns new aggregate functions for the given params.
///
/// If the aggregation is unknown or temporality is invalid, an error is returned.
fn aggregate_fn<T: Number<T>>(
b: AggregateBuilder<T>,
agg: &aggregation::Aggregation,
kind: InstrumentKind,
) -> Result<Option<AggregateFns<T>>> {
use aggregation::Aggregation;
fn box_val<T>(
(m, ca): (impl internal::Measure<T>, impl internal::ComputeAggregation),
) -> (
Arc<dyn internal::Measure<T>>,
Box<dyn internal::ComputeAggregation>,
) {
(Arc::new(m), Box::new(ca))
}
match agg {
Aggregation::Default => aggregate_fn(
b,
&DefaultAggregationSelector::new().aggregation(kind),
kind,
),
Aggregation::Drop => Ok(None),
Aggregation::LastValue => Ok(Some(box_val(b.last_value()))),
Aggregation::Sum => {
let fns = match kind {
InstrumentKind::ObservableCounter => box_val(b.precomputed_sum(true)),
InstrumentKind::ObservableUpDownCounter => box_val(b.precomputed_sum(false)),
InstrumentKind::Counter | InstrumentKind::Histogram => box_val(b.sum(true)),
_ => box_val(b.sum(false)),
};
Ok(Some(fns))
}
Aggregation::ExplicitBucketHistogram {
boundaries,
record_min_max,
} => {
let record_sum = !matches!(
kind,
InstrumentKind::UpDownCounter
| InstrumentKind::ObservableUpDownCounter
| InstrumentKind::ObservableGauge
);
Ok(Some(box_val(b.explicit_bucket_histogram(
boundaries.to_vec(),
*record_min_max,
record_sum,
))))
}
Aggregation::Base2ExponentialHistogram {
max_size,
max_scale,
record_min_max,
} => {
let record_sum = !matches!(
kind,
InstrumentKind::UpDownCounter
| InstrumentKind::ObservableUpDownCounter
| InstrumentKind::ObservableGauge
);
Ok(Some(box_val(b.exponential_bucket_histogram(
*max_size,
*max_scale,
*record_min_max,
record_sum,
))))
}
}
}
/// Checks if the aggregation can be used by the instrument.
///
/// Current compatibility:
///
/// | Instrument Kind | Drop | LastValue | Sum | Histogram | Exponential Histogram |
/// |--------------------------|------|-----------|-----|-----------|-----------------------|
/// | Counter | ✓ | | ✓ | ✓ | ✓ |
/// | UpDownCounter | ✓ | | ✓ | ✓ | ✓ |
/// | Histogram | ✓ | | ✓ | ✓ | ✓ |
/// | Observable Counter | ✓ | | ✓ | ✓ | ✓ |
/// | Observable UpDownCounter | ✓ | | ✓ | ✓ | ✓ |
/// | Gauge | ✓ | ✓ | | ✓ | ✓ |
/// | Observable Gauge | ✓ | ✓ | | ✓ | ✓ |
fn is_aggregator_compatible(kind: &InstrumentKind, agg: &aggregation::Aggregation) -> Result<()> {
use aggregation::Aggregation;
match agg {
Aggregation::Default => Ok(()),
Aggregation::ExplicitBucketHistogram { .. }
| Aggregation::Base2ExponentialHistogram { .. } => {
if matches!(
kind,
InstrumentKind::Counter
| InstrumentKind::UpDownCounter
| InstrumentKind::Gauge
| InstrumentKind::Histogram
| InstrumentKind::ObservableCounter
| InstrumentKind::ObservableUpDownCounter
| InstrumentKind::ObservableGauge
) {
return Ok(());
}
Err(MetricsError::Other("incompatible aggregation".into()))
}
Aggregation::Sum => {
match kind {
InstrumentKind::ObservableCounter
| InstrumentKind::ObservableUpDownCounter
| InstrumentKind::Counter
| InstrumentKind::Histogram
| InstrumentKind::UpDownCounter => Ok(()),
_ => {
// TODO: review need for aggregation check after
// https://github.com/open-telemetry/opentelemetry-specification/issues/2710
Err(MetricsError::Other("incompatible aggregation".into()))
}
}
}
Aggregation::LastValue => {
match kind {
InstrumentKind::Gauge | InstrumentKind::ObservableGauge => Ok(()),
_ => {
// TODO: review need for aggregation check after
// https://github.com/open-telemetry/opentelemetry-specification/issues/2710
Err(MetricsError::Other("incompatible aggregation".into()))
}
}
}
Aggregation::Drop => Ok(()),
}
}
/// The group of pipelines connecting Readers with instrument measurement.
#[derive(Clone, Debug)]
pub(crate) struct Pipelines(pub(crate) Vec<Arc<Pipeline>>);
impl Pipelines {
pub(crate) fn new(
res: Resource,
readers: Vec<Box<dyn MetricReader>>,
views: Vec<Arc<dyn View>>,
) -> Self {
let mut pipes = Vec::with_capacity(readers.len());
for r in readers {
let p = Arc::new(Pipeline {
resource: res.clone(),
reader: r,
views: views.clone(),
inner: Default::default(),
});
p.reader.register_pipeline(Arc::downgrade(&p));
pipes.push(p);
}
Pipelines(pipes)
}
pub(crate) fn register_callback<F>(&self, callback: F)
where
F: Fn() + Send + Sync + 'static,
{
let cb = Arc::new(callback);
for pipe in &self.0 {
pipe.add_callback(cb.clone())
}
}
/// Registers a multi-instrument callback to be run when `produce` is called.
pub(crate) fn register_multi_callback<F>(&self, f: F) -> Result<Box<dyn CallbackRegistration>>
where
F: Fn() + Send + Sync + 'static,
{
let cb = Arc::new(f);
let fns = self
.0
.iter()
.map(|pipe| {
let pipe = Arc::clone(pipe);
let unreg = pipe.add_multi_callback(cb.clone())?;
Ok(Box::new(move || unreg(pipe.as_ref())) as _)
})
.collect::<Result<_>>()?;
Ok(Box::new(Unregister(fns)))
}
/// Force flush all pipelines
pub(crate) fn force_flush(&self) -> Result<()> {
let mut errs = vec![];
for pipeline in &self.0 {
if let Err(err) = pipeline.force_flush() {
errs.push(err);
}
}
if errs.is_empty() {
Ok(())
} else {
Err(MetricsError::Other(format!("{errs:?}")))
}
}
/// Shut down all pipelines
pub(crate) fn shutdown(&self) -> Result<()> {
let mut errs = vec![];
for pipeline in &self.0 {
if let Err(err) = pipeline.shutdown() {
errs.push(err);
}
}
if errs.is_empty() {
Ok(())
} else {
Err(MetricsError::Other(format!("{errs:?}")))
}
}
}
struct Unregister(Vec<Box<dyn FnOnce() -> Result<()> + Send + Sync>>);
impl CallbackRegistration for Unregister {
fn unregister(&mut self) -> Result<()> {
let mut errs = vec![];
while let Some(unreg) = self.0.pop() {
if let Err(err) = unreg() {
errs.push(err);
}
}
if errs.is_empty() {
Ok(())
} else {
Err(MetricsError::Other(format!("{errs:?}")))
}
}
}
/// resolver facilitates resolving aggregate functions an instrument calls to
/// aggregate measurements with while updating all pipelines that need to pull from
/// those aggregations.
pub(crate) struct Resolver<T> {
inserters: Vec<Inserter<T>>,
}
impl<T> Resolver<T>
where
T: Number<T>,
{
pub(crate) fn new(
pipelines: Arc<Pipelines>,
view_cache: Arc<Mutex<HashMap<Cow<'static, str>, InstrumentId>>>,
) -> Self {
let inserters = pipelines
.0
.iter()
.map(|pipe| Inserter::new(Arc::clone(pipe), Arc::clone(&view_cache)))
.collect();
Resolver { inserters }
}
/// The measures that must be updated by the instrument defined by key.
pub(crate) fn measures(&self, id: Instrument) -> Result<Vec<Arc<dyn internal::Measure<T>>>> {
let (mut measures, mut errs) = (vec![], vec![]);
for inserter in &self.inserters {
match inserter.instrument(id.clone()) {
Ok(ms) => measures.extend(ms),
Err(err) => errs.push(err),
}
}
if errs.is_empty() {
Ok(measures)
} else {
Err(MetricsError::Other(format!("{errs:?}")))
}
}
}