1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
use bytes::{Buf, BufMut};
use super::errors::{proto_dataflow_error, ProtoUpsertValueError, ProtoUpsertValueErrorLegacy};
#[derive(Clone, Debug, PartialEq)]
pub enum ProtoUpsertValueErrorShim {
New(ProtoUpsertValueError),
Legacy(Box<ProtoUpsertValueErrorLegacy>),
}
impl Default for ProtoUpsertValueErrorShim {
fn default() -> Self {
Self::New(ProtoUpsertValueError::default())
}
}
impl prost::Message for ProtoUpsertValueErrorShim {
fn encode_raw(&self, buf: &mut impl BufMut)
where
Self: Sized,
{
match self {
Self::New(new) => new.encode_raw(buf),
Self::Legacy(legacy) => legacy.encode_raw(buf),
}
}
fn merge_field(
&mut self,
tag: u32,
wire_type: prost::encoding::WireType,
buf: &mut impl Buf,
ctx: prost::encoding::DecodeContext,
) -> Result<(), prost::DecodeError>
where
Self: Sized,
{
if tag == 1 {
// This is the problematic tag that changed types. Here we need to do some type
// "inference" to figure out if we're decoding the new or the legacy format and update
// the variant of self accordingly.
// We need `merge_field` two times but we can only read the provided buffer once, so we
// make a local copy. This would normally be tricky with only the `Buf` bound but we
// know that we only get here as a result of a `Codec::decode` call, which has a &[u8]
// argument that is what B will be. This means that the `B: Buf` generic type is backed
// by a contiguous buffer and therefore calling `Buf::chunk` will give us all the data.
let data = buf.chunk().to_vec();
assert_eq!(data.len(), buf.remaining());
let mut new_buf = &*data;
let mut new_proto = ProtoUpsertValueError::default();
let new_merge = new_proto.merge_field(tag, wire_type, &mut new_buf, ctx.clone());
let mut legacy_buf = &*data;
let mut legacy_proto = ProtoUpsertValueErrorLegacy::default();
let legacy_merge =
legacy_proto.merge_field(tag, wire_type, &mut legacy_buf, ctx.clone());
// Let's see what happened
let (is_legacy, ret) = match (new_merge, legacy_merge) {
(Ok(()), Err(_)) => (false, Ok(())),
(Err(_), Ok(_)) => (true, Ok(())),
// If both succeeded we need to look deeper into the abyss and use heuristics
(Ok(()), Ok(())) => {
let maybe_new = match &new_proto.inner {
Some(decode_err) => decode_err.raw.is_some(),
None => false,
};
let maybe_legacy = match &legacy_proto.inner {
Some(inner) => match &inner.kind {
Some(proto_dataflow_error::Kind::DecodeError(decode_err)) => {
decode_err.raw.is_some()
}
_ => false,
},
None => false,
};
if maybe_new == maybe_legacy {
panic!("could not figure out the variant: {new_proto:?} {legacy_proto:?}");
}
(maybe_legacy && !maybe_new, Ok(()))
}
// If both failed we will arbitrarily pick the new variant. This is not expected to
// happen
(Err(err), Err(_)) => (false, Err(err)),
};
if is_legacy {
fail::fail_point!("reject_legacy_upsert_errors");
*self = Self::Legacy(Box::new(legacy_proto));
buf.advance(data.len() - legacy_buf.len());
} else {
*self = Self::New(new_proto);
buf.advance(data.len() - new_buf.len());
}
ret
} else {
// For all other tags we simply continue with what we have since the determination has
// already happened.
match self {
Self::New(new) => new.merge_field(tag, wire_type, buf, ctx),
Self::Legacy(legacy) => legacy.merge_field(tag, wire_type, buf, ctx),
}
}
}
fn encoded_len(&self) -> usize {
match self {
Self::New(new) => new.encoded_len(),
Self::Legacy(legacy) => legacy.encoded_len(),
}
}
fn clear(&mut self) {
match self {
Self::New(new) => new.clear(),
Self::Legacy(legacy) => legacy.clear(),
}
}
}
#[cfg(test)]
mod test {
use mz_proto::RustType;
use mz_repr::{Datum, Row};
use prost::Message;
use crate::errors::{proto_dataflow_error, ProtoDataflowError};
use crate::errors::{DecodeError, DecodeErrorKind};
use super::*;
#[mz_ore::test]
fn sanity_check() {
// Create an assortment of different decode errors to make sure we can correctly tell apart
// the two protobuf serializations. We are especially interested in pathological cases
// (empty strings/empty vectors) which might trip the protobuf decoder up.
let decode_errors = vec![
// Empty Text kind plus zeros
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 1],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 2],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 4],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 16],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 32],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 64],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 128],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 256],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 512],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0; 1024],
},
// None-empty Text kind plus zeros
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 1],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 2],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 4],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 16],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 32],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 64],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 128],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 256],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 512],
},
DecodeError {
kind: DecodeErrorKind::Text("foo".into()),
raw: vec![0; 1024],
},
// Empty Text kind plus 0x42
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 1],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 2],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 4],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 16],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 32],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 64],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 128],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 256],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 512],
},
DecodeError {
kind: DecodeErrorKind::Text("".into()),
raw: vec![0x42; 1024],
},
// None-empty Text kind plus 0x42
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 1],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 2],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 4],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 16],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 32],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 64],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 128],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 256],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 512],
},
DecodeError {
kind: DecodeErrorKind::Text("fooooo".into()),
raw: vec![0x42; 1024],
},
// Empty Bytes kind plus zeros
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 1],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 2],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 4],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 16],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 32],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 64],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 128],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 256],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 512],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0; 1024],
},
// None-empty Bytes kind plus zeros
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 1],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 2],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 4],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 16],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 32],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 64],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 128],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 256],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 512],
},
DecodeError {
kind: DecodeErrorKind::Bytes("foo".into()),
raw: vec![0; 1024],
},
// Empty Bytes kind plus 0x42
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 1],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 2],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 4],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 16],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 32],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 64],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 128],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 256],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 512],
},
DecodeError {
kind: DecodeErrorKind::Bytes("".into()),
raw: vec![0x42; 1024],
},
// None-empty Bytes kind plus 0x42
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 1],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 2],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 4],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 16],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 32],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 64],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 128],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 256],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 512],
},
DecodeError {
kind: DecodeErrorKind::Bytes("i love protobuf".into()),
raw: vec![0x42; 1024],
},
];
// Now we go through each one of them, encode it in two different ways using the normal
// Proto structs, which is how Materialize 0.68.1 and 0.69.1 would do it, and then attemp
// to decode them with the shim. The shim should correctly understand if it is reading a
// new or legacy format.
// We don't care about the key, the whole determination happens during processing of the
// firs tag, which is the inner error.
let key = Row::pack([Datum::String("the key")]);
for err in decode_errors {
let inner = ProtoDataflowError {
kind: Some(proto_dataflow_error::Kind::DecodeError(err.into_proto())),
};
let legacy_proto = ProtoUpsertValueErrorLegacy {
inner: Some(inner),
for_key: Some(key.into_proto()),
};
let legacy_bytes = legacy_proto.encode_to_vec();
let legacy_shim = ProtoUpsertValueErrorShim::decode(&*legacy_bytes).unwrap();
assert_eq!(
legacy_shim,
ProtoUpsertValueErrorShim::Legacy(Box::new(legacy_proto))
);
let new_proto = ProtoUpsertValueError {
inner: Some(err.into_proto()),
for_key: Some(key.into_proto()),
};
let new_bytes = new_proto.encode_to_vec();
let new_shim = ProtoUpsertValueErrorShim::decode(&*new_bytes).unwrap();
assert_eq!(new_shim, ProtoUpsertValueErrorShim::New(new_proto));
}
}
}