1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
use std::collections::btree_map::Entry;
use std::collections::BTreeMap;
use std::fmt::Write;
use std::num::NonZeroI64;
use std::sync::{Arc, Mutex};
use std::time::Duration;
use derivative::Derivative;
use differential_dataflow::lattice::Lattice;
use futures::future::{self, BoxFuture, FutureExt, TryFutureExt};
use futures::{Future, StreamExt};
use mz_ore::metrics::{MetricsFutureExt, MetricsRegistry};
use mz_ore::retry::Retry;
use mz_stash_types::metrics::Metrics;
use mz_stash_types::{InternalStashError, StashError};
use postgres_openssl::MakeTlsConnector;
use prometheus::Histogram;
use rand::Rng;
use timely::progress::Antichain;
use tokio::sync::{mpsc, oneshot};
use tokio::time::Interval;
use tokio_postgres::error::SqlState;
use tokio_postgres::{Client, Config, Statement};
use tracing::{debug, event, info, warn, Level};
use crate::{Diff, Id, Timestamp};
// TODO: Change the indexes on data to be more applicable to the current
// consolidation technique. This will involve a migration (which we don't yet
// have code to handle).
const SCHEMA: &str = "
CREATE TABLE fence (
epoch bigint PRIMARY KEY,
nonce bytea,
version bigint DEFAULT 1 NOT NULL
);
-- Epochs and versions are guaranteed to be non-zero, so start counting at 1.
INSERT INTO fence (epoch, nonce, version) VALUES (1, '', 1);
-- bigserial is not ideal for Cockroach, but we have a stable number of
-- collections, so our use of it here is fine and compatible with Postgres.
CREATE TABLE collections (
collection_id bigserial PRIMARY KEY,
name text NOT NULL UNIQUE
);
CREATE TABLE data (
collection_id bigint NOT NULL REFERENCES collections (collection_id),
key bytea NOT NULL,
value bytea NOT NULL,
time bigint NOT NULL,
diff bigint NOT NULL
);
CREATE INDEX data_time_idx ON data (collection_id, time);
CREATE TABLE sinces (
collection_id bigint PRIMARY KEY REFERENCES collections (collection_id),
since bigint
);
CREATE TABLE uppers (
collection_id bigint PRIMARY KEY REFERENCES collections (collection_id),
upper bigint
);
";
// Force reconnection every few minutes to allow cockroach to rebalance
// connections after it restarts during maintenance or upgrades.
const RECONNECT_INTERVAL: Duration = Duration::from_secs(300);
struct PreparedStatements {
fetch_epoch: Statement,
iter_key: Statement,
since: Statement,
upper: Statement,
collection: Statement,
iter: Statement,
seal: Statement,
compact: Statement,
update_many: Arc<tokio::sync::Mutex<BTreeMap<usize, Statement>>>,
}
impl PreparedStatements {
async fn from(client: &Client, mode: TransactionMode) -> Result<Self, StashError> {
let fetch_epoch_fut = client.prepare(match mode {
TransactionMode::Readonly | TransactionMode::Savepoint => {
// For readonly and savepoint stashes, don't attempt to
// increment the version and instead hard code it to 0 which
// will always fail the version check, since the version
// starts at 1 and goes up. Savepoint however will never
// retry COMMITs (and otherwise they'd retry forever because
// 0 will never succeed). Readonly can safely retry the
// original transaction.
"SELECT epoch, nonce, 0 AS version FROM fence"
}
TransactionMode::Writeable => {
"UPDATE fence SET version=version+1 RETURNING epoch, nonce, version"
}
});
let iter_key_fut = client.prepare(
"SELECT value, time, diff FROM data
WHERE collection_id = $1 AND key = $2",
);
let since_fut = client.prepare("SELECT since FROM sinces WHERE collection_id = $1");
let upper_fut = client.prepare("SELECT upper FROM uppers WHERE collection_id = $1");
let collection_fut =
client.prepare("SELECT collection_id FROM collections WHERE name = $1");
let iter_fut = client.prepare(
"SELECT key, value, time, diff FROM data
WHERE collection_id = $1",
);
let seal_fut = client.prepare("UPDATE uppers SET upper = $1 WHERE collection_id = $2");
let compact_fut = client.prepare("UPDATE sinces SET since = $1 WHERE collection_id = $2");
// Run all of our prepare statements in parallel.
let (fetch_epoch, iter_key, since, upper, collection, iter, seal, compact) = futures::try_join!(
fetch_epoch_fut,
iter_key_fut,
since_fut,
upper_fut,
collection_fut,
iter_fut,
seal_fut,
compact_fut
)?;
Ok(PreparedStatements {
fetch_epoch,
iter_key,
since,
upper,
collection,
iter,
seal,
compact,
update_many: Arc::new(tokio::sync::Mutex::new(BTreeMap::new())),
})
}
}
// Track statement execution counts.
pub(crate) struct CountedStatements<'a> {
stmts: &'a PreparedStatements,
metrics: &'a Arc<Metrics>,
// Due to our use of try_join and futures, this needs to be an Arc Mutex.
// Use a BTreeMap for deterministic debug printing. Use an Option to avoid
// allocating an Arc when unused.
counts: Option<Arc<Mutex<BTreeMap<String, usize>>>>,
}
impl<'a> CountedStatements<'a> {
fn from(stmts: &'a PreparedStatements, metrics: &'a Arc<Metrics>) -> Self {
Self {
stmts,
metrics,
counts: if tracing::enabled!(Level::DEBUG) {
Some(Arc::new(Mutex::new(BTreeMap::new())))
} else {
None
},
}
}
fn inc<S: Into<String>>(&self, name: S) {
if let Some(counts) = &self.counts {
let mut map = counts.lock().unwrap();
*map.entry(name.into()).or_default() += 1;
*map.entry("_total".into()).or_default() += 1;
}
}
fn fetch_epoch(&self) -> (&Statement, Histogram) {
let name = "fetch_epoch";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.fetch_epoch, histogram)
}
pub(crate) fn iter_key(&self) -> (&Statement, Histogram) {
let name = "iter_key";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.iter_key, histogram)
}
pub(crate) fn since(&self) -> (&Statement, Histogram) {
let name = "since";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.since, histogram)
}
pub(crate) fn upper(&self) -> (&Statement, Histogram) {
let name = "upper";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.upper, histogram)
}
pub(crate) fn collection(&self) -> (&Statement, Histogram) {
let name = "collection";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.collection, histogram)
}
pub(crate) fn iter(&self) -> (&Statement, Histogram) {
let name = "iter";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.iter, histogram)
}
pub(crate) fn seal(&self) -> (&Statement, Histogram) {
let name = "seal";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.seal, histogram)
}
pub(crate) fn compact(&self) -> (&Statement, Histogram) {
let name = "compact";
self.inc(name);
let histogram = self
.metrics
.query_latency_duration_seconds
.with_label_values(&[name]);
(&self.stmts.compact, histogram)
}
/// Returns a ToStatement to INSERT a specified number of rows. First
/// statement parameter is collection_id. Then key, value, time, diff as
/// sets of 4 for each row.
pub(crate) async fn update(
&self,
client: &Client,
rows: usize,
) -> Result<Statement, StashError> {
self.inc(format!("update[{rows}]"));
match self.stmts.update_many.lock().await.entry(rows) {
Entry::Occupied(entry) => Ok(entry.get().clone()),
Entry::Vacant(entry) => {
let mut stmt =
String::from("INSERT INTO data (collection_id, key, value, time, diff) VALUES");
let mut sep = ' ';
for i in 0..rows {
let idx = 1 + i * 4;
write!(
&mut stmt,
"{}($1, ${}, ${}, ${}, ${})",
sep,
idx + 1,
idx + 2,
idx + 3,
idx + 4
)
.unwrap();
sep = ',';
}
let stmt = client.prepare(&stmt).await?;
Ok(entry.insert(stmt).clone())
}
}
}
}
#[derive(Debug, Clone, Copy)]
enum TransactionMode {
/// Transact operations occurs in a normal transaction.
Writeable,
/// Transact operations occur in a read-only transaction.
Readonly,
/// Transact operations occur in a nested transaction using SAVEPOINTs.
Savepoint,
}
/// Factory type used to open new one or more [`Stash`].
#[derive(Debug, Clone)]
pub struct StashFactory {
metrics: Arc<Metrics>,
}
impl StashFactory {
pub fn new(registry: &MetricsRegistry) -> StashFactory {
Self::from_metrics(Arc::new(Metrics::register_into(registry)))
}
pub fn from_metrics(metrics: Arc<Metrics>) -> StashFactory {
StashFactory { metrics }
}
/// Opens the stash stored at the specified path.
pub async fn open(
&self,
url: String,
schema: Option<String>,
tls: MakeTlsConnector,
epoch_lower_bound: Option<NonZeroI64>,
) -> Result<Stash, StashError> {
self.open_inner(
TransactionMode::Writeable,
url,
schema,
tls,
epoch_lower_bound,
)
.await
}
/// Opens the stash stored at the specified path in readonly mode: any
/// mutating query will fail, and the epoch is not incremented on start.
pub async fn open_readonly(
&self,
url: String,
schema: Option<String>,
tls: MakeTlsConnector,
) -> Result<Stash, StashError> {
self.open_inner(TransactionMode::Readonly, url, schema, tls, None)
.await
}
/// Opens the stash stored at the specified path in savepoint mode: mutating
/// queries are allowed, but they will never be committed, and the epoch is
/// not incremented on start. This mode is used to test migrations on a
/// running stash.
pub async fn open_savepoint(
&self,
url: String,
schema: Option<String>,
tls: MakeTlsConnector,
epoch_lower_bound: Option<NonZeroI64>,
) -> Result<Stash, StashError> {
self.open_inner(
TransactionMode::Savepoint,
url,
schema,
tls,
epoch_lower_bound,
)
.await
}
async fn open_inner(
&self,
txn_mode: TransactionMode,
url: String,
schema: Option<String>,
tls: MakeTlsConnector,
epoch_lower_bound: Option<NonZeroI64>,
) -> Result<Stash, StashError> {
if let Some(epoch_lower_bound) = &epoch_lower_bound {
info!(?epoch_lower_bound);
}
let mut config: Config = url.parse()?;
// We'd like to use the crdb_connect_timeout SystemVar here (because it can
// be set in LaunchDarkly), but our current APIs only expose that after the
// catalog exists, which needs a working stash. Hard code something with a
// too-high timeout to hedge against a too-low number that causes bootstrap
// problems until then.
const DEFAULT_STASH_CONNECT_TIMEOUT: Duration = Duration::from_secs(30);
config.connect_timeout(DEFAULT_STASH_CONNECT_TIMEOUT);
let config = Arc::new(tokio::sync::Mutex::new(config));
let (sinces_tx, mut sinces_rx) = mpsc::unbounded_channel();
let mut conn = Stash {
txn_mode,
config: Arc::clone(&config),
schema: schema.clone(),
tls: tls.clone(),
client: None,
reconnect: tokio::time::interval(RECONNECT_INTERVAL),
statements: None,
epoch: None,
// The call to rand::random here assumes that the seed source is from a secure
// source that will differ per thread. The docs for ThreadRng say it "is
// automatically seeded from OsRng", which meets this requirement.
nonce: rand::random(),
sinces_tx,
metrics: Arc::clone(&self.metrics),
collections: BTreeMap::new(),
};
// Do the initial connection once here so we don't get stuck in transact's retry loop if the
// url is bad. We also need to allow for a down server, though, so retry for a while before
// bailing. These numbers are made up.
let retry = Retry::default()
.clamp_backoff(Duration::from_secs(1))
.max_duration(Duration::from_secs(30))
.into_retry_stream();
let mut retry = Box::pin(retry);
loop {
match conn.connect(epoch_lower_bound).await {
Ok(()) => break,
Err(err) => {
warn!("initial stash connection error, retrying: {err}");
if err.is_unrecoverable() || retry.next().await.is_none() {
return Err(err);
}
}
}
}
if matches!(conn.txn_mode, TransactionMode::Savepoint) {
// In savepoint mode, pretend that we're consolidating things.
mz_ore::task::spawn(|| "stash consolidation dropper", async move {
while let Some(_) = sinces_rx.recv().await {}
});
} else {
Consolidator::start(config, schema, tls, sinces_rx);
}
Ok(conn)
}
}
/// A Stash whose data is stored in a Postgres-compatible database. The format of the
/// tables are not specified and should not be relied upon. The only promise is
/// stability. Any changes to the table schemas will be accompanied by a clear
/// migration path.
pub struct Stash {
txn_mode: TransactionMode,
config: Arc<tokio::sync::Mutex<Config>>,
schema: Option<String>,
tls: MakeTlsConnector,
client: Option<Client>,
reconnect: Interval,
statements: Option<PreparedStatements>,
epoch: Option<NonZeroI64>,
nonce: [u8; 16],
pub(crate) sinces_tx: mpsc::UnboundedSender<ConsolidateRequest>,
pub(crate) collections: BTreeMap<String, Id>,
pub metrics: Arc<Metrics>,
}
#[derive(Debug)]
pub(crate) struct ConsolidateRequest {
pub(crate) id: Id,
pub(crate) since: Antichain<Timestamp>,
pub(crate) done: Option<oneshot::Sender<()>>,
}
impl std::fmt::Debug for Stash {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_struct("Postgres")
.field("config", &self.config)
.field("epoch", &self.epoch)
.field("nonce", &self.nonce)
.finish_non_exhaustive()
}
}
impl Stash {
/// Drops all tables associated with the stash if they exist. Only used in tests and benchmarks.
pub async fn clear(url: &str, tls: MakeTlsConnector) -> Result<(), StashError> {
let (client, connection) = tokio_postgres::connect(url, tls).await?;
mz_ore::task::spawn(|| "tokio-postgres stash connection", async move {
if let Err(e) = connection.await {
tracing::warn!("postgres stash connection error: {}", e);
}
});
client
.batch_execute(
"
BEGIN;
DROP TABLE IF EXISTS uppers;
DROP TABLE IF EXISTS sinces;
DROP TABLE IF EXISTS data;
DROP TABLE IF EXISTS collections;
DROP TABLE IF EXISTS fence;
COMMIT;
",
)
.await?;
Ok(())
}
/// Creates a debug stash from the current COCKROACH_URL with a random
/// schema, and DROPs it after `f` has returned.
pub async fn with_debug_stash<F, T, Fut>(f: F) -> Result<T, StashError>
where
F: FnOnce(Stash) -> Fut,
Fut: Future<Output = T>,
{
let factory = DebugStashFactory::try_new().await?;
match factory.try_open().await {
Ok(stash) => {
let res = Ok(f(stash).await);
factory.drop().await;
res
}
Err(err) => {
factory.drop().await;
Err(err)
}
}
}
/// Verifies stash invariants. Should only be called by tests.
#[cfg(test)]
pub(crate) async fn verify(&self) -> Result<(), StashError> {
let client = self.client.as_ref().unwrap();
// Because consolidation is in a separate task, allow this to retry.
Retry::default()
.max_duration(Duration::from_secs(10))
.retry_async(|_| async {
let count: i64 = client
.query_one("SELECT count(*) FROM data WHERE diff < 0", &[])
.await
.expect("verify select count failed")
.get(0);
if count > 0 {
Err(format!("found {count} data rows with negative diff").into())
} else {
Ok(())
}
})
.await
}
pub async fn set_connect_timeout(&mut self, connect_timeout: Duration) {
// TODO: This should be set in the constructor, but we don't have access
// to LaunchDarkly at that time.
self.config.lock().await.connect_timeout(connect_timeout);
}
/// Sets `client` to a new connection to the Postgres server.
#[mz_ore::instrument(name = "stash::connect", level = "debug")]
async fn connect(&mut self, epoch_lower_bound: Option<NonZeroI64>) -> Result<(), StashError> {
// Initialize a connection.
let result = self.config.lock().await.connect(self.tls.clone()).await;
let (mut client, connection) = match result {
Ok((client, connection)) => {
self.metrics
.connection_attempts
.with_label_values(&["success"])
.inc();
(client, connection)
}
Err(e) => {
self.metrics
.connection_attempts
.with_label_values(&["failure"])
.inc();
return Err(e.into());
}
};
let metrics = Arc::clone(&self.metrics);
mz_ore::task::spawn(|| "tokio-postgres stash connection", async move {
if let Err(e) = connection.await {
metrics.connection_errors.inc();
tracing::warn!("postgres stash connection error: {}", e);
}
});
// The Config is shared with the Consolidator, so we update the application name in the
// session instead of the Config.
let mut statements = vec![
"SET application_name = 'stash'".to_string(),
"SET default_transaction_isolation = serializable".to_string(),
];
if let Some(schema) = &self.schema {
statements.push(format!("SET search_path TO {schema}"));
}
let query = statements.join(";");
// Run all of our setup as a single query to reduce network roundtrips.
client.batch_execute(&query).await?;
if self.epoch.is_none() {
let tx = client
.build_transaction()
.read_only(matches!(self.txn_mode, TransactionMode::Readonly))
.start()
.await?;
let fence_exists: bool = tx
.query_one(
r#"
SELECT EXISTS (
SELECT 1 FROM pg_tables
WHERE schemaname = current_schema() AND tablename = 'fence'
)"#,
&[],
)
.await?
.get(0);
if !fence_exists {
if !matches!(self.txn_mode, TransactionMode::Writeable) {
return Err(StashError {
inner: InternalStashError::StashNotWritable(format!(
"stash tables do not exist; will not create in {:?} mode",
self.txn_mode
)),
});
}
tx.batch_execute(SCHEMA).await?;
}
let epoch = if matches!(self.txn_mode, TransactionMode::Writeable) {
// The `data`, `sinces`, and `uppers` tables can create and delete
// rows at a high frequency, generating many tombstoned rows. If
// Cockroach's GC interval is set high (the default is 25h) and
// these tombstones accumulate, scanning over the table will take
// increasingly and prohibitively long.
//
// See: https://github.com/MaterializeInc/materialize/issues/15842
// See: https://www.cockroachlabs.com/docs/stable/configure-zone.html#variables
let statements = [
"ALTER TABLE data CONFIGURE ZONE USING gc.ttlseconds = 600",
"ALTER TABLE sinces CONFIGURE ZONE USING gc.ttlseconds = 600",
"ALTER TABLE uppers CONFIGURE ZONE USING gc.ttlseconds = 600",
];
let query = statements.join(";");
tx.batch_execute(&query).await?;
// Bump the epoch, which will cause any previous connection to fail. Add a
// unique nonce so that if some other thing recreates the entire schema, we
// can't accidentally have the same epoch, nonce pair (especially risky if the
// current epoch has been bumped exactly once, then gets recreated by another
// connection that also bumps it once).
let epoch_lower_bound = epoch_lower_bound.unwrap_or(NonZeroI64::MIN).get();
let row = tx
.query_one(
"UPDATE fence SET epoch=GREATEST(epoch+1, $1), nonce=$2 RETURNING epoch",
&[&epoch_lower_bound, &self.nonce.to_vec()],
)
.await?;
NonZeroI64::new(row.get(0)).unwrap()
} else {
let row = tx.query_one("SELECT epoch, nonce FROM fence", &[]).await?;
let nonce: &[u8] = row.get(1);
self.nonce = nonce.try_into().map_err(|_| "could not read nonce")?;
NonZeroI64::new(row.get(0)).unwrap()
};
tx.commit().await?;
self.epoch = Some(epoch);
}
self.statements = Some(PreparedStatements::from(&client, self.txn_mode).await?);
// In savepoint mode start a transaction that will never be committed.
// Use a low priority so the rw stash won't ever block waiting for the
// savepoint stash to complete its transaction.
if matches!(self.txn_mode, TransactionMode::Savepoint) {
client.batch_execute("BEGIN PRIORITY LOW").await?;
}
self.client = Some(client);
Ok(())
}
/// Construct a fenced transaction, which will cause this Stash to fail if
/// another connection is opened to it. `f` may be called multiple times in a
/// backoff-retry loop if the Postgres server is unavailable, so it should only
/// call functions on its Transaction argument.
///
/// # Examples
///
/// ```text
/// async fn x(&mut self) -> Result<(), StashError> {
/// self.transact(move |stmts, tx| {
/// Box::pin(async move {
/// // Use tx.
/// })
/// })
/// .await
/// }
/// ```
#[mz_ore::instrument(name = "stash::transact", level = "debug")]
pub(crate) async fn transact<F, T>(&mut self, f: F) -> Result<T, StashError>
where
F: for<'a> Fn(
&'a CountedStatements<'a>,
&'a Client,
&'a BTreeMap<String, Id>,
) -> BoxFuture<'a, Result<T, StashError>>,
{
self.metrics.transactions.inc();
let retry = Retry::default()
.clamp_backoff(Duration::from_secs(1))
.into_retry_stream();
let mut retry = Box::pin(retry);
let mut attempt: u64 = 0;
// Actively reconnect to allow cockroach to rebalanace.
if self.reconnect.tick().now_or_never().is_some() {
self.client = None;
}
'transact_inner: loop {
// Execute the operation in a transaction or savepoint.
match self.transact_inner(&f).await {
Ok(r) => return Ok(r),
Err(e) => {
// If this returns an error, close the connection to force a
// reconnect (and also not need to worry about any
// in-progress transaction state cleanup).
self.client = None;
attempt += 1;
let cause = e.cause();
self.metrics
.transaction_errors
.with_label_values(&[cause])
.inc();
info!(
"tokio-postgres stash error, retry attempt {attempt}: {}, code: {:?}",
e,
e.code(),
);
// Savepoint is never retryable because we can't restore all
// previous savepoints.
//
// TODO: This could be taught to retry if needed to make the
// upgrade checker of stash-debug more resilient. Would need
// to adjust fetch_epoch to attempt to increment the version
// if we do that.
if matches!(self.txn_mode, TransactionMode::Savepoint) {
match e {
TransactionError::Commit { .. } => {
return Err("indeterminate COMMIT".into())
}
TransactionError::Epoch(err)
| TransactionError::Connect(err)
| TransactionError::Txn(err) => return Err(err),
}
}
if e.retryable() {
// Retry only known safe errors. Others need to cause a
// fatal crash in environmentd because a transaction
// could have committed without us receiving the commit
// confirmation
retry.next().await;
} else {
match e {
TransactionError::Commit {
committed_if_version,
result,
} => {
// COMMIT is indeterminate. Check if it succeeded in a
// new transaction.
loop {
match self.determine_commit(committed_if_version).await {
Ok(succeeded) => {
if succeeded {
return Ok(result);
} else {
// COMMIT failed, retry the transaction.
continue 'transact_inner;
}
}
Err(err) => {
// If there was an error during COMMIT
// check, we might be able to retry it.
if err.is_unrecoverable() {
return Err(err);
}
// Implied `continue`.
}
}
}
}
TransactionError::Epoch(err)
| TransactionError::Connect(err)
| TransactionError::Txn(err) => return Err(err),
}
}
}
}
}
}
#[mz_ore::instrument(name = "stash::transact_inner", level = "debug")]
async fn transact_inner<F, T>(&mut self, f: &F) -> Result<T, TransactionError<T>>
where
F: for<'a> Fn(
&'a CountedStatements<'a>,
&'a Client,
&'a BTreeMap<String, Id>,
) -> BoxFuture<'a, Result<T, StashError>>,
{
// Use a function so we can instrument.
#[mz_ore::instrument(name = "stash::batch_execute", level = "debug")]
async fn batch_execute(client: &Client, stmt: &str) -> Result<(), tokio_postgres::Error> {
client.batch_execute(stmt).await
}
let reconnect = match &self.client {
Some(client) => client.is_closed(),
None => true,
};
if reconnect {
self.connect(None)
.await
.map_err(TransactionError::Connect)?;
}
// client is guaranteed to be Some here.
let client = self.client.as_mut().unwrap();
let stmts = self.statements.as_ref().unwrap();
let stmts = CountedStatements::from(stmts, &self.metrics);
// Generate statements to execute depending on our mode.
let (tx_start, tx_end) = match self.txn_mode {
TransactionMode::Writeable => ("BEGIN PRIORITY NORMAL", "COMMIT"),
TransactionMode::Readonly => ("BEGIN READ ONLY PRIORITY NORMAL", "COMMIT"),
TransactionMode::Savepoint => ("SAVEPOINT stash", "RELEASE SAVEPOINT stash"),
};
batch_execute(client, tx_start)
.await
.map_err(|err| TransactionError::Txn(err.into()))?;
// Pipeline the epoch query and closure.
let (query, histogram) = stmts.fetch_epoch();
let epoch_fut = client
.query_one(query, &[])
.map_err(|err| err.into())
.wall_time()
.observe(histogram);
let f_fut = f(&stmts, client, &self.collections);
let (epoch_row, res) = future::try_join(epoch_fut, f_fut)
.await
.map_err(TransactionError::Txn)?;
let current_epoch = NonZeroI64::new(epoch_row.get("epoch")).unwrap();
if Some(current_epoch) != self.epoch {
return Err(TransactionError::Epoch(
InternalStashError::Fence(format!(
"unexpected fence epoch {}, expected {:?}",
current_epoch, self.epoch
))
.into(),
));
}
let current_nonce: Vec<u8> = epoch_row.get("nonce");
if current_nonce != self.nonce {
return Err(TransactionError::Epoch(
InternalStashError::Fence("unexpected fence nonce".into()).into(),
));
}
if let Some(counts) = stmts.counts {
event!(
Level::DEBUG,
counts = format!("{:?}", counts.lock().unwrap()),
);
}
let committed_if_version: i64 = epoch_row.get("version");
// We can't use the failpoint macro here because we need to move `res`
// into the error return, but because `res` is generic and a T, we can't
// create one. Calling `res.clone()` would require `T: Clone` which
// forces `Data` to have `Clone` which we maybe don't want (unclear).
// Thus, use the hidden function that the macro calls.
// Have both a pre and post commit failpoint to simulate each kind of
// error.
if let Some(_) = fail::eval("stash_commit_pre", |_| "") {
return Err(TransactionError::Commit {
committed_if_version,
result: res,
});
}
if let Err(_) = batch_execute(client, tx_end).await {
return Err(TransactionError::Commit {
committed_if_version,
result: res,
});
}
if let Some(_) = fail::eval("stash_commit_post", |_| "") {
return Err(TransactionError::Commit {
committed_if_version,
result: res,
});
}
Ok(res)
}
/// Reports whether a COMMIT that returned an error actually succeeded. An
/// Err return from this function is retryable normally (if
/// `!err.is_unrecoverable()`).
#[mz_ore::instrument(name = "stash::determine_commit", level = "debug")]
async fn determine_commit(&mut self, committed_if_version: i64) -> Result<bool, StashError> {
// Always reconnect.
self.connect(None).await?;
let client = self.client.as_mut().unwrap();
let row = client
.query_one("SELECT epoch, nonce, version FROM fence", &[])
.await?;
// TODO: figure out if version should be non zero or not. Probably not?
let epoch = NonZeroI64::new(row.get("epoch")).unwrap();
let nonce: Vec<u8> = row.get("nonce");
let version: i64 = row.get("version");
if Some(epoch) != self.epoch || nonce != self.nonce {
return Err(InternalStashError::Fence("unexpected epoch or nonce".into()).into());
}
Ok(version == committed_if_version)
}
}
enum TransactionError<T> {
/// A failure occurred pre-transaction.
Connect(StashError),
/// The epoch check failed.
Epoch(StashError),
/// The transaction function failed and the commit was never started.
Txn(StashError),
/// The commit was started and failed but may have been committed. This is
/// an indeterminate error.
Commit {
// If the version field (in a new transaction) is this value, then the
// COMMIT succeeded, otherwise it failed.
committed_if_version: i64,
result: T,
},
}
impl<T> std::fmt::Display for TransactionError<T> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
TransactionError::Connect(err)
| TransactionError::Epoch(err)
| TransactionError::Txn(err) => write!(f, "{err}"),
TransactionError::Commit {
committed_if_version,
..
} => write!(
f,
"TransactionError::Commit{{ committed_if_version: {committed_if_version} }}"
),
}
}
}
impl<T> TransactionError<T> {
fn pgerr(&self) -> Option<&tokio_postgres::Error> {
match self {
TransactionError::Connect(err)
| TransactionError::Epoch(err)
| TransactionError::Txn(err) => {
if let InternalStashError::Postgres(err) = &err.inner {
Some(err)
} else {
None
}
}
TransactionError::Commit { .. } => None,
}
}
fn code(&self) -> Option<&SqlState> {
self.pgerr().and_then(|err| err.code())
}
fn is_closed(&self) -> bool {
match self.pgerr() {
Some(err) => err.is_closed(),
None => false,
}
}
fn cause(&self) -> &str {
if self.is_closed() {
"closed"
} else if let Some(&SqlState::T_R_SERIALIZATION_FAILURE) = self.code() {
"retry"
} else {
"other"
}
}
/// Reports whether this error can safely be retried.
fn retryable(&self) -> bool {
// Only attempt to retry postgres-related errors. Others come from stash
// code and can't be retried.
if self.pgerr().is_none() {
return false;
}
// Check some known permanent failure codes.
if matches!(
self.code(),
Some(&SqlState::UNDEFINED_TABLE)
| Some(&SqlState::WRONG_OBJECT_TYPE)
| Some(&SqlState::READ_ONLY_SQL_TRANSACTION)
// Cockroach reports errors from sql.conn.max_read_buffer_message_size as this (as
// well as others).
| Some(&SqlState::PROTOCOL_VIOLATION)
) {
return false;
}
match self {
// Always retry if the initial connection failed.
TransactionError::Connect(_) => true,
// Never retry if the epoch check failed.
TransactionError::Epoch(_) => false,
// Retry inner transaction failures.
TransactionError::Txn(_) => true,
TransactionError::Commit { .. } => {
// If the failure occurred during the commit attempt, only retry
// if we got an explicit code from the database notifying us
// that this is possible. A connection error or perhaps any
// other error could have left the stash in an unknown state.
// Until we are idempotent or able to recover from this, our
// only choice is to issue a fatal failure, forcing the caller
// to restart its process and reinitialize its memory from fully
// reading the stash.
matches!(self.code(), Some(&SqlState::T_R_SERIALIZATION_FAILURE))
}
}
}
}
impl Stash {
/// Returns a mapping from stash collection Id to stash collection name.
pub async fn collections(&mut self) -> Result<BTreeMap<Id, String>, StashError> {
self.with_transaction(move |tx| Box::pin(async move { tx.collections().await }))
.await
}
/// Returns Ok if the stash is the current leader and an error otherwise.
///
/// Note: This can be optimized to not increment the version, which is done automatically via
/// `with_commit`. It will probably be more efficient to retry an in-determinate read-only
/// transaction than relying on incrementing the version.
pub async fn confirm_leadership(&mut self) -> Result<(), StashError> {
self.with_transaction(|_| Box::pin(async { Ok(()) })).await
}
pub fn is_writeable(&self) -> bool {
matches!(self.txn_mode, TransactionMode::Writeable)
}
pub fn is_readonly(&self) -> bool {
matches!(self.txn_mode, TransactionMode::Readonly)
}
pub fn is_savepoint(&self) -> bool {
matches!(self.txn_mode, TransactionMode::Savepoint)
}
pub fn epoch(&self) -> Option<NonZeroI64> {
self.epoch
}
}
/// The Consolidator receives since advancements on a channel and
/// transactionally consolidates them. These can safely be done at a later time
/// in a separate connection that doesn't do leader or epoch checking because 1)
/// having data that needs to be consolidated is not a correctness error and 2)
/// the operations here are idempotent (can safely be run concurrently with a
/// second stash).
struct Consolidator {
config: Arc<tokio::sync::Mutex<Config>>,
tls: MakeTlsConnector,
schema: Option<String>,
sinces_rx: mpsc::UnboundedReceiver<ConsolidateRequest>,
consolidations: BTreeMap<Id, (Antichain<Timestamp>, Vec<oneshot::Sender<()>>)>,
client: Option<Client>,
reconnect: Interval,
stmt_candidates: Option<Statement>,
stmt_insert: Option<Statement>,
stmt_delete: Option<Statement>,
}
impl Consolidator {
fn start(
config: Arc<tokio::sync::Mutex<Config>>,
schema: Option<String>,
tls: MakeTlsConnector,
sinces_rx: mpsc::UnboundedReceiver<ConsolidateRequest>,
) {
let cons = Self {
config,
schema,
tls,
sinces_rx,
client: None,
reconnect: tokio::time::interval(RECONNECT_INTERVAL),
stmt_candidates: None,
stmt_insert: None,
stmt_delete: None,
consolidations: BTreeMap::new(),
};
cons.spawn();
}
fn spawn(mut self) {
// Do consolidation automatically, in a separate connection, and only
// for things that might benefit from it (have had a negative diff
// applied).
mz_ore::task::spawn(|| "stash consolidation", async move {
// Wait for the next consolidation request.
while let Some(req) = self.sinces_rx.recv().await {
self.insert(req);
if self.reconnect.tick().now_or_never().is_some() {
self.client = None;
}
while !self.consolidations.is_empty() {
// Accumulate any pending requests that have come in during
// our work so we can attempt to get the most recent since
// for a quickly advancing collection.
while let Ok(req) = self.sinces_rx.try_recv() {
self.insert(req);
}
// Pick a key to consolidate.
let id = *self.consolidations.keys().next().expect("must exist");
let (ts, done) = self.consolidations.remove(&id).expect("must exist");
// Duplicate the loop-retry-connect structure as in the
// transact function by forcing reconnects anytime an error
// occurs.
let retry = Retry::default()
.clamp_backoff(Duration::from_secs(1))
.into_retry_stream();
let mut retry = Box::pin(retry);
let mut attempt: u64 = 0;
loop {
match self.consolidate(id, &ts, attempt).await {
Ok(()) => break,
Err(e) => {
attempt += 1;
debug!("tokio-postgres stash consolidation error, retry attempt {attempt}: {e}");
self.client = None;
retry.next().await;
}
}
}
// Once consolidation is complete, notify any waiters.
for ch in done {
// Not a correctness error if a waiter has gone away.
let _ = ch.send(());
}
}
}
});
}
// Update the set of pending consolidations to the most recent since
// we've received for a collection.
fn insert(&mut self, req: ConsolidateRequest) {
let entry = self
.consolidations
.entry(req.id)
.and_modify(|e| e.0.join_assign(&req.since))
.or_insert((req.since, Vec::new()));
entry.1.extend(req.done);
}
#[mz_ore::instrument(level = "trace")]
async fn consolidate(
&mut self,
id: Id,
since: &Antichain<Timestamp>,
attempt: u64,
) -> Result<(), StashError> {
const HIGH_PRIORITY_ATTEMPT_THRESHOLD: u64 = 5;
if self.client.is_none() {
self.connect().await?;
}
let client = self.client.as_mut().unwrap();
let tx = client.transaction().await?;
// If the consolidator has failed to consolidate enough times, elevate our transaction
// priority to high. Otherwise we can get into a state where the consolidator is never able
// to finish consolidating and the stash grows without bound.
if attempt >= HIGH_PRIORITY_ATTEMPT_THRESHOLD {
tx.batch_execute("SET TRANSACTION PRIORITY HIGH;").await?;
}
let deleted = match since.borrow().as_option() {
Some(since) => {
// In a single query we can detect all candidate entries (things
// with a negative diff) and delete and return all associated
// keys.
let mut rows = tx
.query(self.stmt_candidates.as_ref().unwrap(), &[&id, since])
.await?
.into_iter()
.map(|row| {
(
(row.get::<_, Vec<u8>>("key"), row.get::<_, Vec<u8>>("value")),
row.get::<_, Diff>("diff"),
)
})
.collect::<Vec<_>>();
let deleted = rows.len();
// Perform the consolidation in Rust.
differential_dataflow::consolidation::consolidate(&mut rows);
// Then for any items that have a positive diff, INSERT them
// back into the database. Our current production stash usage
// will never have any results here (all consolidations sum to
// 0), only tests will. Thus, it's probably faster to perform
// consolidations in Rust instead of SQL because (unverified
// assumption) it's faster to return all the rows and use
// differential's consolidation method. So far we have not
// produced a benchmark that can accurately verify these claims.
// The benchmarks we have thus far are either not this workload
// or else vary wildly when the exact same benchmark is run
// repeatedly.
for ((key, value), diff) in rows {
tx.execute(
self.stmt_insert.as_ref().unwrap(),
&[&id, &key, &value, since, &diff],
)
.await?;
}
mz_ore::cast::usize_to_u64(deleted)
}
None => {
// The since is empty, so we can delete all the associated data.
tx.execute(self.stmt_delete.as_ref().unwrap(), &[&id])
.await?
}
};
tx.commit().await?;
event!(Level::DEBUG, deleted);
Ok(())
}
async fn connect(&mut self) -> Result<(), StashError> {
let (client, connection) = self.config.lock().await.connect(self.tls.clone()).await?;
mz_ore::task::spawn(
|| "tokio-postgres stash consolidation connection",
async move {
if let Err(e) = connection.await {
tracing::warn!("postgres stash connection error: {}", e);
}
},
);
// `self.config` is shared with the Stash, so we update the application name in the
// session instead of the `self.config`.
client
.batch_execute("SET application_name = 'stash-consolidator'; SET default_transaction_priority = 'low';")
.await?;
if let Some(schema) = &self.schema {
client
.execute(format!("SET search_path TO {schema}").as_str(), &[])
.await?;
}
self.stmt_candidates = Some(
client
.prepare(
"
DELETE FROM data
WHERE collection_id = $1 AND time <= $2 AND key IN (
SELECT key
FROM data
WHERE collection_id = $1 AND time <= $2 AND diff < 0
)
RETURNING key, value, diff
",
)
.await?,
);
self.stmt_insert = Some(
client
.prepare(
"INSERT INTO data (collection_id, key, value, time, diff)
VALUES ($1, $2, $3, $4, $5)",
)
.await?,
);
self.stmt_delete = Some(
client
.prepare("DELETE FROM data WHERE collection_id = $1")
.await?,
);
self.client = Some(client);
Ok(())
}
}
/// Stash factory to use for tests that uses a random schema for a stash, which is re-used on all
/// stash openings. The schema is dropped when this factory is dropped.
#[derive(Derivative)]
#[derivative(Debug)]
pub struct DebugStashFactory {
url: String,
schema: String,
#[derivative(Debug = "ignore")]
tls: MakeTlsConnector,
stash_factory: StashFactory,
dropped: bool,
}
impl DebugStashFactory {
/// Returns a new factory that will generate a random schema one time, then use it on any
/// opened Stash.
///
/// IMPORTANT: Call [`Self::drop`] when you are done to clean up leftover state in CRDB.
pub async fn try_new() -> Result<DebugStashFactory, StashError> {
let url =
std::env::var("COCKROACH_URL").expect("COCKROACH_URL environment variable is not set");
let rng: usize = rand::thread_rng().gen();
let schema = format!("schema_{rng}");
let tls = mz_tls_util::make_tls(&tokio_postgres::Config::new()).unwrap();
let (client, connection) = tokio_postgres::connect(&url, tls.clone()).await?;
mz_ore::task::spawn(|| "tokio-postgres stash connection", async move {
if let Err(e) = connection.await {
tracing::warn!("postgres stash connection error: {e}");
}
});
client
.batch_execute(&format!("CREATE SCHEMA {schema}"))
.await?;
let stash_factory = StashFactory::new(&MetricsRegistry::new());
Ok(DebugStashFactory {
url,
schema,
tls,
stash_factory,
dropped: false,
})
}
/// Returns a new factory that will generate a random schema one time, then use it on any
/// opened Stash.
///
/// IMPORTANT: Call [`Self::drop`] when you are done to clean up leftover state in CRDB.
///
/// # Panics
/// Panics if it is unable to create a new factory.
pub async fn new() -> DebugStashFactory {
DebugStashFactory::try_new()
.await
.expect("unable to create debug stash factory")
}
async fn try_open_inner(&self, mode: TransactionMode) -> Result<Stash, StashError> {
debug!("debug stash open: {mode:?}, {}", self.schema);
self.stash_factory
.open_inner(
mode,
self.url.clone(),
Some(self.schema.clone()),
self.tls.clone(),
None,
)
.await
}
/// Returns a new Stash.
pub async fn try_open(&self) -> Result<Stash, StashError> {
self.try_open_inner(TransactionMode::Writeable).await
}
/// Returns the factory's Stash.
///
/// # Panics
/// Panics if it is unable to create a new stash.
pub async fn open(&self) -> Stash {
self.try_open().await.expect("unable to open debug stash")
}
/// Returns the factory's Stash in readonly mode.
///
/// # Panics
/// Panics if it is unable to create a new stash.
pub async fn open_readonly(&self) -> Stash {
self.try_open_inner(TransactionMode::Readonly)
.await
.expect("unable to open debug stash")
}
/// Returns the factory's Stash in savepoint mode.
///
/// # Panics
/// Panics if it is unable to create a new stash.
pub async fn open_savepoint(&self) -> Stash {
self.try_open_inner(TransactionMode::Savepoint)
.await
.expect("unable to open debug stash")
}
/// Best effort clean up of testing state in CRDB, any error is ignored.
pub async fn drop(mut self) {
let Ok((client, connection)) = tokio_postgres::connect(&self.url, self.tls.clone()).await
else {
return;
};
mz_ore::task::spawn(|| "tokio-postgres stash connection", async move {
let _ = connection.await;
});
let _ = client
.batch_execute(&format!("DROP SCHEMA {} CASCADE", &self.schema))
.await;
self.dropped = true;
}
pub fn url(&self) -> &str {
&self.url
}
pub fn schema(&self) -> &str {
&self.schema
}
pub fn tls(&self) -> &MakeTlsConnector {
&self.tls
}
pub fn stash_factory(&self) -> &StashFactory {
&self.stash_factory
}
}
impl Drop for DebugStashFactory {
fn drop(&mut self) {
let message =
"You forgot to call `drop()` on a `DebugStashFactory` before dropping it! You \
may also see this if a test panicked before calling `drop()`.";
if !self.dropped {
// Don't double panic so we keep the stack trace relatively small.
if std::thread::panicking() {
tracing::error!("{message}");
} else {
panic!("{message}");
}
}
}
}