mz_compute_types/plan/

lowering.rs

// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

//! Lowering [`DataflowDescription`]s from MIR ([`MirRelationExpr`]) to LIR ([`Plan`]).

use std::collections::{BTreeMap, BTreeSet};

use columnar::Len;
use itertools::Itertools;
use mz_expr::JoinImplementation::{DeltaQuery, Differential, IndexedFilter, Unimplemented};
use mz_expr::{
    AggregateExpr, Columns, Id, JoinInputMapper, MapFilterProject, MirRelationExpr, MirScalarExpr,
    OptimizedMirRelationExpr, TableFunc, permutation_for_arrangement,
};
use mz_ore::{assert_none, soft_assert_eq_or_log, soft_panic_or_log};
use mz_repr::optimize::OptimizerFeatures;
use mz_repr::{GlobalId, Timestamp};

use crate::dataflows::{BuildDesc, DataflowDescription, IndexImport};
use crate::plan::join::{DeltaJoinPlan, JoinPlan, LinearJoinPlan};
use crate::plan::reduce::{KeyValPlan, ReducePlan};
use crate::plan::threshold::ThresholdPlan;
use crate::plan::top_k::TopKPlan;
use crate::plan::{ArrangementStrategy, AvailableCollections, GetPlan, LirId, Plan, PlanNode};

/// Pick an [`ArrangementStrategy`] based on whether the input may contain future-stamped
/// updates. Future updates are the only case where temporal bucketing pays off.
///
/// Any arrangement or consolidation that absorbs data that can have future updates should be
/// guarded by a temporal bucketing operator.
fn strategy_from_future(has_future_updates: bool) -> ArrangementStrategy {
    if has_future_updates {
        ArrangementStrategy::TemporalBucketing
    } else {
        ArrangementStrategy::Direct
    }
}

/// The result of lowering a [`MirRelationExpr`] to a [`Plan`].
struct LoweredExpr {
    /// The lowered plan.
    plan: Plan,
    /// The arrangement keys that the plan is certain to produce.
    keys: AvailableCollections,
    /// Whether the plan's output may contain updates at future timestamps,
    /// e.g., from a temporal MFP using `mz_now()`.
    has_future_updates: bool,
}

pub(super) struct Context {
    /// Known bindings to (possibly arranged) collections.
    arrangements: BTreeMap<Id, AvailableCollections>,
    /// Ids whose collections may contain updates at future timestamps,
    /// e.g., from a temporal MFP using `mz_now()`.
    has_future_updates: BTreeSet<Id>,
    /// Tracks the next available `LirId`.
    next_lir_id: LirId,
    /// Information to print along with error messages.
    debug_info: LirDebugInfo,
    /// Whether to enable fusion of MFPs in reductions.
    enable_reduce_mfp_fusion: bool,
}

impl Context {
    pub fn new(debug_name: String, features: &OptimizerFeatures) -> Self {
        Self {
            arrangements: Default::default(),
            has_future_updates: Default::default(),
            next_lir_id: LirId(1),
            debug_info: LirDebugInfo {
                debug_name,
                id: GlobalId::Transient(0),
            },
            enable_reduce_mfp_fusion: features.enable_reduce_mfp_fusion,
        }
    }

    fn allocate_lir_id(&mut self) -> LirId {
        let id = self.next_lir_id;
        self.next_lir_id = LirId(
            self.next_lir_id
                .0
                .checked_add(1)
                .expect("No LirId overflow"),
        );
        id
    }

    pub fn lower(
        mut self,
        desc: DataflowDescription<OptimizedMirRelationExpr>,
    ) -> Result<DataflowDescription<Plan>, String> {
        // Sources might provide arranged forms of their data, in the future.
        // Indexes provide arranged forms of their data.
        for IndexImport {
            desc: index_desc,
            typ,
            ..
        } in desc.index_imports.values()
        {
            let key = index_desc.key.clone();
            // TODO[btv] - We should be told the permutation by
            // `index_desc`, and it should have been generated
            // at the same point the thinning logic was.
            //
            // We should for sure do that soon, but it requires
            // a bit of a refactor, so for now we just
            // _assume_ that they were both generated by `permutation_for_arrangement`,
            // and recover it here.
            let (permutation, thinning) = permutation_for_arrangement(&key, typ.arity());
            let index_keys = self
                .arrangements
                .entry(Id::Global(index_desc.on_id))
                .or_insert_with(AvailableCollections::default);
            index_keys.arranged.push((key, permutation, thinning));
        }
        for id in desc.source_imports.keys() {
            self.arrangements
                .entry(Id::Global(*id))
                .or_insert_with(AvailableCollections::new_raw);
        }

        // Build each object in order, registering the arrangements it forms.
        let mut objects_to_build = Vec::with_capacity(desc.objects_to_build.len());
        for build in desc.objects_to_build {
            self.debug_info.id = build.id;
            let LoweredExpr {
                plan,
                keys,
                has_future_updates,
            } = self.lower_mir_expr(&build.plan)?;

            self.arrangements.insert(Id::Global(build.id), keys);
            if has_future_updates {
                self.has_future_updates.insert(Id::Global(build.id));
            }
            objects_to_build.push(BuildDesc { id: build.id, plan });
        }

        Ok(DataflowDescription {
            source_imports: desc.source_imports,
            index_imports: desc.index_imports,
            objects_to_build,
            index_exports: desc.index_exports,
            sink_exports: desc.sink_exports,
            as_of: desc.as_of,
            until: desc.until,
            initial_storage_as_of: desc.initial_storage_as_of,
            refresh_schedule: desc.refresh_schedule,
            debug_name: desc.debug_name,
            time_dependence: desc.time_dependence,
        })
    }

    /// This method converts a MirRelationExpr into a plan that can be directly rendered.
    ///
    /// The rough structure is that we repeatedly extract map/filter/project operators
    /// from each expression we see, bundle them up as a `MapFilterProject` object, and
    /// then produce a plan for the combination of that with the next operator.
    ///
    /// The method accesses `self.arrangements`, which it will locally add to and remove from for
    /// `Let` bindings (by the end of the call it should contain the same bindings as when it
    /// started).
    ///
    /// The result of the method is both a `Plan`, but also a list of arrangements that
    /// are certain to be produced, which can be relied on by the next steps in the plan.
    /// Each of the arrangement keys is associated with an MFP that must be applied if that
    /// arrangement is used, to back out the permutation associated with that arrangement.
    ///
    /// An empty list of arrangement keys indicates that only a `Collection` stream can
    /// be assumed to exist.
    fn lower_mir_expr(&mut self, expr: &MirRelationExpr) -> Result<LoweredExpr, String> {
        // This function is recursive and can overflow its stack, so grow it if
        // needed. The growth here is unbounded. Our general solution for this problem
        // is to use [`ore::stack::RecursionGuard`] to additionally limit the stack
        // depth. That however requires upstream error handling. This function is
        // currently called by the Coordinator after calls to `catalog_transact`,
        // and thus are not allowed to fail. Until that allows errors, we choose
        // to allow the unbounded growth here. We are though somewhat protected by
        // higher levels enforcing their own limits on stack depth (in the parser,
        // transformer/desugarer, and planner).
        mz_ore::stack::maybe_grow(|| self.lower_mir_expr_stack_safe(expr))
    }

    fn lower_mir_expr_stack_safe(&mut self, expr: &MirRelationExpr) -> Result<LoweredExpr, String> {
        // Extract a maximally large MapFilterProject from `expr`.
        // We will then try and push this in to the resulting expression.
        //
        // Importantly, `mfp` may contain temporal operators and not be a "safe" MFP.
        // While we would eventually like all plan stages to be able to absorb such
        // general operators, not all of them can.
        let (mut mfp, expr) = MapFilterProject::extract_from_expression(expr);
        // We attempt to plan what we have remaining, in the context of `mfp`.
        // We may not be able to do this, and must wrap some operators with a `Mfp` stage.
        let LoweredExpr {
            mut plan,
            mut keys,
            mut has_future_updates,
        } = match expr {
            // These operators should have been extracted from the expression.
            MirRelationExpr::Map { .. } => {
                panic!("This operator should have been extracted");
            }
            MirRelationExpr::Filter { .. } => {
                panic!("This operator should have been extracted");
            }
            MirRelationExpr::Project { .. } => {
                panic!("This operator should have been extracted");
            }
            // These operators may not have been extracted, and need to result in a `Plan`.
            MirRelationExpr::Constant { rows, typ: _ } => {
                let lir_id = self.allocate_lir_id();
                let node = PlanNode::Constant {
                    rows: rows.clone().map(|rows| {
                        rows.into_iter()
                            .map(|(row, diff)| (row, Timestamp::MIN, diff))
                            .collect()
                    }),
                };
                // The plan, not arranged in any way.
                LoweredExpr {
                    plan: node.as_plan(lir_id),
                    keys: AvailableCollections::new_raw(),
                    has_future_updates: false,
                }
            }
            MirRelationExpr::Get { id, typ: _, .. } => {
                // This stage can absorb arbitrary MFP operators.
                let mut mfp = mfp.take();
                // If `mfp` is the identity, we can surface all imported arrangements.
                // Otherwise, we apply `mfp` and promise no arrangements.
                let mut in_keys = self
                    .arrangements
                    .get(id)
                    .cloned()
                    .unwrap_or_else(AvailableCollections::new_raw);

                // Seek out an arrangement key that might be constrained to a literal.
                // Note: this code has very little use nowadays, as its job was mostly taken over
                // by `LiteralConstraints` (see in the below longer comment).
                let key_val = in_keys
                    .arranged
                    .iter()
                    .filter_map(|key| {
                        mfp.literal_constraints(&key.0)
                            .map(|val| (key.clone(), val))
                    })
                    .max_by_key(|(key, _val)| key.0.len());

                // Determine the plan of action for the `Get` stage.
                let plan = if let Some(((key, permutation, thinning), val)) = &key_val {
                    // This code path used to handle looking up literals from indexes, but it's
                    // mostly deprecated, as this is nowadays performed by the `LiteralConstraints`
                    // MIR transform instead. However, it's still called in a couple of tricky
                    // special cases:
                    // - `LiteralConstraints` handles only Gets of global ids, so this code still
                    //   gets to handle Filters on top of Gets of local ids.
                    // - Lowering does a `MapFilterProject::extract_from_expression`, while
                    //   `LiteralConstraints` does
                    //   `MapFilterProject::extract_non_errors_from_expr_mut`.
                    // - It might happen that new literal constraint optimization opportunities
                    //   appear somewhere near the end of the MIR optimizer after
                    //   `LiteralConstraints` has already run.
                    // (Also note that a similar literal constraint handling machinery is also
                    // present when handling the leftover MFP after this big match.)
                    mfp.permute_fn(|c| permutation[c], thinning.len() + key.len());
                    in_keys.arranged = vec![(key.clone(), permutation.clone(), thinning.clone())];
                    GetPlan::Arrangement(key.clone(), Some(val.clone()), mfp)
                } else if !mfp.is_identity() {
                    // We need to ensure a collection exists, which means we must form it.
                    if let Some((key, permutation, thinning)) =
                        in_keys.arbitrary_arrangement().cloned()
                    {
                        mfp.permute_fn(|c| permutation[c], thinning.len() + key.len());
                        in_keys.arranged = vec![(key.clone(), permutation, thinning)];
                        GetPlan::Arrangement(key, None, mfp)
                    } else {
                        GetPlan::Collection(mfp)
                    }
                } else {
                    // By default, just pass input arrangements through.
                    GetPlan::PassArrangements
                };

                let out_keys = if let GetPlan::PassArrangements = plan {
                    in_keys.clone()
                } else {
                    AvailableCollections::new_raw()
                };

                // Even with a non-temporal MFP, we must propagate `has_future_updates`
                // from the underlying binding — applying an MFP doesn't drop future-
                // timestamped updates that already exist on the input.
                //
                // Note that global Gets from different dataflows can't have future updates, because
                // both indexes and materialized views hold back future updates.
                let has_future_updates = self.has_future_updates.contains(id)
                    || match &plan {
                        GetPlan::Arrangement(_, _, mfp) | GetPlan::Collection(mfp) => {
                            mfp.has_temporal_predicates()
                        }
                        GetPlan::PassArrangements => false,
                    };

                let lir_id = self.allocate_lir_id();
                let node = PlanNode::Get {
                    id: id.clone(),
                    keys: in_keys,
                    plan,
                };
                // Return the plan, and any keys if an identity `mfp`.
                LoweredExpr {
                    plan: node.as_plan(lir_id),
                    keys: out_keys,
                    has_future_updates,
                }
            }
            MirRelationExpr::Let { id, value, body } => {
                // It would be unfortunate to have a non-trivial `mfp` here, as we hope
                // that they would be pushed down. I am not sure if we should take the
                // initiative to push down the `mfp` ourselves.

                // Plan the value using only the initial arrangements, but
                // introduce any resulting arrangements bound to `id`.
                let LoweredExpr {
                    plan: value,
                    keys: v_keys,
                    has_future_updates: v_future,
                } = self.lower_mir_expr(value)?;
                let pre_existing = self.arrangements.insert(Id::Local(*id), v_keys);
                assert_none!(pre_existing);
                if v_future {
                    self.has_future_updates.insert(Id::Local(*id));
                }
                // Plan the body using initial and `value` arrangements,
                // and then remove reference to the value arrangements.
                let LoweredExpr {
                    plan: body,
                    keys: b_keys,
                    has_future_updates: b_future,
                } = self.lower_mir_expr(body)?;
                self.arrangements.remove(&Id::Local(*id));
                self.has_future_updates.remove(&Id::Local(*id));
                // Return the plan, and any `body` arrangements.
                let lir_id = self.allocate_lir_id();
                LoweredExpr {
                    plan: PlanNode::Let {
                        id: id.clone(),
                        value: Box::new(value),
                        body: Box::new(body),
                    }
                    .as_plan(lir_id),
                    keys: b_keys,
                    has_future_updates: b_future,
                }
            }
            MirRelationExpr::LetRec {
                ids,
                values,
                limits,
                body,
            } => {
                assert_eq!(ids.len(), values.len());
                assert_eq!(ids.len(), limits.len());
                // Plan the values using only the available arrangements, but
                // introduce any resulting arrangements bound to each `id`.
                // Arrangements made available cannot be used by prior bindings,
                // as we cannot circulate an arrangement through a `Variable` yet.
                let mut lir_values = Vec::with_capacity(values.len());
                let mut any_v_future = false;
                for (id, value) in ids.iter().zip_eq(values) {
                    let LoweredExpr {
                        plan: mut lir_value,
                        keys: mut v_keys,
                        has_future_updates: v_future,
                    } = self.lower_mir_expr(value)?;
                    any_v_future |= v_future;
                    // If `v_keys` does not contain an unarranged collection, we must form it.
                    if !v_keys.raw {
                        // Choose an "arbitrary" arrangement; TODO: prefer a specific one.
                        let (input_key, permutation, thinning) =
                            v_keys.arbitrary_arrangement().unwrap();
                        let mut input_mfp = MapFilterProject::new(value.arity());
                        input_mfp.permute_fn(|c| permutation[c], thinning.len() + input_key.len());
                        let input_key = Some(input_key.clone());

                        let forms = AvailableCollections::new_raw();

                        // We just want to insert an `ArrangeBy` to form an unarranged collection,
                        // but there is a complication: We shouldn't break the invariant (created by
                        // `NormalizeLets`, and relied upon by the rendering) that there isn't
                        // anything between two `LetRec`s. So if `lir_value` is itself a `LetRec`,
                        // then we insert the `ArrangeBy` on the `body` of the inner `LetRec`,
                        // instead of on top of the inner `LetRec`.
                        //
                        // We forward `v_future` for honesty; bucketing has no observable effect
                        // inside an iterative scope, but the field should reflect reality.
                        lir_value = match lir_value {
                            Plan {
                                node:
                                    PlanNode::LetRec {
                                        ids,
                                        values,
                                        limits,
                                        body,
                                    },
                                lir_id,
                            } => {
                                let inner_lir_id = self.allocate_lir_id();
                                PlanNode::LetRec {
                                    ids,
                                    values,
                                    limits,
                                    body: Box::new(
                                        PlanNode::ArrangeBy {
                                            input_key,
                                            input: body,
                                            input_mfp,
                                            forms,
                                            strategy: strategy_from_future(v_future),
                                        }
                                        .as_plan(inner_lir_id),
                                    ),
                                }
                                .as_plan(lir_id)
                            }
                            lir_value => {
                                let lir_id = self.allocate_lir_id();
                                PlanNode::ArrangeBy {
                                    input_key,
                                    input: Box::new(lir_value),
                                    input_mfp,
                                    forms,
                                    strategy: strategy_from_future(v_future),
                                }
                                .as_plan(lir_id)
                            }
                        };
                        v_keys.raw = true;
                    }
                    let pre_existing = self.arrangements.insert(Id::Local(*id), v_keys);
                    assert_none!(pre_existing);
                    if v_future {
                        self.has_future_updates.insert(Id::Local(*id));
                    }
                    lir_values.push(lir_value);
                }
                // As we exit the iterative scope, we must leave all arrangements behind,
                // as they reference a timestamp coordinate that must be stripped off.
                for id in ids.iter() {
                    self.arrangements
                        .insert(Id::Local(*id), AvailableCollections::new_raw());
                }
                // Plan the body using initial and `value` arrangements,
                // and then remove reference to the value arrangements.
                let LoweredExpr {
                    plan: body,
                    keys: b_keys,
                    has_future_updates: b_future,
                } = self.lower_mir_expr(body)?;
                for id in ids.iter() {
                    self.arrangements.remove(&Id::Local(*id));
                    self.has_future_updates.remove(&Id::Local(*id));
                }
                // Return the plan, and any `body` arrangements.
                //
                // The body's `b_future` alone can under-report: an earlier binding may only
                // inherit `has_future_updates` via a Variable to a *later* binding, which the
                // sequential sweep can't observe at the time the earlier binding is lowered.
                // A precise fix would require a fixpoint (or the MIR `Analysis` framework with
                // a `true ⊑ false` lattice). As a cheap correct alternative, OR with the
                // bindings' future flags: any cross-binding propagation must originate from a
                // local temporal predicate inside *some* binding, so the OR captures it
                // without forcing bucketing on a fully non-temporal LetRec.
                let lir_id = self.allocate_lir_id();
                LoweredExpr {
                    plan: PlanNode::LetRec {
                        ids: ids.clone(),
                        values: lir_values,
                        limits: limits.clone(),
                        body: Box::new(body),
                    }
                    .as_plan(lir_id),
                    keys: b_keys,
                    has_future_updates: b_future || any_v_future,
                }
            }
            MirRelationExpr::FlatMap {
                input: flat_map_input,
                func,
                exprs,
            } => {
                // A `FlatMap UnnestList` that comes after the `Reduce` of a window function can be
                // fused into the lowered `Reduce`.
                //
                // In theory, we could have implemented this also as an MIR transform. However, this
                // is more of a physical optimization, which are sometimes unpleasant to make a part
                // of the MIR pipeline. The specific problem here with putting this into the MIR
                // pipeline would be that we'd need to modify MIR's semantics: MIR's Reduce
                // currently always emits exactly 1 row per group, but the fused Reduce-FlatMap can
                // emit multiple rows per group. Such semantic changes of MIR are very scary, since
                // various parts of the optimizer assume that Reduce emits only 1 row per group, and
                // it would be very hard to hunt down all these parts. (For example, key inference
                // infers the group key as a unique key.)
                let fused_with_reduce = 'fusion: {
                    if !matches!(func, TableFunc::UnnestList { .. }) {
                        break 'fusion None;
                    }
                    // We might have a Project of a single col between the FlatMap and the
                    // Reduce. (It projects away the grouping keys of the Reduce, and keeps the
                    // result of the window function.)
                    let (maybe_reduce, num_grouping_keys) = if let MirRelationExpr::Project {
                        input: project_input,
                        outputs: projection,
                    } = &**flat_map_input
                    {
                        // We want this to be a single column, because we'll want to deal with only
                        // one aggregation in the `Reduce`. (The aggregation of a window function
                        // always stands alone currently: we plan them separately from other
                        // aggregations, and Reduces are never fused. When window functions are
                        // fused with each other, they end up in one aggregation. When there are
                        // multiple window functions in the same SELECT, but can't be fused, they
                        // end up in different Reduces.)
                        if let &[single_col] = &**projection {
                            (project_input, single_col)
                        } else {
                            break 'fusion None;
                        }
                    } else {
                        (flat_map_input, 0)
                    };
                    if let MirRelationExpr::Reduce {
                        input,
                        group_key,
                        aggregates,
                        monotonic,
                        expected_group_size,
                    } = &**maybe_reduce
                    {
                        if group_key.len() != num_grouping_keys
                            || aggregates.len() != 1
                            || !aggregates[0].func.can_fuse_with_unnest_list()
                        {
                            break 'fusion None;
                        }
                        // At the beginning, `non_fused_mfp_above_flat_map` will be the original MFP
                        // above the FlatMap. Later, we'll mutate this to be the residual MFP that
                        // didn't get fused into the `Reduce`.
                        let non_fused_mfp_above_flat_map = &mut mfp;
                        let reduce_output_arity = num_grouping_keys + 1;
                        // We are fusing away the list that the FlatMap would have been unnesting,
                        // so the column that had that list disappears, so we have to permute the
                        // MFP above the FlatMap with this column disappearance.
                        let tweaked_mfp = {
                            let mut mfp = non_fused_mfp_above_flat_map.clone();
                            if mfp.demand().contains(&0) {
                                // I don't think this can happen currently that this MFP would
                                // refer to the list column, because both the list column and the
                                // MFP were constructed by the HIR-to-MIR lowering, so it's not just
                                // some random MFP that we are seeing here. But anyhow, it's better
                                // to check this here for robustness against future code changes.
                                break 'fusion None;
                            }
                            let permutation: BTreeMap<_, _> =
                                (1..mfp.input_arity).map(|col| (col, col - 1)).collect();
                            mfp.permute_fn(|c| permutation[&c], mfp.input_arity - 1);
                            mfp
                        };
                        // We now put together the project that was before the FlatMap, and the
                        // tweaked version of the MFP that was after the FlatMap.
                        // (Part of this MFP might be fused into the Reduce.)
                        let mut project_and_tweaked_mfp = {
                            let mut mfp = MapFilterProject::new(reduce_output_arity);
                            mfp = mfp.project(vec![num_grouping_keys]);
                            mfp = MapFilterProject::compose(mfp, tweaked_mfp);
                            mfp
                        };
                        let fused = self.lower_reduce(
                            input,
                            group_key,
                            aggregates,
                            monotonic,
                            expected_group_size,
                            &mut project_and_tweaked_mfp,
                            true,
                        )?;
                        // Update the residual MFP.
                        *non_fused_mfp_above_flat_map = project_and_tweaked_mfp;
                        Some(fused)
                    } else {
                        break 'fusion None;
                    }
                };
                if let Some(fused_with_reduce) = fused_with_reduce {
                    fused_with_reduce
                } else {
                    // Couldn't fuse it with a `Reduce`, so lower as a normal `FlatMap`.
                    let LoweredExpr {
                        plan: input,
                        keys,
                        has_future_updates: input_future,
                    } = self.lower_mir_expr(flat_map_input)?;
                    // This stage can absorb arbitrary MFP instances.
                    let mut mfp = mfp.take();
                    let mut exprs = exprs.clone();
                    // Prefer the unarranged collection when present: it presents input columns
                    // in logical order, so no permutation is required.
                    let input_key = if keys.raw {
                        None
                    } else if let Some((k, permutation, thinning)) = keys.arbitrary_arrangement() {
                        // Reading from this arrangement exposes input columns in arrangement
                        // order (key columns followed by thinned value columns). We must
                        // permute every reference to an input column accordingly: the
                        // `expr`s feeding the table function arguments, and the `mfp` running
                        // after the table function (which still references input columns at
                        // positions `0..input_arity`).
                        //
                        // The renderer hands the `mfp` the *whole* arranged row and appends the
                        // table-function output after it. The arranged row can be wider than the
                        // logical input row when the key is not a set of distinct columns (an
                        // expression, functional, or repeated-column key carries extra key
                        // values). So the table-function output columns at positions
                        // `input_arity..` must be shifted to land after the arranged row, and the
                        // `mfp`'s new input arity must reflect the arranged width.
                        for expr in &mut exprs {
                            expr.permute(permutation);
                        }
                        let input_arity = permutation.len();
                        let arranged_arity = thinning.len() + k.len();
                        let output_arity = mfp.input_arity - input_arity;
                        mfp.permute_fn(
                            |c| {
                                if c < input_arity {
                                    permutation[c]
                                } else {
                                    arranged_arity + (c - input_arity)
                                }
                            },
                            arranged_arity + output_arity,
                        );
                        Some(k.clone())
                    } else {
                        None
                    };

                    let lir_id = self.allocate_lir_id();
                    // The absorbed `mfp` may contain temporal predicates, which can
                    // introduce future-stamped updates that aren't present on the input.
                    let has_future_updates = input_future || mfp.has_temporal_predicates();
                    // Return the plan, and no arrangements.
                    LoweredExpr {
                        plan: PlanNode::FlatMap {
                            input_key,
                            input: Box::new(input),
                            exprs,
                            func: func.clone(),
                            mfp_after: mfp,
                        }
                        .as_plan(lir_id),
                        keys: AvailableCollections::new_raw(),
                        has_future_updates,
                    }
                }
            }
            MirRelationExpr::Join {
                inputs,
                equivalences,
                implementation,
            } => {
                // Plan each of the join inputs independently.
                // The `plans` get surfaced upwards, and the `input_keys` should
                // be used as part of join planning / to validate the existing
                // plans / to aid in indexed seeding of update streams.
                let mut plans = Vec::new();
                let mut input_keys = Vec::new();
                let mut input_arities = Vec::new();
                let mut input_futures = Vec::new();
                for input in inputs.iter() {
                    let LoweredExpr {
                        plan,
                        keys,
                        has_future_updates: input_future,
                    } = self.lower_mir_expr(input)?;
                    input_arities.push(input.arity());
                    plans.push(plan);
                    input_keys.push(keys);
                    input_futures.push(input_future);
                }
                let any_input_future = input_futures.iter().any(|&f| f);

                let input_mapper =
                    JoinInputMapper::new_from_input_arities(input_arities.iter().copied());

                // Extract temporal predicates as joins cannot currently absorb them.
                let (plan, missing) = match implementation {
                    IndexedFilter(_coll_id, _idx_id, key, _val) => {
                        // Start with the constant input. (This used to be important before database-issues#4016
                        // was fixed.)
                        let start: usize = 1;
                        let order = vec![(0usize, key.clone(), None)];
                        // All columns of the constant input will be part of the arrangement key.
                        let source_arrangement = (
                            (0..key.len())
                                .map(MirScalarExpr::column)
                                .collect::<Vec<_>>(),
                            (0..key.len()).collect::<Vec<_>>(),
                            Vec::<usize>::new(),
                        );
                        let (ljp, missing) = LinearJoinPlan::create_from(
                            start,
                            Some(&source_arrangement),
                            equivalences,
                            &order,
                            input_mapper,
                            &mut mfp,
                            &input_keys,
                        );
                        (JoinPlan::Linear(ljp), missing)
                    }
                    Differential((start, start_arr, _start_characteristic), order) => {
                        let source_arrangement = start_arr.as_ref().and_then(|key| {
                            input_keys[*start]
                                .arranged
                                .iter()
                                .find(|(k, _, _)| k == key)
                                .clone()
                        });
                        let (ljp, missing) = LinearJoinPlan::create_from(
                            *start,
                            source_arrangement,
                            equivalences,
                            order,
                            input_mapper,
                            &mut mfp,
                            &input_keys,
                        );
                        (JoinPlan::Linear(ljp), missing)
                    }
                    DeltaQuery(orders) => {
                        let (djp, missing) = DeltaJoinPlan::create_from(
                            equivalences,
                            orders,
                            input_mapper,
                            &mut mfp,
                            &input_keys,
                        );
                        (JoinPlan::Delta(djp), missing)
                    }
                    // Other plans are errors, and should be reported as such.
                    Unimplemented => return Err("unimplemented join".to_string()),
                };
                // The renderer will expect certain arrangements to exist; if any of those are not available, the join planning functions above should have returned them in
                // `missing`. We thus need to plan them here so they'll exist.
                let is_delta = matches!(plan, JoinPlan::Delta(_));
                for ((((input_plan, input_keys), missing), arity), input_future) in plans
                    .iter_mut()
                    .zip_eq(input_keys.iter())
                    .zip_eq(missing)
                    .zip_eq(input_arities.iter().cloned())
                    .zip_eq(input_futures.iter().copied())
                {
                    if missing != Default::default() {
                        if is_delta {
                            // join_implementation.rs produced a sub-optimal plan here;
                            // we shouldn't plan delta joins at all if not all of the required
                            // arrangements are available. Soft panic in CI and log an error in
                            // production to increase the chances that we will catch all situations
                            // that violate this constraint.
                            soft_panic_or_log!("Arrangements depended on by delta join alarmingly absent: {:?}
Dataflow info: {}
This is not expected to cause incorrect results, but could indicate a performance issue in Materialize.", missing, self.debug_info);
                        } else {
                            soft_panic_or_log!("Arrangements depended on by a non-delta join are absent: {:?}
Dataflow info: {}
This is not expected to cause incorrect results, but could indicate a performance issue in Materialize.", missing, self.debug_info);
                            // Nowadays MIR transforms take care to insert MIR ArrangeBys for each
                            // Join input. (Earlier, they were missing in the following cases:
                            //  - They were const-folded away for constant inputs. This is not
                            //    happening since
                            //    https://github.com/MaterializeInc/materialize/pull/16351
                            //  - They were not being inserted for the constant input of
                            //    `IndexedFilter`s. This was fixed in
                            //    https://github.com/MaterializeInc/materialize/pull/20920
                            //  - They were not being inserted for the first input of Differential
                            //    joins. This was fixed in
                            //    https://github.com/MaterializeInc/materialize/pull/16099)
                        }
                        let lir_id = self.allocate_lir_id();
                        let raw_plan = std::mem::replace(
                            input_plan,
                            PlanNode::Constant {
                                rows: Ok(Vec::new()),
                            }
                            .as_plan(lir_id),
                        );
                        *input_plan =
                            self.arrange_by(raw_plan, missing, input_keys, arity, input_future);
                    }
                }
                // Return the plan, and no arrangements.
                // Both linear and delta join planning extract temporal predicates back into the
                // residual `mfp` (see `LinearJoinPlan::create_from` / `DeltaJoinPlan::create_from`),
                // so the absorbed MFP cannot introduce future updates — the join's output future
                // flag is just the OR of its inputs.
                let lir_id = self.allocate_lir_id();
                LoweredExpr {
                    plan: PlanNode::Join {
                        inputs: plans,
                        plan,
                    }
                    .as_plan(lir_id),
                    keys: AvailableCollections::new_raw(),
                    has_future_updates: any_input_future,
                }
            }
            MirRelationExpr::Reduce {
                input,
                group_key,
                aggregates,
                monotonic,
                expected_group_size,
            } => {
                if aggregates
                    .iter()
                    .any(|agg| agg.func.can_fuse_with_unnest_list())
                {
                    // This case should have been handled at the `MirRelationExpr::FlatMap` case
                    // above. But that has a pretty complicated pattern matching, so it's not
                    // unthinkable that it fails.
                    soft_panic_or_log!(
                        "Window function performance issue: `reduce_unnest_list_fusion` failed"
                    );
                }
                self.lower_reduce(
                    input,
                    group_key,
                    aggregates,
                    monotonic,
                    expected_group_size,
                    &mut mfp,
                    false,
                )?
            }
            MirRelationExpr::TopK {
                input,
                group_key,
                order_key,
                limit,
                offset,
                monotonic,
                expected_group_size,
            } => {
                let arity = input.arity();
                let LoweredExpr {
                    plan: input,
                    keys,
                    has_future_updates: input_future,
                } = self.lower_mir_expr(input)?;

                let top_k_plan = TopKPlan::create_from(
                    group_key.clone(),
                    order_key.clone(),
                    *offset,
                    limit.clone(),
                    arity,
                    *monotonic,
                    *expected_group_size,
                );

                // We don't have an MFP here -- install an operator to permute the
                // input, if necessary.
                let input = if !keys.raw {
                    self.arrange_by(
                        input,
                        AvailableCollections::new_raw(),
                        &keys,
                        arity,
                        // `new_raw` means no arrangement, so no bucketing is needed
                        false,
                    )
                } else {
                    input
                };
                // Return the plan, and no arrangements.
                let temporal_bucketing_strategy = strategy_from_future(input_future);
                let lir_id = self.allocate_lir_id();
                LoweredExpr {
                    plan: PlanNode::TopK {
                        input: Box::new(input),
                        top_k_plan,
                        temporal_bucketing_strategy,
                    }
                    .as_plan(lir_id),
                    keys: AvailableCollections::new_raw(),
                    has_future_updates: false,
                }
            }
            MirRelationExpr::Negate { input } => {
                let arity = input.arity();
                let LoweredExpr {
                    plan: input,
                    keys,
                    has_future_updates: input_future,
                } = self.lower_mir_expr(input)?;

                // We don't have an MFP here -- install an operator to permute the
                // input, if necessary.
                let input = if !keys.raw {
                    self.arrange_by(
                        input,
                        AvailableCollections::new_raw(),
                        &keys,
                        arity,
                        // `new_raw` means no arrangement, so no bucketing is needed
                        false,
                    )
                } else {
                    input
                };
                // Return the plan, and no arrangements.
                let lir_id = self.allocate_lir_id();
                LoweredExpr {
                    plan: PlanNode::Negate {
                        input: Box::new(input),
                    }
                    .as_plan(lir_id),
                    keys: AvailableCollections::new_raw(),
                    has_future_updates: input_future,
                }
            }
            MirRelationExpr::Threshold { input } => {
                let LoweredExpr {
                    plan,
                    keys,
                    has_future_updates: input_future,
                } = self.lower_mir_expr(input)?;
                let arity = input.arity();
                let (threshold_plan, required_arrangement) = ThresholdPlan::create_from(arity);

                let plan = if !keys
                    .arranged
                    .iter()
                    .any(|(key, _, _)| key == &required_arrangement.0)
                {
                    self.arrange_by(
                        plan,
                        AvailableCollections::new_arranged(vec![required_arrangement]),
                        &keys,
                        arity,
                        input_future,
                    )
                } else {
                    plan
                };

                let output_keys = threshold_plan.keys();
                // Return the plan, and any produced keys.
                let lir_id = self.allocate_lir_id();
                LoweredExpr {
                    plan: PlanNode::Threshold {
                        input: Box::new(plan),
                        threshold_plan,
                    }
                    .as_plan(lir_id),
                    keys: output_keys,
                    // Threshold builds its own output arrangement whose
                    // MergeBatcher absorbs future-stamped updates, so no
                    // future updates flow out.
                    has_future_updates: false,
                }
            }
            MirRelationExpr::Union { base, inputs } => {
                let arity = base.arity();
                let mut lowered_inputs = Vec::with_capacity(1 + inputs.len());
                lowered_inputs.push(self.lower_mir_expr(base)?);
                for input in inputs.iter() {
                    lowered_inputs.push(self.lower_mir_expr(input)?);
                }

                // A Union with any `Negate` input should consolidate its
                // output. The lowering is the only place where this decision
                // can be coupled with the per-input bucketing strategy.
                let consolidate_output = lowered_inputs
                    .iter()
                    .any(|l| matches!(l.plan.node, PlanNode::Negate { .. }));

                // Per-input bucketing strategies: only meaningful when the
                // Union consolidates its output, since bucketing only pays off
                // ahead of a downstream consolidator.
                let temporal_bucketing_strategies: Vec<ArrangementStrategy> = if consolidate_output
                {
                    lowered_inputs
                        .iter()
                        .map(|l| strategy_from_future(l.has_future_updates))
                        .collect()
                } else {
                    lowered_inputs
                        .iter()
                        .map(|_| ArrangementStrategy::Direct)
                        .collect()
                };

                let has_future_updates = if consolidate_output {
                    // The MergeBatcher will hold back future updates (regardless of whether we are
                    // bucketing here or not).
                    false
                } else {
                    lowered_inputs.iter().any(|l| l.has_future_updates)
                };

                let plans = lowered_inputs
                    .into_iter()
                    .map(
                        |LoweredExpr {
                             plan,
                             keys,
                             has_future_updates: _,
                         }| {
                            // We don't have an MFP here -- install an operator to permute the
                            // input, if necessary.
                            if !keys.raw {
                                self.arrange_by(
                                    plan,
                                    AvailableCollections::new_raw(),
                                    &keys,
                                    arity,
                                    // `new_raw` means no arrangement, so no bucketing is needed
                                    false,
                                )
                            } else {
                                plan
                            }
                        },
                    )
                    .collect();
                // Return the plan and no arrangements.
                let lir_id = self.allocate_lir_id();
                LoweredExpr {
                    plan: PlanNode::Union {
                        inputs: plans,
                        consolidate_output,
                        temporal_bucketing_strategies,
                    }
                    .as_plan(lir_id),
                    keys: AvailableCollections::new_raw(),
                    has_future_updates,
                }
            }
            MirRelationExpr::ArrangeBy { input, keys } => {
                let input_mir = input;
                let LoweredExpr {
                    plan: input,
                    keys: mut input_keys,
                    has_future_updates: input_has_future_updates,
                } = self.lower_mir_expr(input)?;
                // Fill the `types` in `input_keys` if not already present.
                let arity = input_mir.arity();

                // Determine keys that are not present in `input_keys`.
                let new_keys = keys
                    .iter()
                    .filter(|k1| !input_keys.arranged.iter().any(|(k2, _, _)| k1 == &k2))
                    .cloned()
                    .collect::<Vec<_>>();
                if new_keys.is_empty() {
                    LoweredExpr {
                        plan: input,
                        keys: input_keys,
                        has_future_updates: input_has_future_updates,
                    }
                } else {
                    let mut new_keys = new_keys
                        .iter()
                        .cloned()
                        .map(|k| {
                            let (permutation, thinning) = permutation_for_arrangement(&k, arity);
                            (k, permutation, thinning)
                        })
                        .collect::<Vec<_>>();
                    let forms = AvailableCollections {
                        raw: input_keys.raw,
                        arranged: new_keys.clone(),
                    };
                    let (input_key, input_mfp) = if let Some((input_key, permutation, thinning)) =
                        input_keys.arbitrary_arrangement()
                    {
                        let mut mfp = MapFilterProject::new(arity);
                        mfp.permute_fn(|c| permutation[c], thinning.len() + input_key.len());
                        (Some(input_key.clone()), mfp)
                    } else {
                        (None, MapFilterProject::new(arity))
                    };
                    input_keys.arranged.append(&mut new_keys);
                    input_keys.arranged.sort_by(|k1, k2| k1.0.cmp(&k2.0));

                    // Return the plan and extended keys.
                    let lir_id = self.allocate_lir_id();
                    let strategy = strategy_from_future(input_has_future_updates);
                    assert!(!forms.arranged.is_empty()); // i.e., we do build an arrangement
                    let has_future_updates = false;
                    LoweredExpr {
                        plan: PlanNode::ArrangeBy {
                            input_key,
                            input: Box::new(input),
                            input_mfp,
                            forms,
                            strategy,
                        }
                        .as_plan(lir_id),
                        keys: input_keys,
                        has_future_updates,
                    }
                }
            }
        };

        // If the plan stage did not absorb all linear operators, introduce a new stage to implement them.
        if !mfp.is_identity() {
            // Check if this MFP introduces future updates.
            let mfp_is_temporal = mfp.has_temporal_predicates();
            has_future_updates = has_future_updates || mfp_is_temporal;
            // Seek out an arrangement key that might be constrained to a literal.
            // TODO: Improve key selection heuristic.
            let key_val = keys
                .arranged
                .iter()
                .filter_map(|(key, permutation, thinning)| {
                    let mut mfp = mfp.clone();
                    mfp.permute_fn(|c| permutation[c], thinning.len() + key.len());
                    mfp.literal_constraints(key)
                        .map(|val| (key.clone(), permutation, thinning, val))
                })
                .max_by_key(|(key, _, _, _)| key.len());

            // Input key selection strategy:
            // (1) If we can read a key at a particular value, do so
            // (2) Otherwise, if there is a key that causes the MFP to be the identity, and
            // therefore allows us to avoid discarding the arrangement, use that.
            // (3) Otherwise, if there is _some_ key, use that,
            // (4) Otherwise just read the raw collection.
            let input_key_val = if let Some((key, permutation, thinning, val)) = key_val {
                mfp.permute_fn(|c| permutation[c], thinning.len() + key.len());

                Some((key, Some(val)))
            } else if let Some((key, permutation, thinning)) =
                keys.arranged.iter().find(|(key, permutation, thinning)| {
                    let mut mfp = mfp.clone();
                    mfp.permute_fn(|c| permutation[c], thinning.len() + key.len());
                    mfp.is_identity()
                })
            {
                mfp.permute_fn(|c| permutation[c], thinning.len() + key.len());
                Some((key.clone(), None))
            } else if let Some((key, permutation, thinning)) = keys.arbitrary_arrangement() {
                mfp.permute_fn(|c| permutation[c], thinning.len() + key.len());
                Some((key.clone(), None))
            } else {
                None
            };

            if mfp.is_identity() {
                // We have discovered a key
                // whose permutation causes the MFP to actually
                // be the identity! We can keep it around,
                // but without its permutation this time,
                // and with a trivial thinning of the right length.
                let (key, val) = input_key_val.unwrap();
                let (_old_key, old_permutation, old_thinning) = keys
                    .arranged
                    .iter_mut()
                    .find(|(key2, _, _)| key2 == &key)
                    .unwrap();
                *old_permutation = (0..mfp.input_arity).collect();
                let old_thinned_arity = old_thinning.len();
                *old_thinning = (0..old_thinned_arity).collect();
                // Get rid of all other forms, as this is now the only one known to be valid.
                // TODO[btv] we can probably save the other arrangements too, if we adjust their permutations.
                // This is not hard to do, but leaving it for a quick follow-up to avoid making the present diff too unwieldy.
                keys.arranged.retain(|(key2, _, _)| key2 == &key);
                keys.raw = false;

                // Creating a Plan::Mfp node is now logically unnecessary, but we
                // should do so anyway when `val` is populated, so that
                // the `key_val` optimization gets applied.
                let lir_id = self.allocate_lir_id();
                if val.is_some() {
                    plan = PlanNode::Mfp {
                        input: Box::new(plan),
                        mfp,
                        input_key_val: Some((key, val)),
                    }
                    .as_plan(lir_id)
                }
            } else {
                let lir_id = self.allocate_lir_id();
                plan = PlanNode::Mfp {
                    input: Box::new(plan),
                    mfp,
                    input_key_val,
                }
                .as_plan(lir_id);
                keys = AvailableCollections::new_raw();
            }
        }

        Ok(LoweredExpr {
            plan,
            keys,
            has_future_updates,
        })
    }

    /// Lowers a `Reduce` with the given fields and an `mfp_on_top`, which is the MFP that is
    /// originally on top of the `Reduce`. This MFP, or a part of it, might be fused into the
    /// `Reduce`, in which case `mfp_on_top` is mutated to be the residual MFP, i.e., what was not
    /// fused.
    fn lower_reduce(
        &mut self,
        input: &MirRelationExpr,
        group_key: &Vec<MirScalarExpr>,
        aggregates: &Vec<AggregateExpr>,
        monotonic: &bool,
        expected_group_size: &Option<u64>,
        mfp_on_top: &mut MapFilterProject,
        fused_unnest_list: bool,
    ) -> Result<LoweredExpr, String> {
        let input_arity = input.arity();
        let LoweredExpr {
            plan: input,
            keys,
            has_future_updates: input_future,
        } = self.lower_mir_expr(input)?;
        let (input_key, permutation_and_new_arity) =
            if let Some((input_key, permutation, thinning)) = keys.arbitrary_arrangement() {
                (
                    Some(input_key.clone()),
                    Some((permutation.clone(), thinning.len() + input_key.len())),
                )
            } else {
                (None, None)
            };
        let key_val_plan = KeyValPlan::new(
            input_arity,
            group_key,
            aggregates,
            permutation_and_new_arity,
        );
        let reduce_plan = ReducePlan::create_from(
            aggregates.clone(),
            *monotonic,
            *expected_group_size,
            fused_unnest_list,
        );
        // Return the plan, and the keys it produces.
        let mfp_after;
        let output_arity;
        if self.enable_reduce_mfp_fusion {
            (mfp_after, *mfp_on_top, output_arity) =
                reduce_plan.extract_mfp_after(mfp_on_top.clone(), group_key.len());
        } else {
            (mfp_after, output_arity) = (
                MapFilterProject::new(mfp_on_top.input_arity),
                group_key.len() + aggregates.len(),
            );
        }
        soft_assert_eq_or_log!(
            mfp_on_top.input_arity,
            output_arity,
            "Output arity of reduce must match input arity for MFP on top of it"
        );
        let output_keys = reduce_plan.keys(group_key.len(), output_arity);
        let lir_id = self.allocate_lir_id();
        // `Reduce` builds its own input arrangement inside `render_reduce` (via `KeyValPlan`),
        // bypassing `ensure_collections`. So we can't piggy-back on an upstream `ArrangeBy`'s
        // strategy to request temporal bucketing on a temporal-MFP-fed input: there is no such
        // `ArrangeBy`. Instead we record the strategy directly on the `Reduce` node, and
        // `render_reduce` applies bucketing to the keyed `(key, val)` stream itself.
        let temporal_bucketing_strategy = strategy_from_future(input_future);
        // (This can't currently happen due to `extract_mfp_after` separating out any temporal part.)
        let has_future_updates = mfp_after.has_temporal_predicates();
        Ok(LoweredExpr {
            plan: PlanNode::Reduce {
                input_key,
                input: Box::new(input),
                key_val_plan,
                plan: reduce_plan,
                mfp_after,
                temporal_bucketing_strategy,
            }
            .as_plan(lir_id),
            keys: output_keys,
            has_future_updates,
        })
    }

    /// Replace the plan with another one
    /// that has the collection in some additional forms.
    pub fn arrange_by(
        &mut self,
        plan: Plan,
        collections: AvailableCollections,
        old_collections: &AvailableCollections,
        arity: usize,
        has_future_updates: bool,
    ) -> Plan {
        if let Plan {
            node:
                PlanNode::ArrangeBy {
                    input_key,
                    input,
                    input_mfp,
                    mut forms,
                    strategy,
                },
            lir_id,
        } = plan
        {
            forms.raw |= collections.raw;
            forms.arranged.extend(collections.arranged);
            forms.arranged.sort_by(|k1, k2| k1.0.cmp(&k2.0));
            forms.arranged.dedup_by(|k1, k2| k1.0 == k2.0);
            PlanNode::ArrangeBy {
                input_key,
                input,
                input_mfp,
                forms,
                strategy,
            }
            .as_plan(lir_id)
        } else {
            let (input_key, input_mfp) = if let Some((input_key, permutation, thinning)) =
                old_collections.arbitrary_arrangement()
            {
                let mut mfp = MapFilterProject::new(arity);
                mfp.permute_fn(|c| permutation[c], thinning.len() + input_key.len());
                (Some(input_key.clone()), mfp)
            } else {
                (None, MapFilterProject::new(arity))
            };
            let lir_id = self.allocate_lir_id();

            PlanNode::ArrangeBy {
                input_key,
                input: Box::new(plan),
                input_mfp,
                forms: collections,
                strategy: strategy_from_future(has_future_updates),
            }
            .as_plan(lir_id)
        }
    }
}

/// Various bits of state to print along with error messages during LIR planning,
/// to aid debugging.
#[derive(Clone, Debug)]
pub struct LirDebugInfo {
    debug_name: String,
    id: GlobalId,
}

impl std::fmt::Display for LirDebugInfo {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "Debug name: {}; id: {}", self.debug_name, self.id)
    }
}