mz_compute/

render.rs

// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

//! Renders a plan into a timely/differential dataflow computation.
//!
//! ## Error handling
//!
//! Timely and differential have no idioms for computations that can error. The
//! philosophy is, reasonably, to define the semantics of the computation such
//! that errors are unnecessary: e.g., by using wrap-around semantics for
//! integer overflow.
//!
//! Unfortunately, SQL semantics are not nearly so elegant, and require errors
//! in myriad cases. The classic example is a division by zero, but invalid
//! input for casts, overflowing integer operations, and dozens of other
//! functions need the ability to produce errors ar runtime.
//!
//! At the moment, only *scalar* expression evaluation can fail, so only
//! operators that evaluate scalar expressions can fail. At the time of writing,
//! that includes map, filter, reduce, and join operators. Constants are a bit
//! of a special case: they can be either a constant vector of rows *or* a
//! constant, singular error.
//!
//! The approach taken is to build two parallel trees of computation: one for
//! the rows that have been successfully evaluated (the "oks tree"), and one for
//! the errors that have been generated (the "errs tree"). For example:
//!
//! ```text
//!    oks1  errs1       oks2  errs2
//!      |     |           |     |
//!      |     |           |     |
//!   project  |           |     |
//!      |     |           |     |
//!      |     |           |     |
//!     map    |           |     |
//!      |\    |           |     |
//!      | \   |           |     |
//!      |  \  |           |     |
//!      |   \ |           |     |
//!      |    \|           |     |
//!   project  +           +     +
//!      |     |          /     /
//!      |     |         /     /
//!    join ------------+     /
//!      |     |             /
//!      |     | +----------+
//!      |     |/
//!     oks   errs
//! ```
//!
//! The project operation cannot fail, so errors from errs1 are propagated
//! directly. Map operators are fallible and so can inject additional errors
//! into the stream. Join operators combine the errors from each of their
//! inputs.
//!
//! The semantics of the error stream are minimal. From the perspective of SQL,
//! a dataflow is considered to be in an error state if there is at least one
//! element in the final errs collection. The error value returned to the user
//! is selected arbitrarily; SQL only makes provisions to return one error to
//! the user at a time. There are plans to make the err collection accessible to
//! end users, so they can see all errors at once.
//!
//! To make errors transient, simply ensure that the operator can retract any
//! produced errors when corrected data arrives. To make errors permanent, write
//! the operator such that it never retracts the errors it produced. Future work
//! will likely want to introduce some sort of sort order for errors, so that
//! permanent errors are returned to the user ahead of transient errors—probably
//! by introducing a new error type a la:
//!
//! ```no_run
//! # struct EvalError;
//! # struct SourceError;
//! enum DataflowError {
//!     Transient(EvalError),
//!     Permanent(SourceError),
//! }
//! ```
//!
//! If the error stream is empty, the oks stream must be correct. If the error
//! stream is non-empty, then there are no semantics for the oks stream. This is
//! sufficient to support SQL in its current form, but is likely to be
//! unsatisfactory long term. We suspect that we can continue to imbue the oks
//! stream with semantics if we are very careful in describing what data should
//! and should not be produced upon encountering an error. Roughly speaking, the
//! oks stream could represent the correct result of the computation where all
//! rows that caused an error have been pruned from the stream. There are
//! strange and confusing questions here around foreign keys, though: what if
//! the optimizer proves that a particular key must exist in a collection, but
//! the key gets pruned away because its row participated in a scalar expression
//! evaluation that errored?
//!
//! In the meantime, it is probably wise for operators to keep the oks stream
//! roughly "as correct as possible" even when errors are present in the errs
//! stream. This reduces the amount of recomputation that must be performed
//! if/when the errors are retracted.

use std::any::Any;
use std::cell::RefCell;
use std::collections::{BTreeMap, BTreeSet};
use std::convert::Infallible;
use std::future::Future;
use std::pin::Pin;
use std::rc::{Rc, Weak};
use std::sync::Arc;
use std::task::Poll;

use ::columnar::{Columnar as ColumnarData, Index as ColumnarIndex, Push as ColumnarPush};
use differential_dataflow::dynamic::pointstamp::PointStamp;
use differential_dataflow::lattice::Lattice;
use differential_dataflow::operators::arrange::Arranged;
use differential_dataflow::operators::arrange::ShutdownButton;
use differential_dataflow::operators::iterate::Variable;
use differential_dataflow::trace::cursor::{BatchCursor, BatchDiff, BatchKey, BatchVal};
use differential_dataflow::trace::{BatchReader, Cursor, Navigable, TraceReader};
use differential_dataflow::{AsCollection, Collection, Data, VecCollection};
use futures::FutureExt;
use futures::channel::oneshot;
use itertools::Itertools;
use mz_compute_types::dataflows::{DataflowDescription, IndexDesc};
use mz_compute_types::dyncfgs::{
    COMPUTE_APPLY_COLUMN_DEMANDS, COMPUTE_LOGICAL_BACKPRESSURE_INFLIGHT_SLACK,
    COMPUTE_LOGICAL_BACKPRESSURE_MAX_RETAINED_CAPABILITIES, ENABLE_COMPUTE_LOGICAL_BACKPRESSURE,
    ENABLE_COMPUTE_TEMPORAL_BUCKETING, ENABLE_ERROR_DISTINCT, SUBSCRIBE_SNAPSHOT_OPTIMIZATION,
    TEMPORAL_BUCKETING_SUMMARY,
};
use mz_compute_types::plan::render_plan::{
    self, BindStage, LetBind, LetFreePlan, RecBind, RenderPlan,
};
use mz_compute_types::plan::scalar::LirScalarExpr;
use mz_compute_types::plan::{ArrangementStrategy, LirId};
use mz_expr::{EvalError, Id, LocalId, permutation_for_arrangement};
use mz_persist_client::operators::shard_source::{ErrorHandler, SnapshotMode};
use mz_repr::explain::DummyHumanizer;
use mz_repr::fixed_length::ExtendDatums;
use mz_repr::{Datum, DatumVec, Diff, GlobalId, ReprRelationType, Row, RowArena, SharedRow};
use mz_storage_operators::persist_source;
use mz_storage_types::controller::CollectionMetadata;
use mz_timely_util::columnar::Column;
use mz_timely_util::columnar::builder::ColumnBuilder;
use mz_timely_util::columnation::ColumnationChunker;
use mz_timely_util::operator::StreamExt;
use mz_timely_util::probe::{Handle as MzProbeHandle, ProbeNotify};
use mz_timely_util::scope_label::ScopeExt;
use timely::PartialOrder;
use timely::container::CapacityContainerBuilder;
use timely::dataflow::channels::pact::Pipeline;
use timely::dataflow::operators::core::to_stream::ToStreamBuilder;
use timely::dataflow::operators::vec::Filter;
use timely::dataflow::operators::vec::ToStream;
use timely::dataflow::operators::{Capability, Operator, Probe, probe};
use timely::dataflow::{Scope, Stream, StreamVec};
use timely::order::{Product, TotalOrder};
use timely::progress::timestamp::Refines;
use timely::progress::{Antichain, Timestamp};
use timely::scheduling::ActivateOnDrop;
use timely::worker::Worker as TimelyWorker;

use crate::arrangement::manager::TraceBundle;
use crate::compute_state::ComputeState;
use crate::extensions::arrange::{KeyCollection, MzArrange};
use crate::extensions::reduce::MzReduce;
use crate::extensions::temporal_bucket::TemporalBucketing;
use crate::logging::compute::{
    ComputeEvent, DataflowGlobal, LirMapping, LirMetadata, LogDataflowErrors, OperatorHydration,
};
use crate::render::columnar::{
    ColCollection, RecTimestamp, columnar_consolidate, columnar_leave_dynamic, columnar_negate,
    concat_many, flat_map_datums,
};
use crate::render::context::{ArrangementFlavor, Context};
use crate::render::errors::DataflowErrorSer;
use crate::typedefs::{ErrBatcher, ErrBuilder, ErrSpine, MzTimestamp};
use mz_row_spine::{DatumSeq, RowRowBatcher, RowRowBuilder};
use mz_timely_util::columnar::consolidate::ConsolidatingColumnBuilder;

pub(crate) mod columnar;
pub mod context;
pub(crate) mod errors;
mod flat_map;
mod join;
mod reduce;
pub mod sinks;
mod threshold;
mod top_k;

pub use context::CollectionBundle;
pub use join::LinearJoinSpec;

/// Guard that presses a differential [`ShutdownButton`] when dropped.
///
/// Dropping this guard releases the imported trace's capabilities.
struct PressOnDrop<T>(ShutdownButton<T>);

impl<T> Drop for PressOnDrop<T> {
    fn drop(&mut self) {
        self.0.press();
    }
}

/// Assemble the "compute"  side of a dataflow, i.e. all but the sources.
///
/// This method imports sources from provided assets, and then builds the remaining
/// dataflow using "compute-local" assets like shared arrangements, and producing
/// both arrangements and sinks.
pub fn build_compute_dataflow(
    timely_worker: &mut TimelyWorker,
    compute_state: &mut ComputeState,
    dataflow: DataflowDescription<RenderPlan, CollectionMetadata>,
    start_signal: StartSignal,
    until: Antichain<mz_repr::Timestamp>,
    dataflow_expiration: Antichain<mz_repr::Timestamp>,
) {
    // Mutually recursive view definitions require special handling.
    let recursive = dataflow
        .objects_to_build
        .iter()
        .any(|object| object.plan.is_recursive());

    // Determine indexes to export, and their dependencies.
    let indexes = dataflow
        .index_exports
        .iter()
        .map(|(idx_id, (idx, _typ))| (*idx_id, dataflow.depends_on(idx.on_id), idx.as_lir()))
        .collect::<Vec<_>>();

    // Determine sinks to export, and their dependencies.
    let sinks = dataflow
        .sink_exports
        .iter()
        .map(|(sink_id, sink)| (*sink_id, dataflow.depends_on(sink.from), sink.clone()))
        .collect::<Vec<_>>();

    let worker_logging = timely_worker.logger_for("timely").map(Into::into);
    let apply_demands = COMPUTE_APPLY_COLUMN_DEMANDS.get(&compute_state.worker_config);
    let subscribe_snapshot_optimization =
        SUBSCRIBE_SNAPSHOT_OPTIMIZATION.get(&compute_state.worker_config);

    let name = format!("Dataflow: {}", dataflow.debug_name);
    let input_name = format!("InputRegion: {}", dataflow.debug_name);
    let build_name = format!("BuildRegion: {}", dataflow.debug_name);

    timely_worker.dataflow_core(&name, worker_logging, Box::new(()), |_, scope| {
        let scope = scope.with_label();

        // The scope.clone() occurs to allow import in the region.
        // We build a region here to establish a pattern of a scope inside the dataflow,
        // so that other similar uses (e.g. with iterative scopes) do not require weird
        // alternate type signatures.
        let mut imported_sources = Vec::new();
        let mut tokens: BTreeMap<_, Rc<dyn Any>> = BTreeMap::new();
        let output_probe = MzProbeHandle::default();

        scope.clone().region_named(&input_name, |region| {
            // Import declared sources into the rendering context.
            for (source_id, import) in dataflow.source_imports.iter() {
                region.region_named(&format!("Source({:?})", source_id), |inner| {
                    let mut read_schema = None;
                    let mut mfp = import.desc.arguments.operators.clone().map(|mut ops| {
                        // If enabled, we read from Persist with a `RelationDesc` that
                        // omits uneeded columns.
                        if apply_demands {
                            let demands = ops.demand();
                            let new_desc = import
                                .desc
                                .storage_metadata
                                .relation_desc
                                .apply_demand(&demands);
                            let new_arity = demands.len();
                            let remap: BTreeMap<_, _> = demands
                                .into_iter()
                                .enumerate()
                                .map(|(new, old)| (old, new))
                                .collect();
                            ops.permute_fn(|old_idx| remap[&old_idx], new_arity);
                            read_schema = Some(new_desc);
                        }

                        mz_expr::MfpPlan::create_from(ops)
                            .expect("Linear operators should always be valid")
                    });

                    let snapshot_mode = if import.with_snapshot || !subscribe_snapshot_optimization
                    {
                        SnapshotMode::Include
                    } else {
                        compute_state.metrics.inc_subscribe_snapshot_optimization();
                        SnapshotMode::Exclude
                    };
                    let suppress_early_progress_as_of = dataflow.as_of.clone();

                    // Note: For correctness, we require that sources only emit times advanced by
                    // `dataflow.as_of`. `persist_source` is documented to provide this guarantee.
                    let (mut ok_stream, err_stream, token) = persist_source::persist_source::<
                        DataflowErrorSer,
                        ConsolidatingColumnBuilder<Row, mz_repr::Timestamp, Diff>,
                    >(
                        inner,
                        *source_id,
                        Arc::clone(&compute_state.persist_clients),
                        &compute_state.txns_ctx,
                        import.desc.storage_metadata.clone(),
                        read_schema,
                        dataflow.as_of.clone(),
                        snapshot_mode,
                        until.clone(),
                        mfp.as_mut(),
                        compute_state.dataflow_max_inflight_bytes(),
                        start_signal.clone().into_send_future(),
                        ErrorHandler::Halt("compute_import"),
                    );

                    // If `mfp` is non-identity, we need to apply what remains.
                    // For the moment, assert that it is either trivial or `None`.
                    assert!(mfp.map(|x| x.is_identity()).unwrap_or(true));

                    // To avoid a memory spike during arrangement hydration (database-issues#6368), need to
                    // ensure that the first frontier we report into the dataflow is beyond the
                    // `as_of`.
                    if let Some(as_of) = suppress_early_progress_as_of {
                        ok_stream = suppress_early_progress(ok_stream, as_of);
                    }

                    if ENABLE_COMPUTE_LOGICAL_BACKPRESSURE.get(&compute_state.worker_config) {
                        // Apply logical backpressure to the source.
                        let limit = COMPUTE_LOGICAL_BACKPRESSURE_MAX_RETAINED_CAPABILITIES
                            .get(&compute_state.worker_config);
                        let slack = COMPUTE_LOGICAL_BACKPRESSURE_INFLIGHT_SLACK
                            .get(&compute_state.worker_config)
                            .as_millis()
                            .try_into()
                            .expect("must fit");

                        let stream = ok_stream.limit_progress(
                            output_probe.clone(),
                            slack,
                            limit,
                            import.upper.clone(),
                            name.clone(),
                        );
                        ok_stream = stream;
                    }

                    // Attach a probe reporting the input frontier.
                    let input_probe =
                        compute_state.input_probe_for(*source_id, dataflow.export_ids());
                    ok_stream = ok_stream.probe_with(&input_probe);

                    let (oks, errs) = (
                        ok_stream
                            .as_collection()
                            .leave_region(region)
                            .leave_region(scope),
                        err_stream
                            .as_collection()
                            .leave_region(region)
                            .leave_region(scope),
                    );

                    imported_sources.push((mz_expr::Id::Global(*source_id), (oks, errs)));

                    // Associate returned tokens with the source identifier.
                    tokens.insert(*source_id, Rc::new(token));
                });
            }
        });

        // If there exists a recursive expression, we'll need to use a non-region scope,
        // in order to support additional timestamp coordinates for iteration.
        if recursive {
            scope.clone().iterative::<PointStamp<u64>, _, _>(|region| {
                let mut context = Context::for_dataflow_in(
                    &dataflow,
                    region.clone(),
                    compute_state,
                    until,
                    dataflow_expiration,
                );

                for (id, (oks, errs)) in imported_sources.into_iter() {
                    let bundle = crate::render::CollectionBundle::from_edge(
                        oks.enter(region),
                        errs.enter(region),
                    );
                    // Associate collection bundle with the source identifier.
                    context.insert_id(id, bundle);
                }

                // Import declared indexes into the rendering context.
                for (idx_id, idx) in &dataflow.index_imports {
                    let input_probe = compute_state.input_probe_for(*idx_id, dataflow.export_ids());
                    let snapshot_mode = if idx.with_snapshot || !subscribe_snapshot_optimization {
                        SnapshotMode::Include
                    } else {
                        compute_state.metrics.inc_subscribe_snapshot_optimization();
                        SnapshotMode::Exclude
                    };
                    context.import_index(
                        scope,
                        compute_state,
                        &mut tokens,
                        input_probe,
                        *idx_id,
                        &idx.desc.as_lir(),
                        &idx.typ,
                        snapshot_mode,
                        start_signal.clone(),
                    );
                }

                // Build declared objects.
                for object in dataflow.objects_to_build {
                    let bundle = context.scope.clone().region_named(
                        &format!("BuildingObject({:?})", object.id),
                        |region| {
                            let depends = object.plan.depends();
                            let in_let = object.plan.is_recursive();
                            context
                                .enter_region(region, Some(&depends))
                                .render_recursive_plan(
                                    object.id,
                                    0,
                                    object.plan,
                                    // recursive plans _must_ have bodies in a let
                                    BindingInfo::Body { in_let },
                                )
                                .leave_region(context.scope)
                        },
                    );
                    let global_id = object.id;

                    context.log_dataflow_global_id(
                        *bundle
                            .scope()
                            .addr()
                            .first()
                            .expect("Dataflow root id must exist"),
                        global_id,
                    );
                    context.insert_id(Id::Global(object.id), bundle);
                }

                // Export declared indexes.
                for (idx_id, dependencies, idx) in indexes {
                    context.export_index_iterative(
                        scope,
                        compute_state,
                        &tokens,
                        dependencies,
                        idx_id,
                        &idx,
                        &output_probe,
                    );
                }

                // Export declared sinks.
                for (sink_id, dependencies, sink) in sinks {
                    context.export_sink(
                        compute_state,
                        &tokens,
                        dependencies,
                        sink_id,
                        &sink,
                        start_signal.clone(),
                        &output_probe,
                        scope,
                    );
                }
            });
        } else {
            scope.clone().region_named(&build_name, |region| {
                let mut context = Context::for_dataflow_in(
                    &dataflow,
                    region.clone(),
                    compute_state,
                    until,
                    dataflow_expiration,
                );

                for (id, (oks, errs)) in imported_sources.into_iter() {
                    let bundle = crate::render::CollectionBundle::from_edge(
                        oks.enter_region(region),
                        errs.enter_region(region),
                    );
                    // Associate collection bundle with the source identifier.
                    context.insert_id(id, bundle);
                }

                // Import declared indexes into the rendering context.
                for (idx_id, idx) in &dataflow.index_imports {
                    let input_probe = compute_state.input_probe_for(*idx_id, dataflow.export_ids());
                    let snapshot_mode = if idx.with_snapshot || !subscribe_snapshot_optimization {
                        SnapshotMode::Include
                    } else {
                        compute_state.metrics.inc_subscribe_snapshot_optimization();
                        SnapshotMode::Exclude
                    };
                    context.import_index(
                        scope,
                        compute_state,
                        &mut tokens,
                        input_probe,
                        *idx_id,
                        &idx.desc.as_lir(),
                        &idx.typ,
                        snapshot_mode,
                        start_signal.clone(),
                    );
                }

                // Build declared objects.
                for object in dataflow.objects_to_build {
                    let bundle = context.scope.clone().region_named(
                        &format!("BuildingObject({:?})", object.id),
                        |region| {
                            let depends = object.plan.depends();
                            context
                                .enter_region(region, Some(&depends))
                                .render_plan(object.id, object.plan)
                                .leave_region(context.scope)
                        },
                    );
                    let global_id = object.id;
                    context.log_dataflow_global_id(
                        *bundle
                            .scope()
                            .addr()
                            .first()
                            .expect("Dataflow root id must exist"),
                        global_id,
                    );
                    context.insert_id(Id::Global(object.id), bundle);
                }

                // Export declared indexes.
                for (idx_id, dependencies, idx) in indexes {
                    context.export_index(
                        compute_state,
                        &tokens,
                        dependencies,
                        idx_id,
                        &idx,
                        &output_probe,
                    );
                }

                // Export declared sinks.
                for (sink_id, dependencies, sink) in sinks {
                    context.export_sink(
                        compute_state,
                        &tokens,
                        dependencies,
                        sink_id,
                        &sink,
                        start_signal.clone(),
                        &output_probe,
                        scope,
                    );
                }
            });
        }
    });
}

// This implementation block allows child timestamps to vary from parent timestamps,
// but requires the parent timestamp to be `repr::Timestamp`.
impl<'g, T> Context<'g, T>
where
    T: Refines<mz_repr::Timestamp> + RenderTimestamp,
{
    /// Import the collection from the arrangement, discarding batches from the snapshot.
    /// (This does not guarantee that no records from the snapshot are included; the assumption is
    /// that we'll filter those out later if necessary.)
    fn import_filtered_index_collection<
        'outer,
        Tr: TraceReader<Time = mz_repr::Timestamp, Batch: Navigable> + Clone,
        V: Data,
    >(
        &self,
        arranged: Arranged<'outer, Tr>,
        start_signal: StartSignal,
        mut logic: impl FnMut(BatchKey<'_, Tr>, BatchVal<'_, Tr>) -> V + 'static,
    ) -> VecCollection<'g, T, V, BatchDiff<Tr>>
    where
        // This is implied by the fact that the outer timestamp = mz_repr::Timestamp, but it's essential
        // for our batch-level filtering to be safe, so we document it here regardless.
        mz_repr::Timestamp: TotalOrder,
        BatchCursor<Tr>: Cursor<Time = mz_repr::Timestamp>,
    {
        let oks = arranged.stream.with_start_signal(start_signal).filter({
            let as_of = self.as_of_frontier.clone();
            move |b| !<Antichain<mz_repr::Timestamp> as PartialOrder>::less_equal(b.upper(), &as_of)
        });
        Arranged::<'outer, Tr>::flat_map_batches(oks, move |a, b| [logic(a, b)]).enter(self.scope)
    }

    /// Extracts a filtered index's contents onto the columnar collection edge, discarding
    /// batches that the snapshot covers.
    ///
    /// `logic` packs each `(key, val)` pair into the row buffer it is handed. The buffer is
    /// reused across records and pushed borrowed, so a pair that carries many times costs one
    /// pack rather than an owned [`Row`] per time.
    ///
    /// The `TotalOrder` bound is what makes discarding a batch by its upper safe.
    fn import_filtered_index_edge<'outer, Tr>(
        &self,
        arranged: Arranged<'outer, Tr>,
        start_signal: StartSignal,
        mut logic: impl FnMut(BatchKey<'_, Tr>, BatchVal<'_, Tr>, &mut Row) + 'static,
    ) -> ColCollection<'g, T>
    where
        Tr: TraceReader<Time = mz_repr::Timestamp, Batch: Navigable> + Clone,
        mz_repr::Timestamp: TotalOrder,
        BatchCursor<Tr>: Cursor<Time = mz_repr::Timestamp, Diff = Diff>,
    {
        let as_of = self.as_of_frontier.clone();
        arranged
            .stream
            .with_start_signal(start_signal)
            .unary::<ColumnBuilder<(Row, mz_repr::Timestamp, Diff)>, _, _, _>(
                Pipeline,
                "IndexToColumnar",
                move |_cap, _info| {
                    let mut row_buf = Row::default();
                    move |input, output| {
                        input.for_each(|time, data| {
                            let mut session = output.session_with_builder(&time);
                            for batch in data.iter() {
                                if <Antichain<mz_repr::Timestamp> as PartialOrder>::less_equal(
                                    batch.upper(),
                                    &as_of,
                                ) {
                                    continue;
                                }
                                let mut cursor = batch.cursor();
                                while let Some(key) = cursor.get_key(batch) {
                                    while let Some(val) = cursor.get_val(batch) {
                                        logic(key, val, &mut row_buf);
                                        cursor.map_times(batch, |t, d| {
                                            let t = <BatchCursor<Tr> as Cursor>::owned_time(t);
                                            let d = <BatchCursor<Tr> as Cursor>::owned_diff(d);
                                            session.give((&*row_buf, &t, &d));
                                        });
                                        cursor.step_val(batch);
                                    }
                                    cursor.step_key(batch);
                                }
                            }
                        });
                    }
                },
            )
            .as_collection()
            .enter(self.scope)
    }

    pub(crate) fn import_index<'outer>(
        &mut self,
        outer: Scope<'outer, mz_repr::Timestamp>,
        compute_state: &mut ComputeState,
        tokens: &mut BTreeMap<GlobalId, Rc<dyn std::any::Any>>,
        input_probe: probe::Handle<mz_repr::Timestamp>,
        idx_id: GlobalId,
        idx: &IndexDesc<LirScalarExpr>,
        typ: &ReprRelationType,
        snapshot_mode: SnapshotMode,
        start_signal: StartSignal,
    ) {
        if let Some(traces) = compute_state.traces.get_mut(&idx_id) {
            assert!(
                PartialOrder::less_equal(&traces.compaction_frontier(), &self.as_of_frontier),
                "Index {idx_id} has been allowed to compact beyond the dataflow as_of"
            );

            let token = traces.to_drop().clone();

            let (mut oks, ok_button) = traces.oks_mut().import_frontier_core(
                outer,
                &format!("Index({}, {:?})", idx.on_id, idx.key),
                self.as_of_frontier.clone(),
                self.until.clone(),
            );

            oks.stream = oks.stream.probe_with(&input_probe);

            let (err_arranged, err_button) = traces.errs_mut().import_frontier_core(
                outer,
                &format!("ErrIndex({}, {:?})", idx.on_id, idx.key),
                self.as_of_frontier.clone(),
                self.until.clone(),
            );

            let bundle = match snapshot_mode {
                SnapshotMode::Include => {
                    let ok_arranged = oks
                        .enter(self.scope)
                        .with_start_signal(start_signal.clone());
                    let err_arranged = err_arranged
                        .enter(self.scope)
                        .with_start_signal(start_signal);
                    CollectionBundle::from_expressions(
                        idx.key.clone(),
                        ArrangementFlavor::Trace(idx_id, ok_arranged, err_arranged),
                    )
                }
                SnapshotMode::Exclude => {
                    // When we import an index without a snapshot, we have two balancing considerations:
                    // - It's easy to filter out irrelevant batches from the stream, but hard to filter them out from an arrangement.
                    //   (The `TraceFrontier` wrapper allows us to set an "until" frontier, but not a lower.)
                    // - We do not actually need to reference the arrangement in this dataflow, since all operators that use the arrangement
                    //   (joins, reduces, etc.) also require the snapshot data.
                    // So: when the snapshot is excluded, we import only the (filtered) collection itself and ignore the arrangement.
                    let oks = {
                        let mut datums = DatumVec::new();
                        let (permutation, _thinning) =
                            permutation_for_arrangement(&idx.key, typ.arity());
                        self.import_filtered_index_edge(
                            oks,
                            start_signal.clone(),
                            move |k: DatumSeq, v: DatumSeq, row: &mut Row| {
                                let temp_storage = RowArena::new();
                                let mut datums_borrow = datums.borrow();
                                k.extend_datums(&temp_storage, &mut datums_borrow, None);
                                v.extend_datums(&temp_storage, &mut datums_borrow, None);
                                row.packer()
                                    .extend(permutation.iter().map(|i| datums_borrow[*i]));
                            },
                        )
                    };
                    let errs = self.import_filtered_index_collection(
                        err_arranged,
                        start_signal,
                        |e, _| e.clone(),
                    );
                    CollectionBundle::from_edge(oks, errs)
                }
            };
            self.update_id(Id::Global(idx.on_id), bundle);
            tokens.insert(
                idx_id,
                Rc::new((PressOnDrop(ok_button), PressOnDrop(err_button), token)),
            );
        } else {
            panic!(
                "import of index {} failed while building dataflow {}",
                idx_id, self.dataflow_id
            );
        }
    }
}

// This implementation block requires the scopes have the same timestamp as the trace manager.
// That makes some sense, because we are hoping to deposit an arrangement in the trace manager.
impl<'g> Context<'g, mz_repr::Timestamp> {
    pub(crate) fn export_index(
        &self,
        compute_state: &mut ComputeState,
        tokens: &BTreeMap<GlobalId, Rc<dyn std::any::Any>>,
        dependency_ids: BTreeSet<GlobalId>,
        idx_id: GlobalId,
        idx: &IndexDesc<LirScalarExpr>,
        output_probe: &MzProbeHandle<mz_repr::Timestamp>,
    ) {
        // put together tokens that belong to the export
        let mut needed_tokens = Vec::new();
        for dep_id in dependency_ids {
            if let Some(token) = tokens.get(&dep_id) {
                needed_tokens.push(Rc::clone(token));
            }
        }
        let bundle = self.lookup_id(Id::Global(idx_id)).unwrap_or_else(|| {
            panic!(
                "Arrangement alarmingly absent! id: {:?}",
                Id::Global(idx_id)
            )
        });

        let key = &idx.key;
        match bundle.arrangement(key) {
            Some(ArrangementFlavor::Local(mut oks, mut errs)) => {
                // NOTE: Do not give an exported arrangement a second reader that holds a trace
                // handle, such as a `reduce`. Such a reader pins the shared spine's physical
                // frontier at its own lagging progress, and `ArrangementManager::maintenance` can
                // then no longer advance it, so batches pile up in `Spine::pending`. A cursor is
                // only checked for straddling over pending batches, so an importing dataflow's
                // `cursor_through` eventually panics with `upper` straddles batch. Watching
                // `errs.stream` in `output_probe` does not help, and neither does discarding the
                // reader's output. Stream-level readers like `as_collection` are unaffected. This is
                // why error multiplicity is not collapsed here, leaving multiplicity that crosses
                // an index boundary unbounded. TODO(CPU-209): bound it without a trace reader.

                // Ensure that the frontier does not advance past the expiration time, if set.
                // Otherwise, we might write down incorrect data.
                if let Some(&expiration) = self.dataflow_expiration.as_option() {
                    oks.stream = oks.stream.expire_stream_at(
                        &format!("{}_export_index_oks", self.debug_name),
                        expiration,
                    );
                    errs.stream = errs.stream.expire_stream_at(
                        &format!("{}_export_index_errs", self.debug_name),
                        expiration,
                    );
                }

                oks.stream = oks.stream.probe_notify_with(vec![output_probe.clone()]);

                // Attach logging of dataflow errors.
                if let Some(logger) = compute_state.compute_logger.clone() {
                    errs.stream = errs.stream.log_dataflow_errors(logger, idx_id);
                }

                compute_state.traces.set(
                    idx_id,
                    TraceBundle::new(oks.trace, errs.trace).with_drop(needed_tokens),
                );
            }
            Some(ArrangementFlavor::Trace(gid, _, _)) => {
                // Duplicate of existing arrangement with id `gid`, so
                // just create another handle to that arrangement.
                let trace = compute_state.traces.get(&gid).unwrap().clone();
                compute_state.traces.set(idx_id, trace);
            }
            None => {
                println!("collection available: {:?}", bundle.collection.is_none());
                println!(
                    "keys available: {:?}",
                    bundle.arranged.keys().collect::<Vec<_>>()
                );
                panic!(
                    "Arrangement alarmingly absent! id: {:?}, keys: {:?}",
                    Id::Global(idx_id),
                    key
                );
            }
        };
    }
}

// This implementation block requires the scopes have the same timestamp as the trace manager.
// That makes some sense, because we are hoping to deposit an arrangement in the trace manager.
impl<'g, T> Context<'g, T>
where
    T: RenderTimestamp,
{
    pub(crate) fn export_index_iterative<'outer>(
        &self,
        outer: Scope<'outer, mz_repr::Timestamp>,
        compute_state: &mut ComputeState,
        tokens: &BTreeMap<GlobalId, Rc<dyn std::any::Any>>,
        dependency_ids: BTreeSet<GlobalId>,
        idx_id: GlobalId,
        idx: &IndexDesc<LirScalarExpr>,
        output_probe: &MzProbeHandle<mz_repr::Timestamp>,
    ) {
        // put together tokens that belong to the export
        let mut needed_tokens = Vec::new();
        for dep_id in dependency_ids {
            if let Some(token) = tokens.get(&dep_id) {
                needed_tokens.push(Rc::clone(token));
            }
        }
        let bundle = self.lookup_id(Id::Global(idx_id)).unwrap_or_else(|| {
            panic!(
                "Arrangement alarmingly absent! id: {:?}",
                Id::Global(idx_id)
            )
        });

        let key = &idx.key;
        match bundle.arrangement(key) {
            Some(ArrangementFlavor::Local(oks, errs)) => {
                // TODO: The following as_collection/leave/arrange sequence could be optimized.
                //   * Combine as_collection and leave into a single function.
                //   * Use columnar to extract columns from the batches to implement leave.
                let mut oks = oks
                    .as_collection(|k, v| (k.to_row(), v.to_row()))
                    .leave(outer)
                    .mz_arrange::<
                        ColumnationChunker<_>,
                        RowRowBatcher<_, _>,
                        RowRowBuilder<_, _>,
                        _,
                    >(
                        "Arrange export iterative",
                    );

                let mut errs = errs
                    .as_collection(|k, v| (k.clone(), v.clone()))
                    .leave(outer)
                    .mz_arrange::<ColumnationChunker<_>, ErrBatcher<_, _>, ErrBuilder<_, _>, _>(
                        "Arrange export iterative err",
                    );

                // Ensure that the frontier does not advance past the expiration time, if set.
                // Otherwise, we might write down incorrect data.
                if let Some(&expiration) = self.dataflow_expiration.as_option() {
                    oks.stream = oks.stream.expire_stream_at(
                        &format!("{}_export_index_iterative_oks", self.debug_name),
                        expiration,
                    );
                    errs.stream = errs.stream.expire_stream_at(
                        &format!("{}_export_index_iterative_err", self.debug_name),
                        expiration,
                    );
                }

                oks.stream = oks.stream.probe_notify_with(vec![output_probe.clone()]);

                // Attach logging of dataflow errors.
                if let Some(logger) = compute_state.compute_logger.clone() {
                    errs.stream = errs.stream.log_dataflow_errors(logger, idx_id);
                }

                compute_state.traces.set(
                    idx_id,
                    TraceBundle::new(oks.trace, errs.trace).with_drop(needed_tokens),
                );
            }
            Some(ArrangementFlavor::Trace(gid, _, _)) => {
                // Duplicate of existing arrangement with id `gid`, so
                // just create another handle to that arrangement.
                let trace = compute_state.traces.get(&gid).unwrap().clone();
                compute_state.traces.set(idx_id, trace);
            }
            None => {
                println!("collection available: {:?}", bundle.collection.is_none());
                println!(
                    "keys available: {:?}",
                    bundle.arranged.keys().collect::<Vec<_>>()
                );
                panic!(
                    "Arrangement alarmingly absent! id: {:?}, keys: {:?}",
                    Id::Global(idx_id),
                    key,
                );
            }
        };
    }
}

/// Information about bindings, tracked in `render_recursive_plan` and
/// `render_plan`, to be passed to `render_letfree_plan`.
///
/// `render_letfree_plan` uses these to produce nice output (e.g., `With ...
/// Returning ...`) for local bindings in the `mz_lir_mapping` output.
enum BindingInfo {
    Body { in_let: bool },
    Let { id: LocalId, last: bool },
    LetRec { id: LocalId, last: bool },
}

impl<'scope> Context<'scope, Product<mz_repr::Timestamp, PointStamp<u64>>> {
    /// Renders a plan to a differential dataflow, producing the collection of results.
    ///
    /// This method allows for `plan` to contain [`RecBind`]s, and is planned
    /// in the context of `level` pre-existing iteration coordinates.
    ///
    /// This method recursively descends [`RecBind`] values, establishing nested scopes for each
    /// and establishing the appropriate recursive dependencies among the bound variables.
    /// Once all [`RecBind`]s have been rendered it calls in to `render_plan` which will error if
    /// further [`RecBind`]s are found.
    ///
    /// The method requires that all variables conclude with a physical representation that
    /// contains a collection (i.e. a non-arrangement), and it will panic otherwise.
    fn render_recursive_plan(
        &mut self,
        object_id: GlobalId,
        level: usize,
        plan: RenderPlan,
        binding: BindingInfo,
    ) -> CollectionBundle<'scope, Product<mz_repr::Timestamp, PointStamp<u64>>> {
        for BindStage { lets, recs } in plan.binds {
            // Render the let bindings in order.
            let mut let_iter = lets.into_iter().peekable();
            while let Some(LetBind { id, value }) = let_iter.next() {
                let bundle =
                    self.scope
                        .clone()
                        .region_named(&format!("Binding({:?})", id), |region| {
                            let depends = value.depends();
                            let last = let_iter.peek().is_none();
                            let binding = BindingInfo::Let { id, last };
                            self.enter_region(region, Some(&depends))
                                .render_letfree_plan(object_id, value, binding)
                                .leave_region(self.scope)
                        });
                let bundle = self.distinct_binding_errs(bundle);
                self.insert_id(Id::Local(id), bundle);
            }

            let rec_ids: Vec<_> = recs.iter().map(|r| r.id).collect();

            // A binding's `Variable` serves the `Get`s rendered before the rec
            // loop binds the real value, which are exactly the values of
            // `recs[0..=i]`. A binding no such value reads has no use for a
            // `Variable`-backed bundle, and installing one would build a
            // re-encode that repacks the whole collection once per iteration
            // with nothing to consume it.
            let mut variable_read = BTreeSet::new();
            let mut read_so_far = BTreeSet::new();
            for rec in recs.iter() {
                read_so_far.extend(rec.value.depends());
                if read_so_far.contains(&Id::Local(rec.id)) {
                    variable_read.insert(rec.id);
                }
            }

            // Define variables for rec bindings.
            // It is important that we only use the `Variable` until the object is bound.
            // At that point, all subsequent uses should have access to the object itself.
            let mut variables = BTreeMap::new();
            for id in rec_ids.iter() {
                use differential_dataflow::dynamic::feedback_summary;
                let inner = feedback_summary::<u64>(level + 1, 1);
                let (oks_v, oks_collection) =
                    Variable::new(self.scope, Product::new(Default::default(), inner.clone()));
                let (err_v, err_collection) =
                    Variable::new(self.scope, Product::new(Default::default(), inner));

                if variable_read.contains(id) {
                    self.insert_id(
                        Id::Local(*id),
                        CollectionBundle::from_edge(oks_collection, err_collection),
                    );
                }
                variables.insert(Id::Local(*id), (oks_v, err_v));
            }
            // The bound value is kept so the extraction below reuses it rather than
            // reaching back into a bundle that forward reads have since collapsed.
            let mut bound_oks = BTreeMap::new();
            let mut rec_iter = recs.into_iter().peekable();
            while let Some(RecBind { id, value, limit }) = rec_iter.next() {
                let last = rec_iter.peek().is_none();
                let binding = BindingInfo::LetRec { id, last };
                let bundle = self.render_recursive_plan(object_id, level + 1, value, binding);
                // We need to ensure that the raw collection exists, but do not have enough information
                // here to cause that to happen.
                let (oks, mut err) = bundle.collection.clone().unwrap();
                bound_oks.insert(id, oks.clone());
                // Collapses what forward reads see. `err_v` below feeds reads rendered before this
                // binding and is collapsed separately; without this, a `Get` in a later rec binding
                // or in the body resolves to the bundle stored here and compounds level over level,
                // which is exactly what the collapse prevents for non-recursive bindings.
                let bundle = self.distinct_binding_errs(bundle);
                self.insert_id(Id::Local(id), bundle);
                let (oks_v, err_v) = variables.remove(&Id::Local(id)).unwrap();

                // Set oks variable to `oks` but consolidated to ensure iteration ceases at fixed point.
                let mut oks = columnar_consolidate(oks, "LetRecConsolidation");

                if let Some(limit) = limit {
                    // We swallow the results of the `max_iter`th iteration, because
                    // these results would go into the `max_iter + 1`th iteration.
                    //
                    // The split consults each update's own time. A container's capability
                    // is only a lower bound on the times it carries, so deciding per
                    // container by capability could retain updates from an iteration
                    // beyond the one the capability names.
                    //
                    // The predicate reads the time out of the column into `time`, whose
                    // coordinate vector it reuses across records.
                    let mut time = RecTimestamp::default();
                    let (over_limit, in_limit) = oks
                        .inner
                        .partition_by::<ColumnBuilder<(Row, RecTimestamp, Diff)>, _>(
                            "LetRecLimit",
                            move |(_data, reference, _diff)| {
                                time.copy_from(*reference);
                                // The iteration number, or zero if absent, since trailing zero
                                // coordinates are truncated.
                                let iteration_index = time.inner.get(level).copied().unwrap_or(0);
                                // The pointstamp starts counting from 0, so we need to add 1.
                                iteration_index + 1 >= limit.max_iters.into()
                            },
                        );
                    oks = Collection::new(in_limit);
                    if !limit.return_at_limit {
                        // One error per record that passed the limit, replacing the record.
                        // `flat_map_datums` reads the record without decoding it, and the ok
                        // side stays empty, so the builder it names never ships a container.
                        let (_, over_limit) = flat_map_datums::<
                            _,
                            CapacityContainerBuilder<Vec<(Row, RecTimestamp, Diff)>>,
                            _,
                        >(
                            Collection::new(over_limit),
                            "LetRecLimitExceeded",
                            0,
                            move |_datums, time, diff, _ok_session, err_session| {
                                err_session.give((
                                    DataflowErrorSer::from(EvalError::LetRecLimitExceeded(
                                        format!("{}", limit.max_iters.get()).into(),
                                    )),
                                    time,
                                    diff,
                                ));
                                1
                            },
                        );
                        err = err.concat(over_limit.as_collection());
                    }
                }

                // Set err variable to the distinct elements of `err`.
                // Distinctness is important, as we otherwise might add the same error each iteration,
                // say if the limit of `oks` has an error. This would result in non-terminating rather
                // than a clean report of the error. The trade-off is that we lose information about
                // multiplicities of errors, but .. this seems to be the better call.
                let err: KeyCollection<_, _, _> = err.into();
                let errs = err
                    .mz_arrange::<
                        ColumnationChunker<_>,
                        ErrBatcher<_, _>,
                        ErrBuilder<_, _>,
                        ErrSpine<_, _>,
                    >("Arrange recursive err")
                    .mz_reduce_abelian::<_, ErrBuilder<_, _>, ErrSpine<_, _>, _>(
                        "Distinct recursive err",
                        move |_k, _s, t| t.push(((), Diff::ONE)),
                    )
                    .as_collection(|k, _| k.clone());

                oks_v.set(oks);
                err_v.set(errs);
            }
            // Now extract each of the rec bindings into the outer scope.
            for id in rec_ids.into_iter() {
                let bundle = self.remove_id(Id::Local(id)).unwrap();
                let (_, err) = bundle.collection.unwrap();
                let oks = bound_oks
                    .remove(&id)
                    .expect("rec binding bound while rendering above");
                self.insert_id(
                    Id::Local(id),
                    CollectionBundle::from_edge(
                        columnar_leave_dynamic(oks, level + 1),
                        err.leave_dynamic(level + 1),
                    ),
                );
            }
        }

        self.render_letfree_plan(object_id, plan.body, binding)
    }
}

impl<'scope, T: RenderTimestamp + MaybeBucketByTime> Context<'scope, T> {
    /// Renders a non-recursive plan to a differential dataflow, producing the collection of
    /// results.
    ///
    /// The return type reflects the uncertainty about the data representation, perhaps
    /// as a stream of data, perhaps as an arrangement, perhaps as a stream of batches.
    ///
    /// # Panics
    ///
    /// Panics if the given plan contains any [`RecBind`]s. Recursive plans must be rendered using
    /// `render_recursive_plan` instead.
    fn render_plan(
        &mut self,
        object_id: GlobalId,
        plan: RenderPlan,
    ) -> CollectionBundle<'scope, T> {
        let mut in_let = false;
        for BindStage { lets, recs } in plan.binds {
            assert!(recs.is_empty());

            let mut let_iter = lets.into_iter().peekable();
            while let Some(LetBind { id, value }) = let_iter.next() {
                // if we encounter a single let, the body is in a let
                in_let = true;
                let bundle =
                    self.scope
                        .clone()
                        .region_named(&format!("Binding({:?})", id), |region| {
                            let depends = value.depends();
                            let last = let_iter.peek().is_none();
                            let binding = BindingInfo::Let { id, last };
                            self.enter_region(region, Some(&depends))
                                .render_letfree_plan(object_id, value, binding)
                                .leave_region(self.scope)
                        });
                let bundle = self.distinct_binding_errs(bundle);
                self.insert_id(Id::Local(id), bundle);
            }
        }

        self.scope.clone().region_named("Main Body", |region| {
            let depends = plan.body.depends();
            self.enter_region(region, Some(&depends))
                .render_letfree_plan(object_id, plan.body, BindingInfo::Body { in_let })
                .leave_region(self.scope)
        })
    }

    /// Collapses a binding's error multiplicities.
    ///
    /// Applied to every binding, not only the multiply-read ones. Gating on the reference count
    /// would be a pure optimization, since collapsing a binding one `Get` reads is harmless, and
    /// there is almost nothing to gate: `NormalizeLets` inlines single-use bindings, so the ones
    /// reaching rendering are shared. See [`CollectionBundle::distinct_errs`] for why the collapse
    /// is needed at all, and why a binding's definition is the place for it rather than the
    /// multi-input operators where the duplicate copies happen to meet again.
    fn distinct_binding_errs(
        &self,
        bundle: CollectionBundle<'scope, T>,
    ) -> CollectionBundle<'scope, T> {
        if ENABLE_ERROR_DISTINCT.get(&self.config_set) {
            bundle.distinct_errs()
        } else {
            bundle
        }
    }

    /// Renders a let-free plan to a differential dataflow, producing the collection of results.
    fn render_letfree_plan(
        &self,
        object_id: GlobalId,
        plan: LetFreePlan,
        binding: BindingInfo,
    ) -> CollectionBundle<'scope, T> {
        let (mut nodes, root_id, topological_order) = plan.destruct();

        // Rendered collections by their `LirId`.
        let mut collections = BTreeMap::new();

        // Mappings to send along.
        // To save overhead, we'll only compute mappings when we need to,
        // which means things get gated behind options. Unfortunately, that means we
        // have several `Option<...>` types that are _all_ `Some` or `None` together,
        // but there's no convenient way to express the invariant.
        let should_compute_lir_metadata = self.compute_logger.is_some();
        let mut lir_mapping_metadata = if should_compute_lir_metadata {
            Some(Vec::with_capacity(nodes.len()))
        } else {
            None
        };

        let mut topo_iter = topological_order.into_iter().peekable();
        while let Some(lir_id) = topo_iter.next() {
            let node = nodes.remove(&lir_id).unwrap();

            // TODO(mgree) need ExprHumanizer in DataflowDescription to get nice column names
            // ActiveComputeState can't have a catalog reference, so we'll need to capture the names
            // in some other structure and have that structure impl ExprHumanizer
            let metadata = if should_compute_lir_metadata {
                let operator = node.expr.humanize(&DummyHumanizer);

                // mark the last operator in topo order with any binding decoration
                let operator = if topo_iter.peek().is_none() {
                    match &binding {
                        BindingInfo::Body { in_let: true } => format!("Returning {operator}"),
                        BindingInfo::Body { in_let: false } => operator,
                        BindingInfo::Let { id, last: true } => {
                            format!("With {id} = {operator}")
                        }
                        BindingInfo::Let { id, last: false } => {
                            format!("{id} = {operator}")
                        }
                        BindingInfo::LetRec { id, last: true } => {
                            format!("With Recursive {id} = {operator}")
                        }
                        BindingInfo::LetRec { id, last: false } => {
                            format!("{id} = {operator}")
                        }
                    }
                } else {
                    operator
                };

                let operator_id_start = self.scope.worker().peek_identifier();
                Some((operator, operator_id_start))
            } else {
                None
            };

            let mut bundle = self.render_plan_expr(node.expr, &collections);

            if let Some((operator, operator_id_start)) = metadata {
                let operator_id_end = self.scope.worker().peek_identifier();
                let operator_span = (operator_id_start, operator_id_end);

                if let Some(lir_mapping_metadata) = &mut lir_mapping_metadata {
                    lir_mapping_metadata.push((
                        lir_id,
                        LirMetadata::new(operator, node.parent, node.nesting, operator_span),
                    ))
                }
            }

            self.log_operator_hydration(&mut bundle, lir_id);

            collections.insert(lir_id, bundle);
        }

        if let Some(lir_mapping_metadata) = lir_mapping_metadata {
            self.log_lir_mapping(object_id, lir_mapping_metadata);
        }

        collections
            .remove(&root_id)
            .expect("LetFreePlan invariant (1)")
    }

    /// Renders a [`render_plan::Expr`], producing the collection of results.
    ///
    /// # Panics
    ///
    /// Panics if any of the expr's inputs is not found in `collections`.
    /// Callers must ensure that input nodes have been rendered previously.
    fn render_plan_expr(
        &self,
        expr: render_plan::Expr,
        collections: &BTreeMap<LirId, CollectionBundle<'scope, T>>,
    ) -> CollectionBundle<'scope, T> {
        use render_plan::Expr::*;

        let expect_input = |id| {
            collections
                .get(&id)
                .cloned()
                .unwrap_or_else(|| panic!("missing input collection: {id}"))
        };

        match expr {
            Constant { rows } => {
                // Produce both rows and errs to avoid conditional dataflow construction.
                let (rows, errs) = match rows {
                    Ok(rows) => (rows, Vec::new()),
                    Err(e) => (Vec::new(), vec![e]),
                };

                // We should advance times in constant collections to start from `as_of`.
                let as_of_frontier = self.as_of_frontier.clone();
                let until = self.until.clone();
                // Advancing times to `as_of` can collapse distinct times onto one, so
                // rows the planner left distinct can become duplicates. The
                // `ConsolidatingColumnBuilder` folds those within the batch.
                let ok_collection = rows
                    .into_iter()
                    .filter_map(move |(row, mut time, diff)| {
                        time.advance_by(as_of_frontier.borrow());
                        if !until.less_equal(&time) {
                            Some((
                                row.0,
                                <T as Refines<mz_repr::Timestamp>>::to_inner(time),
                                diff,
                            ))
                        } else {
                            None
                        }
                    })
                    .to_stream_with_builder::<_, ConsolidatingColumnBuilder<Row, T, Diff>>(
                        self.scope,
                    )
                    .as_collection();

                let mut error_time: mz_repr::Timestamp = Timestamp::minimum();
                error_time.advance_by(self.as_of_frontier.borrow());
                let err_collection = errs
                    .into_iter()
                    .map(move |e| {
                        (
                            DataflowErrorSer::from(e),
                            <T as Refines<mz_repr::Timestamp>>::to_inner(error_time),
                            Diff::ONE,
                        )
                    })
                    .to_stream(self.scope)
                    .as_collection();

                CollectionBundle::from_edge(ok_collection, err_collection)
            }
            Get { id, keys, plan } => {
                // Recover the collection from `self` and then apply `mfp` to it.
                // If `mfp` happens to be trivial, we can just return the collection.
                let mut collection = self
                    .lookup_id(id)
                    .unwrap_or_else(|| panic!("Get({:?}) not found at render time", id));
                match plan {
                    mz_compute_types::plan::GetPlan::PassArrangements => {
                        // Assert that each of `keys` are present in `collection`.
                        assert!(
                            keys.arranged
                                .iter()
                                .all(|(key, _, _)| collection.arranged.contains_key(key))
                        );
                        assert!(keys.raw <= collection.collection.is_some());
                        // Retain only those keys we want to import.
                        collection.arranged.retain(|key, _value| {
                            keys.arranged.iter().any(|(key2, _, _)| key2 == key)
                        });
                        collection
                    }
                    mz_compute_types::plan::GetPlan::Arrangement(key, row, mfp) => {
                        let (oks, errs) = collection.as_collection_core(
                            mfp,
                            Some((key, row)),
                            self.until.clone(),
                        );
                        CollectionBundle::from_edge(oks, errs)
                    }
                    mz_compute_types::plan::GetPlan::Collection(mfp) => {
                        let (oks, errs) =
                            collection.as_collection_core(mfp, None, self.until.clone());
                        CollectionBundle::from_edge(oks, errs)
                    }
                }
            }
            Mfp {
                input,
                mfp,
                input_key_val,
            } => {
                let input = expect_input(input);
                // If `mfp` is non-trivial, we should apply it and produce a collection.
                if mfp.is_identity() {
                    input
                } else {
                    let (oks, errs) =
                        input.as_collection_core(mfp, input_key_val, self.until.clone());
                    CollectionBundle::from_edge(oks, errs)
                }
            }
            FlatMap {
                input_key,
                input,
                exprs,
                func,
                mfp_after: mfp,
            } => {
                let input = expect_input(input);
                self.render_flat_map(input_key, input, exprs, func, mfp)
            }
            Join { inputs, plan } => {
                let inputs = inputs.into_iter().map(expect_input).collect();
                match plan {
                    mz_compute_types::plan::join::JoinPlan::Linear(linear_plan) => {
                        self.render_join(inputs, linear_plan)
                    }
                    mz_compute_types::plan::join::JoinPlan::Delta(delta_plan) => {
                        self.render_delta_join(inputs, delta_plan)
                    }
                }
            }
            Reduce {
                input_key,
                input,
                key_val_plan,
                plan,
                mfp_after,
                temporal_bucketing_strategy,
            } => {
                let input = expect_input(input);
                let mfp_option = (!mfp_after.is_identity()).then_some(mfp_after);
                self.render_reduce(
                    input_key,
                    input,
                    key_val_plan,
                    plan,
                    mfp_option,
                    temporal_bucketing_strategy,
                )
            }
            TopK {
                input,
                top_k_plan,
                temporal_bucketing_strategy,
            } => {
                let input = expect_input(input);
                self.render_topk(input, top_k_plan, temporal_bucketing_strategy)
            }
            Negate { input } => {
                let input = expect_input(input);
                let (oks, errs) = input
                    .collection
                    .clone()
                    .expect("Negate input must be an unarranged collection");
                CollectionBundle::from_edge(columnar_negate(oks), errs)
            }
            Threshold {
                input,
                threshold_plan,
            } => {
                let input = expect_input(input);
                self.render_threshold(input, threshold_plan)
            }
            Union {
                inputs,
                consolidate_output,
                temporal_bucketing_strategies,
            } => {
                let mut oks = Vec::new();
                let mut errs = Vec::new();
                for (input, strategy) in inputs.into_iter().zip_eq(temporal_bucketing_strategies) {
                    let (os, es) = expect_input(input)
                        .collection
                        .clone()
                        .expect("Union input must be an unarranged collection");
                    // Apply per-input temporal bucketing. No-op for `Direct`.
                    // Only consolidating Unions carry non-`Direct` strategies;
                    // see the `Union` arm of `lower_mir_expr_stack_safe`.
                    let os = if matches!(strategy, ArrangementStrategy::TemporalBucketing)
                        && ENABLE_COMPUTE_TEMPORAL_BUCKETING.get(&self.config_set)
                    {
                        let summary: mz_repr::Timestamp = TEMPORAL_BUCKETING_SUMMARY
                            .get(&self.config_set)
                            .try_into()
                            .expect("must fit");
                        T::maybe_apply_temporal_bucketing(
                            os.inner,
                            self.as_of_frontier.clone(),
                            summary,
                        )
                    } else {
                        os
                    };
                    oks.push(os);
                    errs.push(es);
                }
                let oks = concat_many(self.scope, oks);
                let oks = if consolidate_output {
                    columnar_consolidate(oks, "UnionConsolidation")
                } else {
                    oks
                };
                let errs = differential_dataflow::collection::concatenate(self.scope, errs);
                CollectionBundle::from_edge(oks, errs)
            }
            ArrangeBy {
                input_key,
                input,
                input_mfp,
                forms: keys,
                strategy,
            } => {
                let input = expect_input(input);
                input.ensure_collections(
                    keys,
                    input_key,
                    input_mfp,
                    self.as_of_frontier.clone(),
                    self.until.clone(),
                    &self.config_set,
                    strategy,
                )
            }
        }
    }

    fn log_dataflow_global_id(&self, dataflow_index: usize, global_id: GlobalId) {
        if let Some(logger) = &self.compute_logger {
            logger.log(&ComputeEvent::DataflowGlobal(DataflowGlobal {
                dataflow_index,
                global_id,
            }));
        }
    }

    fn log_lir_mapping(&self, global_id: GlobalId, mapping: Vec<(LirId, LirMetadata)>) {
        if let Some(logger) = &self.compute_logger {
            logger.log(&ComputeEvent::LirMapping(LirMapping { global_id, mapping }));
        }
    }

    fn log_operator_hydration(&self, bundle: &mut CollectionBundle<'scope, T>, lir_id: LirId) {
        // A `CollectionBundle` can contain more than one collection, which makes it not obvious to
        // which we should attach the logging operator.
        //
        // We could attach to each collection and track the lower bound of output frontiers.
        // However, that would be of limited use because we expect all collections to hydrate at
        // roughly the same time: The `ArrangeBy` operator is not fueled, so as soon as it sees the
        // frontier of the unarranged collection advance, it will perform all work necessary to
        // also advance its own frontier. We don't expect significant delays between frontier
        // advancements of the unarranged and arranged collections, so attaching the logging
        // operator to any one of them should produce accurate results.
        //
        // If the `CollectionBundle` contains both unarranged and arranged representations it is
        // beneficial to attach the logging operator to one of the arranged representation to avoid
        // unnecessary cloning of data. The unarranged collection feeds into the arrangements, so
        // if we attached the logging operator to it, we would introduce a fork in its output
        // stream, which would necessitate that all output data is cloned. In contrast, we can hope
        // that the output streams of the arrangements don't yet feed into anything else, so
        // attaching a (pass-through) logging operator does not introduce a fork.

        match bundle.arranged.values_mut().next() {
            Some(arrangement) => {
                use ArrangementFlavor::*;

                match arrangement {
                    Local(a, _) => {
                        a.stream = self.log_operator_hydration_inner(a.stream.clone(), lir_id);
                    }
                    Trace(_, a, _) => {
                        a.stream = self.log_operator_hydration_inner(a.stream.clone(), lir_id);
                    }
                }
            }
            None => {
                let (oks, _) = bundle
                    .collection
                    .as_mut()
                    .expect("CollectionBundle invariant");
                let stream = self.log_operator_hydration_inner(oks.inner.clone(), lir_id);
                *oks = stream.as_collection();
            }
        }
    }

    fn log_operator_hydration_inner<D>(
        &self,
        stream: Stream<'scope, T, D>,
        lir_id: LirId,
    ) -> Stream<'scope, T, D>
    where
        D: timely::Container + Clone + 'static,
    {
        let Some(logger) = self.compute_logger.clone() else {
            return stream.clone(); // hydration logging disabled
        };

        let export_ids = self.export_ids.clone();

        // Convert the dataflow as-of into a frontier we can compare with input frontiers.
        //
        // We (somewhat arbitrarily) define operators in iterative scopes to be hydrated when their
        // frontier advances to an outer time that's greater than the `as_of`. Comparing
        // `refine(as_of) < input_frontier` would find the moment when the first iteration was
        // complete, which is not what we want. We want `refine(as_of + 1) <= input_frontier`
        // instead.
        let mut hydration_frontier = Antichain::new();
        for time in self.as_of_frontier.iter() {
            if let Some(time) = time.try_step_forward() {
                hydration_frontier.insert(Refines::to_inner(time));
            }
        }

        let name = format!("LogOperatorHydration ({lir_id})");
        stream.unary_frontier(Pipeline, &name, |_cap, _info| {
            let mut hydrated = false;

            for &export_id in &export_ids {
                logger.log(&ComputeEvent::OperatorHydration(OperatorHydration {
                    export_id,
                    lir_id,
                    hydrated,
                }));
            }

            move |(input, frontier), output| {
                // Pass through inputs.
                input.for_each(|cap, data| {
                    output.session(&cap).give_container(data);
                });

                if hydrated {
                    return;
                }

                if PartialOrder::less_equal(&hydration_frontier.borrow(), &frontier.frontier()) {
                    hydrated = true;

                    for &export_id in &export_ids {
                        logger.log(&ComputeEvent::OperatorHydration(OperatorHydration {
                            export_id,
                            lir_id,
                            hydrated,
                        }));
                    }
                }
            }
        })
    }
}

#[allow(dead_code)] // Some of the methods on this trait are unused, but useful to have.
/// A timestamp type that can be used for operations within MZ's dataflow layer.
pub trait RenderTimestamp: MzTimestamp + Default + Refines<mz_repr::Timestamp> {
    /// The system timestamp component of the timestamp.
    ///
    /// This is useful for manipulating the system time, as when delaying
    /// updates for subsequent cancellation, as with monotonic reduction.
    fn system_time(&mut self) -> &mut mz_repr::Timestamp;
    /// Effects a system delay in terms of the timestamp summary.
    fn system_delay(delay: mz_repr::Timestamp) -> <Self as Timestamp>::Summary;
    /// The event timestamp component of the timestamp.
    fn event_time(&self) -> mz_repr::Timestamp;
    /// The event timestamp component of the timestamp, as a mutable reference.
    fn event_time_mut(&mut self) -> &mut mz_repr::Timestamp;
    /// Effects an event delay in terms of the timestamp summary.
    fn event_delay(delay: mz_repr::Timestamp) -> <Self as Timestamp>::Summary;
    /// Steps the timestamp back so that logical compaction to the output will
    /// not conflate `self` with any historical times.
    fn step_back(&self) -> Self;
}

/// Apply temporal bucketing to a stream when the timestamp type supports it.
///
/// Sibling to [`RenderTimestamp`]: bucketing is an arrangement-time concern, not a
/// general property of a render timestamp, so the dispatch lives in its own trait.
/// Total-ordered timestamps perform real bucketing; partially-ordered timestamps
/// (e.g. `Product<…>` in iterative scopes) implement this as a no-op.
pub trait MaybeBucketByTime: Timestamp + ColumnarData {
    /// Buckets a columnar dataflow edge, keeping it columnar.
    fn maybe_apply_temporal_bucketing<'scope, D>(
        stream: Stream<'scope, Self, Column<(D, Self, Diff)>>,
        as_of: Antichain<mz_repr::Timestamp>,
        summary: mz_repr::Timestamp,
    ) -> Collection<'scope, Self, Column<(D, Self, Diff)>>
    where
        D: differential_dataflow::ExchangeData
            + crate::typedefs::MzData
            + differential_dataflow::Hashable
            + ColumnarData,
        for<'a> ::columnar::Ref<'a, D>: Copy + Ord + std::hash::Hash,
        for<'a> ::columnar::Ref<'a, Self>: Copy + Ord,
        for<'a> ::columnar::Ref<'a, Diff>: Ord,
        for<'a> <(D, Self, Diff) as ColumnarData>::Container:
            ColumnarPush<&'a (D, Self, Diff)> + ColumnarPush<::columnar::Ref<'a, (D, Self, Diff)>>;

    /// Buckets a `Vec` stream, keeping it `Vec`.
    ///
    /// For a consumer that re-encodes what it reads, where a `Vec` hands it moved
    /// allocations rather than copied bytes. The reduce key-value path is the one
    /// such caller, since its bucketed output feeds an arrangement.
    fn maybe_apply_temporal_bucketing_vec<'scope, D>(
        stream: StreamVec<'scope, Self, (D, Self, Diff)>,
        as_of: Antichain<mz_repr::Timestamp>,
        summary: mz_repr::Timestamp,
    ) -> VecCollection<'scope, Self, D, Diff>
    where
        D: differential_dataflow::ExchangeData
            + crate::typedefs::MzData
            + differential_dataflow::Hashable
            + ColumnarData,
        for<'a> ::columnar::Ref<'a, D>: Copy + Ord + std::hash::Hash,
        for<'a> ::columnar::Ref<'a, Self>: Copy + Ord,
        for<'a> ::columnar::Ref<'a, Diff>: Ord,
        for<'a> <(D, Self, Diff) as ColumnarData>::Container:
            ColumnarPush<&'a (D, Self, Diff)> + ColumnarPush<::columnar::Ref<'a, (D, Self, Diff)>>;
}

impl RenderTimestamp for mz_repr::Timestamp {
    fn system_time(&mut self) -> &mut mz_repr::Timestamp {
        self
    }
    fn system_delay(delay: mz_repr::Timestamp) -> <Self as Timestamp>::Summary {
        delay
    }
    fn event_time(&self) -> mz_repr::Timestamp {
        *self
    }
    fn event_time_mut(&mut self) -> &mut mz_repr::Timestamp {
        self
    }
    fn event_delay(delay: mz_repr::Timestamp) -> <Self as Timestamp>::Summary {
        delay
    }
    fn step_back(&self) -> Self {
        self.saturating_sub(1)
    }
}

impl MaybeBucketByTime for mz_repr::Timestamp {
    fn maybe_apply_temporal_bucketing<'scope, D>(
        stream: Stream<'scope, Self, Column<(D, Self, Diff)>>,
        as_of: Antichain<mz_repr::Timestamp>,
        summary: mz_repr::Timestamp,
    ) -> Collection<'scope, Self, Column<(D, Self, Diff)>>
    where
        D: differential_dataflow::ExchangeData
            + crate::typedefs::MzData
            + differential_dataflow::Hashable
            + ColumnarData,
        for<'a> ::columnar::Ref<'a, D>: Copy + Ord + std::hash::Hash,
        for<'a> ::columnar::Ref<'a, Self>: Copy + Ord,
        for<'a> ::columnar::Ref<'a, Diff>: Ord,
        for<'a> <(D, Self, Diff) as ColumnarData>::Container:
            ColumnarPush<&'a (D, Self, Diff)> + ColumnarPush<::columnar::Ref<'a, (D, Self, Diff)>>,
    {
        stream.bucket(as_of, summary).as_collection()
    }

    fn maybe_apply_temporal_bucketing_vec<'scope, D>(
        stream: StreamVec<'scope, Self, (D, Self, Diff)>,
        as_of: Antichain<mz_repr::Timestamp>,
        summary: mz_repr::Timestamp,
    ) -> VecCollection<'scope, Self, D, Diff>
    where
        D: differential_dataflow::ExchangeData
            + crate::typedefs::MzData
            + differential_dataflow::Hashable
            + ColumnarData,
        for<'a> ::columnar::Ref<'a, D>: Copy + Ord + std::hash::Hash,
        for<'a> ::columnar::Ref<'a, Self>: Copy + Ord,
        for<'a> ::columnar::Ref<'a, Diff>: Ord,
        for<'a> <(D, Self, Diff) as ColumnarData>::Container:
            ColumnarPush<&'a (D, Self, Diff)> + ColumnarPush<::columnar::Ref<'a, (D, Self, Diff)>>,
    {
        stream.bucket(as_of, summary).as_collection()
    }
}

impl RenderTimestamp for Product<mz_repr::Timestamp, PointStamp<u64>> {
    fn system_time(&mut self) -> &mut mz_repr::Timestamp {
        &mut self.outer
    }
    fn system_delay(delay: mz_repr::Timestamp) -> <Self as Timestamp>::Summary {
        Product::new(delay, Default::default())
    }
    fn event_time(&self) -> mz_repr::Timestamp {
        self.outer
    }
    fn event_time_mut(&mut self) -> &mut mz_repr::Timestamp {
        &mut self.outer
    }
    fn event_delay(delay: mz_repr::Timestamp) -> <Self as Timestamp>::Summary {
        Product::new(delay, Default::default())
    }
    fn step_back(&self) -> Self {
        // It is necessary to step back both coordinates of a product,
        // and when one is a `PointStamp` that also means all coordinates
        // of the pointstamp.
        let inner = self.inner.clone();
        let mut vec = inner.into_inner();
        for item in vec.iter_mut() {
            *item = item.saturating_sub(1);
        }
        Product::new(self.outer.saturating_sub(1), PointStamp::new(vec))
    }
}

impl MaybeBucketByTime for Product<mz_repr::Timestamp, PointStamp<u64>> {
    fn maybe_apply_temporal_bucketing<'scope, D>(
        stream: Stream<'scope, Self, Column<(D, Self, Diff)>>,
        _as_of: Antichain<mz_repr::Timestamp>,
        _summary: mz_repr::Timestamp,
    ) -> Collection<'scope, Self, Column<(D, Self, Diff)>>
    where
        D: differential_dataflow::ExchangeData
            + crate::typedefs::MzData
            + differential_dataflow::Hashable
            + ColumnarData,
        for<'a> ::columnar::Ref<'a, D>: Copy + Ord + std::hash::Hash,
        for<'a> ::columnar::Ref<'a, Self>: Copy + Ord,
        for<'a> ::columnar::Ref<'a, Diff>: Ord,
        for<'a> <(D, Self, Diff) as ColumnarData>::Container:
            ColumnarPush<&'a (D, Self, Diff)> + ColumnarPush<::columnar::Ref<'a, (D, Self, Diff)>>,
    {
        // TODO: Implement bucketing on outer timestamp for iterative scopes.
        stream.as_collection()
    }

    fn maybe_apply_temporal_bucketing_vec<'scope, D>(
        stream: StreamVec<'scope, Self, (D, Self, Diff)>,
        _as_of: Antichain<mz_repr::Timestamp>,
        _summary: mz_repr::Timestamp,
    ) -> VecCollection<'scope, Self, D, Diff>
    where
        D: differential_dataflow::ExchangeData
            + crate::typedefs::MzData
            + differential_dataflow::Hashable
            + ColumnarData,
        for<'a> ::columnar::Ref<'a, D>: Copy + Ord + std::hash::Hash,
        for<'a> ::columnar::Ref<'a, Self>: Copy + Ord,
        for<'a> ::columnar::Ref<'a, Diff>: Ord,
        for<'a> <(D, Self, Diff) as ColumnarData>::Container:
            ColumnarPush<&'a (D, Self, Diff)> + ColumnarPush<::columnar::Ref<'a, (D, Self, Diff)>>,
    {
        // TODO: Implement bucketing on outer timestamp for iterative scopes.
        stream.as_collection()
    }
}

/// A signal that can be awaited by operators to suspend them prior to startup.
///
/// Creating a signal also yields a token, dropping of which causes the signal to fire.
///
/// `StartSignal` is designed to be usable by both async and sync Timely operators.
///
///  * Async operators can simply `await` it.
///  * Sync operators should register an [`ActivateOnDrop`] value via [`StartSignal::drop_on_fire`]
///    and then check `StartSignal::has_fired()` on each activation.
#[derive(Clone)]
pub(crate) struct StartSignal {
    /// A future that completes when the signal fires.
    ///
    /// The inner type is `Infallible` because no data is ever expected on this channel. Instead the
    /// signal is activated by dropping the corresponding `Sender`.
    fut: futures::future::Shared<oneshot::Receiver<Infallible>>,
    /// A weak reference to the token, to register drop-on-fire values.
    token_ref: Weak<RefCell<Box<dyn Any>>>,
}

impl StartSignal {
    /// Create a new `StartSignal` and a corresponding token that activates the signal when
    /// dropped.
    pub fn new() -> (Self, Rc<dyn Any>) {
        let (tx, rx) = oneshot::channel::<Infallible>();
        let token: Rc<RefCell<Box<dyn Any>>> = Rc::new(RefCell::new(Box::new(tx)));
        let signal = Self {
            fut: rx.shared(),
            token_ref: Rc::downgrade(&token),
        };
        (signal, token)
    }

    pub fn has_fired(&self) -> bool {
        self.token_ref.strong_count() == 0
    }

    /// Returns a Send-safe future that completes when the signal fires.
    ///
    /// Unlike `StartSignal` itself, the returned future does not retain a reference to the token,
    /// so it cannot be used for `drop_on_fire` or `has_fired` checks.
    pub fn into_send_future(self) -> impl Future<Output = ()> + Send {
        use futures::FutureExt;
        self.fut.map(|_| ())
    }

    pub fn drop_on_fire(&self, to_drop: Box<dyn Any>) {
        if let Some(token) = self.token_ref.upgrade() {
            let mut token = token.borrow_mut();
            let inner = std::mem::replace(&mut *token, Box::new(()));
            *token = Box::new((inner, to_drop));
        }
    }
}

impl Future for StartSignal {
    type Output = ();

    fn poll(mut self: Pin<&mut Self>, cx: &mut std::task::Context<'_>) -> Poll<Self::Output> {
        self.fut.poll_unpin(cx).map(|_| ())
    }
}

/// Extension trait to attach a `StartSignal` to operator outputs.
pub(crate) trait WithStartSignal {
    /// Delays data and progress updates until the start signal has fired.
    ///
    /// Note that this operator needs to buffer all incoming data, so it has some memory footprint,
    /// depending on the amount and shape of its inputs.
    fn with_start_signal(self, signal: StartSignal) -> Self;
}

impl<'scope, Tr> WithStartSignal for Arranged<'scope, Tr>
where
    Tr: TraceReader<Time: RenderTimestamp> + Clone,
{
    fn with_start_signal(self, signal: StartSignal) -> Self {
        Arranged {
            stream: self.stream.with_start_signal(signal),
            trace: self.trace,
        }
    }
}

impl<'scope, T: Timestamp, D> WithStartSignal for Stream<'scope, T, D>
where
    D: timely::Container + Clone + 'static,
{
    fn with_start_signal(self, signal: StartSignal) -> Self {
        let activations = self.scope().activations();
        self.unary(Pipeline, "StartSignal", |_cap, info| {
            let token = Box::new(ActivateOnDrop::new((), info.address, activations));
            signal.drop_on_fire(token);

            let mut stash = Vec::new();

            move |input, output| {
                // Stash incoming updates as long as the start signal has not fired.
                if !signal.has_fired() {
                    input.for_each(|cap, data| stash.push((cap, std::mem::take(data))));
                    return;
                }

                // Release any data we might still have stashed.
                for (cap, mut data) in std::mem::take(&mut stash) {
                    output.session(&cap).give_container(&mut data);
                }

                // Pass through all remaining input data.
                input.for_each(|cap, data| {
                    output.session(&cap).give_container(data);
                });
            }
        })
    }
}

/// Suppress progress messages for times before the given `as_of`.
///
/// This operator exists specifically to work around a memory spike we'd otherwise see when
/// hydrating arrangements (database-issues#6368). The memory spike happens because when the `arrange_core`
/// operator observes a frontier advancement without data it inserts an empty batch into the spine.
/// When it later inserts the snapshot batch into the spine, an empty batch is already there and
/// the spine initiates a merge of these batches, which requires allocating a new batch the size of
/// the snapshot batch.
///
/// The strategy to avoid the spike is to prevent the insertion of that initial empty batch by
/// ensuring that the first frontier advancement downstream `arrange_core` operators observe is
/// beyond the `as_of`, so the snapshot data has already been collected.
///
/// To ensure this, this operator needs to take two measures:
///  * Keep around a minimum capability until the input announces progress beyond the `as_of`.
///  * Reclock all updates emitted at times not beyond the `as_of` to the minimum time.
///
/// The second measure requires elaboration: If we wouldn't reclock snapshot updates, they might
/// still be upstream of `arrange_core` operators when those get to know about us dropping the
/// minimum capability. The in-flight snapshot updates would hold back the input frontiers of
/// `arrange_core` operators to the `as_of`, which would cause them to insert empty batches.
fn suppress_early_progress<'scope, T: Timestamp, D>(
    stream: Stream<'scope, T, D>,
    as_of: Antichain<T>,
) -> Stream<'scope, T, D>
where
    D: timely::Container + Clone,
{
    stream.unary_frontier(Pipeline, "SuppressEarlyProgress", |default_cap, _info| {
        let mut early_cap = Some(default_cap);

        move |(input, frontier), output| {
            input.for_each_time(|data_cap, data| {
                if as_of.less_than(data_cap.time()) {
                    let mut session = output.session(&data_cap);
                    for data in data {
                        session.give_container(data);
                    }
                } else {
                    let cap = early_cap.as_ref().expect("early_cap can't be dropped yet");
                    let mut session = output.session(&cap);
                    for data in data {
                        session.give_container(data);
                    }
                }
            });

            if !PartialOrder::less_equal(&frontier.frontier(), &as_of.borrow()) {
                early_cap.take();
            }
        }
    })
}

/// Extension trait for [`Stream`] to selectively limit progress.
trait LimitProgress<T: Timestamp> {
    /// Limit the progress of the stream until its frontier reaches the given `upper` bound. Expects
    /// the implementation to observe times in data, and release capabilities based on the probe's
    /// frontier, after applying `slack` to round up timestamps.
    ///
    /// The implementation of this operator is subtle to avoid regressions in the rest of the
    /// system. Specifically joins hold back compaction on the other side of the join, so we need to
    /// make sure we release capabilities as soon as possible. This is why we only limit progress
    /// for times before the `upper`, which is the time until which the source can distinguish
    /// updates at the time of rendering. Once we make progress to the `upper`, we need to release
    /// our capability.
    ///
    /// This isn't perfect, and can result in regressions if on of the inputs lags behind. We could
    /// consider using the join of the uppers, i.e, use lower bound upper of all available inputs.
    ///
    /// Once the input frontier reaches `[]`, the implementation must release any capability to
    /// allow downstream operators to release resources.
    ///
    /// The implementation should limit the number of pending times to `limit` if it is `Some` to
    /// avoid unbounded memory usage.
    ///
    /// * `handle` is a probe installed on the dataflow's outputs as late as possible, but before
    ///   any timestamp rounding happens (c.f., `REFRESH EVERY` materialized views).
    /// * `slack_ms` is the number of milliseconds to round up timestamps to.
    /// * `name` is a human-readable name for the operator.
    /// * `limit` is the maximum number of pending times to keep around.
    /// * `upper` is the upper bound of the stream's frontier until which the implementation can
    ///   retain a capability.
    fn limit_progress(
        self,
        handle: MzProbeHandle<T>,
        slack_ms: u64,
        limit: Option<usize>,
        upper: Antichain<T>,
        name: String,
    ) -> Self;
}

/// Reads the times of the records a container holds, for [`LimitProgress`].
trait RecordTimes {
    /// Call `f` once per record, with that record's time.
    fn for_each_time(&self, f: impl FnMut(mz_repr::Timestamp));
}

impl<D, R> RecordTimes for Vec<(D, mz_repr::Timestamp, R)> {
    fn for_each_time(&self, mut f: impl FnMut(mz_repr::Timestamp)) {
        for (_, time, _) in self {
            f(*time);
        }
    }
}

impl<D, R> RecordTimes for Column<(D, mz_repr::Timestamp, R)>
where
    D: ColumnarData,
    R: ColumnarData,
    (D, mz_repr::Timestamp, R): ColumnarData<
        Container = (
            D::Container,
            <mz_repr::Timestamp as ColumnarData>::Container,
            R::Container,
        ),
    >,
{
    fn for_each_time(&self, mut f: impl FnMut(mz_repr::Timestamp)) {
        for time in self.borrow().1.into_index_iter() {
            f(time);
        }
    }
}

// TODO: We could make this generic over a `T` that can be converted to and from a u64 millisecond
// number.
impl<'scope, C> LimitProgress<mz_repr::Timestamp> for Stream<'scope, mz_repr::Timestamp, C>
where
    C: timely::Container + Clone + RecordTimes,
{
    fn limit_progress(
        self,
        handle: MzProbeHandle<mz_repr::Timestamp>,
        slack_ms: u64,
        limit: Option<usize>,
        upper: Antichain<mz_repr::Timestamp>,
        name: String,
    ) -> Self {
        let scope = self.scope();
        let stream =
            self.unary_frontier(Pipeline, &format!("LimitProgress({name})"), |_cap, info| {
                // Times that we've observed on our input.
                let mut pending_times: BTreeSet<mz_repr::Timestamp> = BTreeSet::new();
                // Capability for the lower bound of `pending_times`, if any.
                let mut retained_cap: Option<Capability<mz_repr::Timestamp>> = None;

                let activator = scope.activator_for(info.address);
                handle.activate(activator.clone());

                move |(input, frontier), output| {
                    input.for_each(|cap, data| {
                        data.for_each_time(|time| {
                            let Some(time) = u64::from(time).checked_add(slack_ms) else {
                                return;
                            };
                            // `slack_ms == 0` means no rounding; otherwise round up to the next
                            // multiple of `slack_ms`. Avoids a divide-by-zero panic when the
                            // operator is configured without slack.
                            let rounded_time = if slack_ms == 0 {
                                time
                            } else {
                                (time / slack_ms).saturating_add(1).saturating_mul(slack_ms)
                            };
                            if !upper.less_than(&rounded_time.into()) {
                                pending_times.insert(rounded_time.into());
                            }
                        });
                        output.session(&cap).give_container(data);
                        if retained_cap.as_ref().is_none_or(|c| {
                            !c.time().less_than(cap.time()) && !upper.less_than(cap.time())
                        }) {
                            retained_cap = Some(cap.retain(0));
                        }
                    });

                    handle.with_frontier(|f| {
                        while pending_times
                            .first()
                            .map_or(false, |retained_time| !f.less_than(&retained_time))
                        {
                            let _ = pending_times.pop_first();
                        }
                    });

                    while limit.map_or(false, |limit| pending_times.len() > limit) {
                        let _ = pending_times.pop_first();
                    }

                    match (retained_cap.as_mut(), pending_times.first()) {
                        (Some(cap), Some(first)) => cap.downgrade(first),
                        (_, None) => retained_cap = None,
                        _ => {}
                    }

                    if frontier.is_empty() {
                        retained_cap = None;
                        pending_times.clear();
                    }

                    if !pending_times.is_empty() {
                        tracing::debug!(
                            name,
                            info.global_id,
                            pending_times = %PendingTimesDisplay(pending_times.iter().cloned()),
                            frontier = ?frontier.frontier().get(0),
                            probe = ?handle.with_frontier(|f| f.get(0).cloned()),
                            ?upper,
                            "pending times",
                        );
                    }
                }
            });
        stream
    }
}

/// A formatter for an iterator of timestamps that displays the first element, and subsequently
/// the difference between timestamps.
struct PendingTimesDisplay<T>(T);

impl<T> std::fmt::Display for PendingTimesDisplay<T>
where
    T: IntoIterator<Item = mz_repr::Timestamp> + Clone,
{
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let mut iter = self.0.clone().into_iter();
        write!(f, "[")?;
        if let Some(first) = iter.next() {
            write!(f, "{}", first)?;
            let mut last = u64::from(first);
            for time in iter {
                write!(f, ", +{}", u64::from(time) - last)?;
                last = u64::from(time);
            }
        }
        write!(f, "]")?;
        Ok(())
    }
}

/// Helper to merge pairs of datum iterators into a row or split a datum iterator
/// into two rows, given the arity of the first component.
#[derive(Clone, Copy, Debug)]
struct Pairer {
    split_arity: usize,
}

impl Pairer {
    /// Creates a pairer with knowledge of the arity of first component in the pair.
    fn new(split_arity: usize) -> Self {
        Self { split_arity }
    }

    /// Merges a pair of datum iterators creating a `Row` instance.
    fn merge<'a, I1, I2>(&self, first: I1, second: I2) -> Row
    where
        I1: IntoIterator<Item = Datum<'a>>,
        I2: IntoIterator<Item = Datum<'a>>,
    {
        SharedRow::pack(first.into_iter().chain(second))
    }

    /// Splits a datum iterator into a pair of `Row` instances.
    fn split<'a>(&self, datum_iter: impl IntoIterator<Item = Datum<'a>>) -> (Row, Row) {
        let mut datum_iter = datum_iter.into_iter();
        let mut row_builder = SharedRow::get();
        let first = row_builder.pack_using(datum_iter.by_ref().take(self.split_arity));
        let second = row_builder.pack_using(datum_iter);
        (first, second)
    }
}