1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
use std::collections::HashMap;
use std::sync::{Arc, Mutex};
use std::time::{Duration, Instant};
use bytes::Bytes;
use mz_ore::cast::CastFrom;
use mz_persist_types::Codec;
use crate::error::Error;
use crate::gen::persist::ProtoBatchFormat;
use crate::indexed::encoding::{BlobTraceBatchPart, TraceBatchMeta};
use crate::indexed::metrics::Metrics;
use crate::location::{Atomicity, Blob};
#[derive(Debug)]
pub enum CacheHint {
MaybeAdd,
NeverAdd,
}
#[derive(Debug)]
pub struct BlobCache<B> {
metrics: Arc<Metrics>,
blob: Arc<B>,
cache: BlobCacheInner,
}
impl<B> Clone for BlobCache<B> {
fn clone(&self) -> Self {
BlobCache {
metrics: Arc::clone(&self.metrics),
blob: Arc::clone(&self.blob),
cache: self.cache.clone(),
}
}
}
const MB: usize = 1024 * 1024;
const GB: usize = 1024 * MB;
impl<B: Blob + Send + Sync + 'static> BlobCache<B> {
const DEFAULT_CACHE_SIZE_LIMIT: usize = 2 * GB;
pub fn new(metrics: Arc<Metrics>, blob: B, cache_size_limit: Option<usize>) -> Self {
BlobCache {
metrics,
blob: Arc::new(blob),
cache: BlobCacheInner::new(cache_size_limit.unwrap_or(Self::DEFAULT_CACHE_SIZE_LIMIT)),
}
}
async fn fetch_trace_batch(
&self,
key: &str,
hint: CacheHint,
) -> Result<Arc<BlobTraceBatchPart>, Error> {
let deadline = Instant::now() + Duration::from_secs(1_000_000_000);
let bytes = self
.blob
.get(deadline, key)
.await?
.ok_or_else(|| Error::from(format!("no blob for trace batch at key: {}", key)))?;
let bytes_len = bytes.len();
self.metrics
.blob_read_cache_fetch_bytes
.inc_by(u64::cast_from(bytes_len));
let batch: BlobTraceBatchPart = BlobTraceBatchPart::decode(&bytes)
.map_err(|err| Error::from(format!("invalid trace batch at key {}: {}", key, err)))?;
debug_assert_eq!(batch.validate(), Ok(()), "{:?}", &batch);
let ret = Arc::new(batch);
if let CacheHint::MaybeAdd = hint {
self.cache
.maybe_add_trace(key.to_owned(), bytes_len, Arc::clone(&ret))?;
}
Ok(ret)
}
pub async fn get_trace_batch_async(
&self,
key: &str,
hint: CacheHint,
) -> Result<Arc<BlobTraceBatchPart>, Error> {
match self.cache.get_trace(key) {
Err(err) => {
return Err(err);
}
Ok(Some(entry)) => {
self.metrics.blob_read_cache_hit_count.inc();
return Ok(entry);
}
Ok(None) => {
self.metrics.blob_read_cache_miss_count.inc();
}
}
self.fetch_trace_batch(&key, hint).await
}
}
impl<B: Blob + Send + Sync + 'static> BlobCache<B> {
pub async fn set_trace_batch(
&self,
key: String,
batch: BlobTraceBatchPart,
format: ProtoBatchFormat,
) -> Result<u64, Error> {
if format != ProtoBatchFormat::ParquetKvtd {
return Err(format!(
"cannot write trace batch with unsupported format {:?}",
format
)
.into());
}
debug_assert_eq!(batch.validate(), Ok(()), "{:?}", &batch);
let mut val = Vec::new();
batch.encode(&mut val);
let val = Bytes::from(val);
let val_len = u64::cast_from(val.len());
let write_start = Instant::now();
let deadline = Instant::now() + Duration::from_secs(1_000_000_000);
self.blob
.set(deadline, &key, val, Atomicity::AllowNonAtomic)
.await
.map_err(|err| self.metric_set_error(err.into()))?;
self.metrics
.trace
.blob_write_seconds
.inc_by(write_start.elapsed().as_secs_f64());
self.metrics.trace.blob_write_count.inc();
self.metrics.trace.blob_write_bytes.inc_by(val_len);
self.cache
.maybe_add_trace(key, usize::cast_from(val_len), Arc::new(batch))?;
Ok(val_len)
}
pub async fn delete_trace_batch(&mut self, batch: &TraceBatchMeta) -> Result<(), Error> {
let delete_start = Instant::now();
for key in batch.keys.iter() {
self.cache.remove_trace(&key)?;
let deadline = Instant::now() + Duration::from_secs(1_000_000_000);
self.blob.delete(deadline, key).await?;
}
self.metrics
.trace
.blob_delete_seconds
.inc_by(delete_start.elapsed().as_secs_f64());
self.metrics.trace.blob_delete_count.inc();
self.metrics
.trace
.blob_delete_bytes
.inc_by(batch.size_bytes);
Ok(())
}
fn metric_set_error(&self, err: Error) -> Error {
match &err {
&Error::OutOfQuota(_) => self.metrics.blob_write_error_quota_count.inc(),
_ => self.metrics.blob_write_error_other_count.inc(),
};
err
}
}
#[derive(Clone, Debug)]
struct BlobCacheInner {
trace: Arc<Mutex<BlobCacheCore<BlobTraceBatchPart>>>,
}
impl BlobCacheInner {
fn new(limit: usize) -> Self {
BlobCacheInner {
trace: Arc::new(Mutex::new(BlobCacheCore::new(limit / 2))),
}
}
fn maybe_add_trace(
&self,
key: String,
size: usize,
data: Arc<BlobTraceBatchPart>,
) -> Result<(), Error> {
let mut trace = self.trace.lock()?;
trace.add(key, size, data);
Ok(())
}
fn get_trace(&self, key: &str) -> Result<Option<Arc<BlobTraceBatchPart>>, Error> {
let trace = self.trace.lock()?;
Ok(trace.get(key))
}
fn remove_trace(&self, key: &str) -> Result<(), Error> {
let mut trace = self.trace.lock()?;
trace.remove(key);
Ok(())
}
}
#[derive(Debug)]
struct BlobCacheCore<D> {
dataz: HashMap<String, (Arc<D>, usize)>,
size: usize,
limit: usize,
}
impl<D> BlobCacheCore<D> {
fn new(limit: usize) -> Self {
BlobCacheCore {
dataz: HashMap::new(),
size: 0,
limit,
}
}
fn add(&mut self, key: String, size: usize, data: Arc<D>) {
let new_size = self.size + size;
if new_size > self.limit {
return;
}
let prev = self.dataz.insert(key, (data, size));
if prev.is_none() {
self.size = new_size;
}
debug_assert!(self.limit >= self.size);
}
fn remove(&mut self, key: &str) {
let prev = self.dataz.remove(key);
if let Some((_, size)) = prev {
debug_assert!(self.size >= size);
self.size -= size;
}
debug_assert!(self.limit >= self.size);
}
fn get(&self, key: &str) -> Option<Arc<D>> {
self.dataz.get(key).map(|(data, _)| Arc::clone(&data))
}
}