1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// included in the LICENSE file.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.
//! A timestamp oracle that relies on the [`Catalog`] for persistence/durability
//! and reserves ranges of timestamps.
use std::fmt::Debug;
use std::sync::Arc;
use std::time::Duration;
use std::{cmp, thread};
use async_trait::async_trait;
use derivative::Derivative;
use mz_catalog::memory::error::Error;
use mz_ore::now::NowFn;
use mz_repr::{Timestamp, TimestampManipulation};
use mz_storage_types::sources::Timeline;
use mz_timestamp_oracle::{
GenericNowFn, ShareableTimestampOracle, TimestampOracle, WriteTimestamp,
};
use once_cell::sync::Lazy;
use tracing::error;
use crate::catalog::Catalog;
use crate::coord::catalog_oracle;
use crate::util::ResultExt;
/// A type that provides write and read timestamps, reads observe exactly their
/// preceding writes.
///
/// Specifically, all read timestamps will be greater or equal to all previously
/// reported completed write timestamps, and strictly less than all subsequently
/// emitted write timestamps.
///
/// A timeline can perform reads and writes. Reads happen at the read timestamp
/// and writes happen at the write timestamp. After the write has completed, but
/// before a response is sent, the read timestamp must be updated to a value
/// greater than or equal to `self.write_ts`.
#[derive(Derivative)]
#[derivative(Debug)]
pub struct InMemoryTimestampOracle<T, N>
where
T: Debug,
N: GenericNowFn<T>,
{
read_ts: T,
write_ts: T,
#[derivative(Debug = "ignore")]
next: N,
}
impl<T: TimestampManipulation, N> InMemoryTimestampOracle<T, N>
where
N: GenericNowFn<T>,
{
/// Create a new timeline, starting at the indicated time. `next` generates
/// new timestamps when invoked. The timestamps have no requirements, and
/// can retreat from previous invocations.
pub fn new(initially: T, next: N) -> Self
where
N: GenericNowFn<T>,
{
Self {
read_ts: initially.clone(),
write_ts: initially,
next,
}
}
/// Acquire a new timestamp for writing.
///
/// This timestamp will be strictly greater than all prior values of
/// `self.read_ts()` and `self.write_ts()`.
fn write_ts(&mut self) -> WriteTimestamp<T> {
let mut next = self.next.now();
if next.less_equal(&self.write_ts) {
next = TimestampManipulation::step_forward(&self.write_ts);
}
assert!(self.read_ts.less_than(&next));
assert!(self.write_ts.less_than(&next));
self.write_ts = next.clone();
assert!(self.read_ts.less_equal(&self.write_ts));
let advance_to = TimestampManipulation::step_forward(&next);
WriteTimestamp {
timestamp: next,
advance_to,
}
}
/// Peek the current write timestamp.
fn peek_write_ts(&self) -> T {
self.write_ts.clone()
}
/// Acquire a new timestamp for reading.
///
/// This timestamp will be greater or equal to all prior values of
/// `self.apply_write(write_ts)`, and strictly less than all subsequent
/// values of `self.write_ts()`.
pub(crate) fn read_ts(&self) -> T {
self.read_ts.clone()
}
/// Mark a write at `write_ts` completed.
///
/// All subsequent values of `self.read_ts()` will be greater or equal to
/// `write_ts`.
pub(crate) fn apply_write(&mut self, write_ts: T) {
if self.read_ts.less_than(&write_ts) {
self.read_ts = write_ts;
if self.write_ts.less_than(&self.read_ts) {
self.write_ts = self.read_ts.clone();
}
}
assert!(self.read_ts.less_equal(&self.write_ts));
}
}
/// Interval used to persist durable timestamps. See [`CatalogTimestampOracle`]
/// for more details.
pub static TIMESTAMP_PERSIST_INTERVAL: Lazy<mz_repr::Timestamp> = Lazy::new(|| {
Duration::from_secs(5)
.as_millis()
.try_into()
.expect("5 seconds can fit into `Timestamp`")
});
/// The Coordinator tries to prevent the persisted timestamp from exceeding a
/// value [`TIMESTAMP_INTERVAL_UPPER_BOUND`] times
/// [`TIMESTAMP_PERSIST_INTERVAL`] larger than the current system time.
pub const TIMESTAMP_INTERVAL_UPPER_BOUND: u64 = 2;
/// A type that wraps a [`InMemoryTimestampOracle`] and provides durable timestamps.
/// This allows us to recover a timestamp that is larger than all previous
/// timestamps on restart. The protocol is based on timestamp recovery from
/// Percolator <https://research.google/pubs/pub36726/>. We "pre-allocate" a
/// group of timestamps at once, and only durably store the largest of those
/// timestamps. All timestamps within that interval can be served directly from
/// memory, without going to disk. On restart, we re-initialize the current
/// timestamp to a value one larger than the persisted timestamp.
///
/// See [`TimestampOracle`] for more details on the properties of the
/// timestamps.
pub struct CatalogTimestampOracle<T, N>
where
T: Debug,
N: GenericNowFn<T>,
{
timestamp_oracle: InMemoryTimestampOracle<T, N>,
durable_timestamp: T,
persist_interval: T,
timestamp_persistence: Box<dyn TimestampPersistence<T>>,
}
impl<T: TimestampManipulation, N> CatalogTimestampOracle<T, N>
where
N: GenericNowFn<T>,
{
/// Create a new durable timeline, starting at the indicated time.
/// Timestamps will be allocated in groups of size `persist_interval`. Also
/// returns the new timestamp that needs to be persisted to disk.
///
/// See [`InMemoryTimestampOracle::new`] for more details.
pub(crate) async fn new<P>(
initially: T,
next: N,
persist_interval: T,
timestamp_persistence: P,
) -> Self
where
P: TimestampPersistence<T> + 'static,
{
let mut oracle = Self {
timestamp_oracle: InMemoryTimestampOracle::new(initially.clone(), next),
durable_timestamp: initially.clone(),
persist_interval,
timestamp_persistence: Box::new(timestamp_persistence),
};
oracle.maybe_allocate_new_timestamps(&initially).await;
oracle
}
/// Checks to see if we can serve the timestamp from memory, or if we need
/// to durably store a new timestamp.
///
/// If `ts` is less than the persisted timestamp then we can serve `ts` from
/// memory, otherwise we need to durably store some timestamp greater than
/// `ts`.
async fn maybe_allocate_new_timestamps(&mut self, ts: &T) {
if self.durable_timestamp.less_equal(ts)
// Since the timestamp is at its max value, we know that no other Coord can
// allocate a higher value.
&& self.durable_timestamp.less_than(&T::maximum())
{
self.durable_timestamp = ts.step_forward_by(&self.persist_interval);
let res = self
.timestamp_persistence
.persist_timestamp(self.durable_timestamp.clone())
.await;
res.unwrap_or_terminate("can't persist timestamp");
}
}
}
#[async_trait(?Send)]
impl<T: TimestampManipulation, N> TimestampOracle<T> for CatalogTimestampOracle<T, N>
where
N: GenericNowFn<T>,
{
async fn write_ts(&mut self) -> WriteTimestamp<T> {
let ts = self.timestamp_oracle.write_ts();
self.maybe_allocate_new_timestamps(&ts.timestamp).await;
ts
}
async fn peek_write_ts(&self) -> T {
self.timestamp_oracle.peek_write_ts()
}
async fn read_ts(&self) -> T {
let ts = self.timestamp_oracle.read_ts();
assert!(
ts.less_equal(&self.durable_timestamp),
"read_ts should not advance the global timestamp, ts: {:?}, durable_timestamp: {:?}",
ts,
self.durable_timestamp
);
ts
}
async fn apply_write(&mut self, write_ts: T) {
self.timestamp_oracle.apply_write(write_ts.clone());
self.maybe_allocate_new_timestamps(&write_ts).await;
}
fn get_shared(&self) -> Option<Arc<dyn ShareableTimestampOracle<T> + Send + Sync>> {
// The in-memory TimestampOracle is not shareable:
//
// - we have in-memory state that we would have to share via an Arc/Mutex
// - we use TimestampPersistence, which is backed by catalog, which is also problematic for sharing
None
}
}
/// Provides persistence of timestamps for [`CatalogTimestampOracle`].
#[async_trait::async_trait]
pub trait TimestampPersistence<T> {
/// Persist new global timestamp to disk.
async fn persist_timestamp(&self, timestamp: T) -> Result<(), Error>;
}
/// A [`TimestampPersistence`] that is backed by a [`Catalog`].
pub(crate) struct CatalogTimestampPersistence {
timeline: Timeline,
catalog: Arc<Catalog>,
}
impl CatalogTimestampPersistence {
pub(crate) fn new(timeline: Timeline, catalog: Arc<Catalog>) -> Self {
Self { timeline, catalog }
}
}
#[async_trait::async_trait]
impl TimestampPersistence<mz_repr::Timestamp> for CatalogTimestampPersistence {
async fn persist_timestamp(&self, timestamp: mz_repr::Timestamp) -> Result<(), Error> {
self.catalog
.persist_timestamp(&self.timeline, timestamp)
.await
}
}
/// Convenience function for calculating the current upper bound that we want to
/// prevent the global timestamp from exceeding.
// TODO(aljoscha): These internal details of the oracle are leaking through to
// multiple places in the coordinator.
pub(crate) fn upper_bound(now: &mz_repr::Timestamp) -> mz_repr::Timestamp {
now.saturating_add(
TIMESTAMP_PERSIST_INTERVAL.saturating_mul(Timestamp::from(TIMESTAMP_INTERVAL_UPPER_BOUND)),
)
}
/// Returns the current system time while protecting against backwards time
/// jumps.
///
/// The caller is responsible for providing the previously recorded system time
/// via the `previous_now` parameter.
///
/// If `previous_now` is more than `TIMESTAMP_INTERVAL_UPPER_BOUND *
/// TIMESTAMP_PERSIST_INTERVAL` milliseconds ahead of the current system time
/// (i.e., due to a backwards time jump), this function will block until the
/// system time advances.
///
/// The returned time is guaranteed to be greater than or equal to
/// `previous_now`.
// TODO(aljoscha): These internal details of the oracle are leaking through to
// multiple places in the coordinator.
pub(crate) fn monotonic_now(now: NowFn, previous_now: mz_repr::Timestamp) -> mz_repr::Timestamp {
let mut now_ts = now();
let monotonic_now = cmp::max(previous_now, now_ts.into());
let mut upper_bound = catalog_oracle::upper_bound(&mz_repr::Timestamp::from(now_ts));
while monotonic_now > upper_bound {
// Cap retry time to 1s. In cases where the system clock has retreated
// by some large amount of time, this prevents against then waiting for
// that large amount of time in case the system clock then advances back
// to near what it was.
let remaining_ms = cmp::min(monotonic_now.saturating_sub(upper_bound), 1_000.into());
error!(
"Coordinator tried to start with initial timestamp of \
{monotonic_now}, which is more than \
{TIMESTAMP_INTERVAL_UPPER_BOUND} intervals of size {} larger than \
now, {now_ts}. Sleeping for {remaining_ms} ms.",
*TIMESTAMP_PERSIST_INTERVAL
);
thread::sleep(Duration::from_millis(remaining_ms.into()));
now_ts = now();
upper_bound = catalog_oracle::upper_bound(&mz_repr::Timestamp::from(now_ts));
}
monotonic_now
}
#[cfg(test)]
mod tests {
use super::*;
#[mz_ore::test(tokio::test)]
async fn test_in_memory_timestamp_oracle() -> Result<(), anyhow::Error> {
mz_timestamp_oracle::tests::timestamp_oracle_impl_test(
move |_timeline, now_fn, initial_ts| {
let persistence = NoopTimestampPersistence::new();
let oracle =
CatalogTimestampOracle::new(initial_ts, now_fn, 0u64.into(), persistence);
oracle
},
)
.await?;
Ok(())
}
/// A [`TimestampPersistence`] for use in tests.
struct NoopTimestampPersistence {}
impl NoopTimestampPersistence {
fn new() -> Self {
Self {}
}
}
#[async_trait::async_trait]
impl TimestampPersistence<mz_repr::Timestamp> for NoopTimestampPersistence {
async fn persist_timestamp(&self, _timestamp: mz_repr::Timestamp) -> Result<(), Error> {
// Yay!
Ok(())
}
}
}